Skip to content

fix(dataprotection): pass target metadata to post-ready jobs - #10839

Merged
leon-ape merged 1 commit into
release-1.1from
bugfix/post-ready-target-env-1.1
Sep 1, 2026
Merged

fix(dataprotection): pass target metadata to post-ready jobs#10839
leon-ape merged 1 commit into
release-1.1from
bugfix/post-ready-target-env-1.1

Conversation

@leon-ape

@leon-ape leon-ape commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Fixes #10679

Backport of #10838 to release-1.1.

The automatic cherry-pick conflicted only in controllers/dataprotection/restore_controller_test.go. The resolution preserves release-1.1's existing Cluster cleanup behavior and adds cleanup for the Component fixture introduced by the backport.

Validation:

  • pkg/dataprotection/restore: PASS
  • controllers/dataprotection post-ready context: PASS
  • controllers/dataprotection full suite: PASS
  • make lint: PASS
  • git diff --check: PASS

@leon-ape
leon-ape requested review from a team, ldming and wangyelei as code owners September 1, 2026 09:13
@github-actions github-actions Bot added the size/L Denotes a PR that changes 100-499 lines. label Sep 1, 2026
@apecloud-bot

Copy link
Copy Markdown
Collaborator

Auto Cherry-pick Instructions

Usage:
  - /nopick: Not auto cherry-pick when PR merged.
  - /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.

Example:
  - /nopick
  - /pick release-1.1

CLA Recheck Instructions

Usage:
  - /recheck-cla: Trigger a re-check of CLA status for this pull request.
Example:
  - /recheck-cla

@codecov

codecov Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 69.84127% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.68%. Comparing base (3ec34e3) to head (462d3bf).

Files with missing lines Patch % Lines
pkg/dataprotection/restore/manager.go 68.00% 11 Missing and 5 partials ⚠️
pkg/dataprotection/restore/builder.go 76.92% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.1   #10839      +/-   ##
===============================================
- Coverage        55.68%   55.68%   -0.01%     
===============================================
  Files              550      550              
  Lines            62434    62494      +60     
===============================================
+ Hits             34767    34800      +33     
- Misses           24349    24369      +20     
- Partials          3318     3325       +7     
Flag Coverage Δ
unittests 55.68% <69.84%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leon-ape
leon-ape merged commit 805b8b3 into release-1.1 Sep 1, 2026
33 of 34 checks passed
@leon-ape
leon-ape deleted the bugfix/post-ready-target-env-1.1 branch September 1, 2026 09:26
@github-actions github-actions Bot added this to the Release 1.2.0 milestone Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

nopick Not auto cherry-pick when PR merged size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StarRocks logical restore lacks trustworthy target topology and expected service version

2 participants