fix(dataprotection): preserve backup namespace for cross-namespace restores - #10834
Merged
leon-ape merged 4 commits intoSep 1, 2026
Merged
Conversation
Collaborator
|
Auto Cherry-pick Instructions CLA Recheck Instructions |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.0 #10834 +/- ##
===============================================
+ Coverage 54.14% 54.31% +0.16%
===============================================
Files 495 495
Lines 55950 56066 +116
===============================================
+ Hits 30296 30450 +154
+ Misses 22647 22589 -58
- Partials 3007 3027 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
/approve |
apecloud-bot
approved these changes
Aug 31, 2026
…amespace-backup-restore-release-1.0 # Conflicts: # pkg/dataprotection/restore/utils_test.go
leon-ape
deleted the
bugfix/cross-namespace-backup-restore-release-1.0
branch
September 1, 2026 04:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #10827 for
release-1.0; related issue: #10829.The final #10827 diff cannot be cherry-picked cleanly onto this branch: it conflicts in
pkg/controller/plan/restore_test.go, andpkg/dataprotection/restore/utils_test.gois absent from the original release base. This PR applies the same behavior to the release-specific controller layout and keeps tests in the standardrestore_test.go,utils_test.go, andmanager_test.gofiles.What changed
status.backupMethodwith a fatal error instead of panicking while readingsnapshotVolumes.NOT supportedand regenerate CRDs and API reference docs.release-1.0, retaining both sides of theutils_test.goadditions.Validation
scripts/codex-go-test.sh ./pkg/dataprotection/restore ./pkg/controller/plan ./controllers/dataprotection ./pkg/operations -count=1make manifestsmake docgit diff --checkAll targeted tests pass.