fix(apps): allow unpinned referenced account secrets - #10810
Merged
Conversation
Collaborator
|
Auto Cherry-pick Instructions CLA Recheck Instructions |
Collaborator
Author
|
/approve |
apecloud-bot
approved these changes
Aug 25, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10810 +/- ##
==========================================
+ Coverage 65.26% 65.37% +0.10%
==========================================
Files 510 510
Lines 64016 64017 +1
==========================================
+ Hits 41780 41848 +68
+ Misses 18497 18448 -49
+ Partials 3739 3721 -18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
/cherry-pick release-1.1 |
apecloud-bot
pushed a commit
that referenced
this pull request
Aug 25, 2026
(cherry picked from commit 20751fa)
Collaborator
|
🤖 says: cherry pick action finished successfully 🎉! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
secretRefRevisionis explicitly setWhy
A referenced account Secret managed by KubeBlocks carries the
apps.kubeblocks.io/secret-revisionannotation. When the consuming account omitted the optionalsecretRefRevision, the component controller compared that annotation with an empty value and requeued indefinitely.Omitting
secretRefRevisionshould consume the current Secret without a revision pin. An explicit value continues to require a matching Secret revision.Validation
scripts/codex-go-test.sh ./controllers/apps/component -run TestBuildAccountSecretRevisionContract -count=1scripts/codex-go-test.sh ./controllers/apps/component -count=1Fixes #10809