fix(its): correct InstanceStatus convergence semantics - #10808
Merged
leon-ape merged 8 commits intoAug 25, 2026
Conversation
Collaborator
|
Auto Cherry-pick Instructions CLA Recheck Instructions |
leon-ape
requested review from
JashBook,
ahjing99,
ldming and
wangyelei
as code owners
August 25, 2026 08:55
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-1.1 #10808 +/- ##
===============================================
+ Coverage 54.35% 55.67% +1.31%
===============================================
Files 546 550 +4
Lines 61511 62322 +811
===============================================
+ Hits 33432 34695 +1263
+ Misses 24868 24325 -543
- Partials 3211 3302 +91
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
/approve |
apecloud-bot
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release-1.1, where chore: publish richer InstanceSet instance status #10791 already introduced the richer status from chore: publish richer InstanceSet instance status #10758UpToDateas convergence of an Active/Present instance across its Pod target, dynamic configs, and PVC expansion while keeping runtime health independentUpToDatefor a desired Active identity whose current Pod/Instance is missing during generation handoff, without rewriting runtime health fieldsRelease 1.1 adaptation
This cannot be an automatic cherry-pick of #10799:
release-1.1represents dynamic config convergence withConfigTemplate.GenerationandInstanceConfigStatus.Generation; main uses config hashesUpToDatesemanticsNo generation field is added.
status.observedGenerationstill means that the controller has observed and started processing that InstanceSet generation; it does not make status an atomic snapshot. The existing StatusReconciler-before-RevisionUpdateReconciler order is unchanged.Ready, Available, Failed, and Role remain current runtime observations. Add/remove/offline/released identities remain represented by DesiredState and CurrentState. No Apps or Ops logic is introduced into workload status producers.
Tests are added to existing release-1.1 test files; this PR introduces no new test files.
Validation
pkg/controller/instancepkg/controller/instancesetpkg/controller/instanceset2pkg/controller/workloads/instancestatuspkg/controllerutilcontrollers/workloadsenvtest suitepkg/operations/...andcontrollers/operations/...make generate,make manifests,make doc, andmake lintBackport of #10799. Related to #10800.
Fixes #10807