chore(test): fix zero-replica component scale-out coverage (#10824)

Author: leon-ape

controllers/apps/component/component_controller_test.go

@@ -2065,27 +2065,29 @@ var _ = Describe("Component Controller", func() {
 
 			By("check comp & its")
 			Eventually(testapps.CheckObj(&testCtx, compKey, func(g Gomega, comp *kbappsv1.Component) {
-				g.Expect(comp.Spec.Replicas).Should(Equal(3))
+				g.Expect(comp.Spec.Replicas).Should(Equal(int32(3)))
 				g.Expect(comp.Status.ObservedGeneration < comp.Generation).Should(BeTrue())
 				g.Expect(comp.Status.Phase).Should(Equal(kbappsv1.StoppedComponentPhase))
-			}))
+			})).Should(Succeed())
 			itsKey := compKey
 			Consistently(testapps.CheckObj(&testCtx, itsKey, func(g Gomega, its *workloads.InstanceSet) {
-				g.Expect(*its.Spec.Replicas).To(BeEquivalentTo(0))
-			}))
+				g.Expect(its.Spec.Stop).ShouldNot(BeNil())
+				g.Expect(*its.Spec.Stop).Should(BeTrue())
+				g.Expect(*its.Spec.Replicas).Should(BeEquivalentTo(1))
+			})).Should(Succeed())
 
 			By("start it")
 			startComp()
 
 			By("check comp & its")
 			Eventually(testapps.CheckObj(&testCtx, compKey, func(g Gomega, comp *kbappsv1.Component) {
-				g.Expect(comp.Spec.Replicas).Should(Equal(3))
+				g.Expect(comp.Spec.Replicas).Should(Equal(int32(3)))
 				g.Expect(comp.Status.ObservedGeneration).Should(Equal(comp.Generation))
-				g.Expect(comp.Status.Phase).Should(Equal(kbappsv1.UpdatingComponentPhase))
-			}))
+			})).Should(Succeed())
 			Eventually(testapps.CheckObj(&testCtx, itsKey, func(g Gomega, its *workloads.InstanceSet) {
-				g.Expect(*its.Spec.Replicas).To(BeEquivalentTo(3))
-			}))
+				g.Expect(its.Spec.Stop).Should(BeNil())
+				g.Expect(*its.Spec.Replicas).Should(BeEquivalentTo(3))
+			})).Should(Succeed())
 		})
 
 		It("h-scale a stopped component - w/ data actions", func() {
@@ -2111,27 +2113,63 @@ var _ = Describe("Component Controller", func() {
 
 			By("check comp & its")
 			Eventually(testapps.CheckObj(&testCtx, compKey, func(g Gomega, comp *kbappsv1.Component) {
-				g.Expect(comp.Spec.Replicas).Should(Equal(3))
+				g.Expect(comp.Spec.Replicas).Should(Equal(int32(3)))
 				g.Expect(comp.Status.ObservedGeneration < comp.Generation).Should(BeTrue())
 				g.Expect(comp.Status.Phase).Should(Equal(kbappsv1.StoppedComponentPhase))
-			}))
+			})).Should(Succeed())
 			itsKey := compKey
 			Consistently(testapps.CheckObj(&testCtx, itsKey, func(g Gomega, its *workloads.InstanceSet) {
-				g.Expect(*its.Spec.Replicas).To(BeEquivalentTo(0))
-			}))
+				g.Expect(its.Spec.Stop).ShouldNot(BeNil())
+				g.Expect(*its.Spec.Stop).Should(BeTrue())
+				g.Expect(*its.Spec.Replicas).Should(BeEquivalentTo(1))
+			})).Should(Succeed())
 
 			By("start it")
 			startComp()
 
-			By("check comp & its")
-			Eventually(testapps.CheckObj(&testCtx, compKey, func(g Gomega, comp *kbappsv1.Component) {
-				g.Expect(comp.Spec.Replicas).Should(Equal(3))
-				g.Expect(comp.Status.ObservedGeneration).Should(Equal(comp.Generation))
-				g.Expect(comp.Status.Phase).Should(Equal(kbappsv1.UpdatingComponentPhase))
-			}))
+			By("check start is applied before scale-out is blocked by the missing source pod")
 			Eventually(testapps.CheckObj(&testCtx, itsKey, func(g Gomega, its *workloads.InstanceSet) {
-				g.Expect(*its.Spec.Replicas).To(BeEquivalentTo(3))
-			}))
+				g.Expect(its.Spec.Stop).Should(BeNil())
+				g.Expect(*its.Spec.Replicas).Should(BeEquivalentTo(1))
+			})).Should(Succeed())
+			Consistently(testapps.CheckObj(&testCtx, itsKey, func(g Gomega, its *workloads.InstanceSet) {
+				g.Expect(*its.Spec.Replicas).Should(BeEquivalentTo(1))
+			})).Should(Succeed())
+
+			By("restore the component to a reconcilable state")
+			Expect(testapps.GetAndChangeObj(&testCtx, compKey, func(comp *kbappsv1.Component) {
+				comp.Spec.Stop = ptr.To(true)
+				comp.Spec.Replicas = 1
+			})()).Should(Succeed())
+			checkCompStopped()
+		})
+
+		It("starts a stopped zero-replica component and then scales it to one", func() {
+			changeReplicasLimit(compDefObj.Name, 0, 16384)
+			createCompObjWithPhase(defaultCompName, compDefObj.Name, func(f *testapps.MockComponentFactory) {
+				f.SetReplicas(0).SetStop(ptr.To(true))
+			}, kbappsv1.StoppedComponentPhase)
+
+			itsKey := compKey
+			Eventually(testapps.CheckObj(&testCtx, itsKey, func(g Gomega, its *workloads.InstanceSet) {
+				g.Expect(its.Spec.Stop).ShouldNot(BeNil())
+				g.Expect(*its.Spec.Stop).Should(BeTrue())
+				g.Expect(*its.Spec.Replicas).Should(BeEquivalentTo(0))
+			})).Should(Succeed())
+
+			By("start the component")
+			startComp()
+			Eventually(testapps.CheckObj(&testCtx, itsKey, func(g Gomega, its *workloads.InstanceSet) {
+				g.Expect(its.Spec.Stop).Should(BeNil())
+				g.Expect(*its.Spec.Replicas).Should(BeEquivalentTo(0))
+			})).Should(Succeed())
+
+			By("scale the component from zero to one")
+			changeCompReplicas(compKey, 1)
+			Eventually(testapps.CheckObj(&testCtx, itsKey, func(g Gomega, its *workloads.InstanceSet) {
+				g.Expect(its.Spec.Stop).Should(BeNil())
+				g.Expect(*its.Spec.Replicas).Should(BeEquivalentTo(1))
+			})).Should(Succeed())
 		})
 
 		// TODO: stop a component in h-scaling

controllers/apps/component/transformer_component_workload_test.go

@@ -26,6 +26,7 @@ import (
 	corev1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/api/resource"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/utils/ptr"
 
 	appsv1 "github.com/apecloud/kubeblocks/apis/apps/v1"
 	workloads "github.com/apecloud/kubeblocks/apis/workloads/v1"
@@ -112,6 +113,38 @@ var _ = Describe("Component Workload Operations Test", func() {
 		dag = newDAG(graphCli, comp)
 	})
 
+	Context("Data Replication Operations", func() {
+		It("blocks scale-out when data actions have no source pod", func() {
+			synthesizeComp.Replicas = 1
+			synthesizeComp.LifecycleActions.DataDump = testapps.NewLifecycleAction("data-dump")
+			synthesizeComp.LifecycleActions.DataLoad = testapps.NewLifecycleAction("data-load")
+
+			runningITS := testapps.NewInstanceSetFactory(testCtx.DefaultNamespace,
+				"test-its", clusterName, compName).
+				AddAppInstanceLabel(clusterName).
+				AddAppComponentLabel(compName).
+				AddAppManagedByLabel().
+				SetReplicas(0).
+				GetObject()
+			protoITS := runningITS.DeepCopy()
+			protoITS.Spec.Replicas = ptr.To(int32(1))
+
+			transCtx := &componentTransformContext{
+				Context:             ctx,
+				Client:              graphCli,
+				Logger:              logger,
+				EventRecorder:       clusterRecorder,
+				Component:           comp,
+				SynthesizeComponent: synthesizeComp,
+			}
+			ops, err := newComponentWorkloadOps(transCtx, k8sClient, synthesizeComp,
+				comp, runningITS, protoITS, dag)
+			Expect(err).ShouldNot(HaveOccurred())
+
+			Expect(ops.scaleOut()).Should(MatchError("no available pod to dump data"))
+		})
+	})
+
 	Context("Member Leave Operations", func() {
 		var (
 			ops  *componentWorkloadOps