review feedback

Author: nastra

common/src/main/java/org/apache/iceberg/common/DynClasses.java

@@ -67,7 +67,7 @@ public Builder impl(String className) {
       try {
         this.foundClass = Class.forName(className, true, loader);
       } catch (ClassNotFoundException | NoClassDefFoundError | ExceptionInInitializerError e) {
-        // not the right implementation
+        // cannot load this implementation
       }
 
       return this;

common/src/main/java/org/apache/iceberg/common/DynFields.java

@@ -236,7 +236,7 @@ public Builder impl(String className, String fieldName) {
         Class<?> targetClass = Class.forName(className, true, loader);
         impl(targetClass, fieldName);
       } catch (ClassNotFoundException | NoClassDefFoundError | ExceptionInInitializerError e) {
-        // not the right implementation
+        // cannot load this implementation
         candidates.add(className + "." + fieldName);
       }
       return this;
@@ -285,7 +285,7 @@ public Builder hiddenImpl(String className, String fieldName) {
         Class<?> targetClass = Class.forName(className, true, loader);
         hiddenImpl(targetClass, fieldName);
       } catch (ClassNotFoundException | NoClassDefFoundError | ExceptionInInitializerError e) {
-        // not the right implementation
+        // cannot load this implementation
         candidates.add(className + "." + fieldName);
       }
       return this;

common/src/main/java/org/apache/iceberg/common/DynMethods.java

@@ -253,7 +253,7 @@ public Builder impl(String className, String methodName, Class<?>... argClasses)
         Class<?> targetClass = Class.forName(className, true, loader);
         impl(targetClass, methodName, argClasses);
       } catch (ClassNotFoundException | NoClassDefFoundError | ExceptionInInitializerError e) {
-        // not the right implementation
+        // cannot load this implementation
       }
       return this;
     }
@@ -334,7 +334,7 @@ public Builder hiddenImpl(String className, String methodName, Class<?>... argCl
         Class<?> targetClass = Class.forName(className, true, loader);
         hiddenImpl(targetClass, methodName, argClasses);
       } catch (ClassNotFoundException | NoClassDefFoundError | ExceptionInInitializerError e) {
-        // not the right implementation
+        // cannot load this implementation
       }
       return this;
     }

core/src/main/java/org/apache/iceberg/InternalData.java

@@ -67,7 +67,8 @@ private static void registerSupportedFormats() {
 
     } catch (NoSuchMethodException | NoClassDefFoundError | ExceptionInInitializerError e) {
       // failing to load Parquet is normal and does not require a stack trace
-      LOG.info("Unable to register Parquet for metadata files: {}", e.getMessage());
+      String message = e.getCause() != null ? e.getCause().getMessage() : e.getMessage();
+      LOG.info("Unable to register Parquet for metadata files: {}", message);
     }
   }
 

core/src/main/java/org/apache/iceberg/formats/FormatModelRegistry.java

@@ -207,10 +207,11 @@ private static void registerSupportedFormats() {
         DynMethods.builder("register").impl(classToRegister).buildStaticChecked().invoke();
       } catch (NoSuchMethodException | NoClassDefFoundError | ExceptionInInitializerError e) {
         // failing to register a factory is normal and does not require a stack trace
+        String message = e.getCause() != null ? e.getCause().getMessage() : e.getMessage();
         LOG.info(
             "Unable to call register for ({}). Check for missing jars on the classpath: {}",
             classToRegister,
-            e.getMessage());
+            message);
       }
     }
   }