fix pipeline result naming inconsistency in Dataflow runner#38254
fix pipeline result naming inconsistency in Dataflow runner#38254Subramanya-Veeregowda wants to merge 2 commits intoapache:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses naming inconsistencies regarding PipelineResult implementations across different runners in the Apache Beam codebase. By improving the documentation in both the core interface and the specific Dataflow implementation, the changes provide better clarity for developers regarding how various runners represent pipeline execution results. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
@stankiewicz Hello, can you review this pr? |
|
Assigning reviewers: R: @Abacn for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
| * | ||
| * <p>This is often a job handle to an underlying data processing engine. | ||
| * | ||
| * <p>Different runners provide their own implementations of this interface. However, the naming of |
There was a problem hiding this comment.
I'm not sure what value addition these comments brings. these namings as part of internal implementation details doesn't affect how user consumes PipelineResult
There was a problem hiding this comment.
Thanks for the feedback! That makes sense — this detail may not be very useful for end users. I’ll simplify/remove the comment to keep the documentation concise.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #38254 +/- ##
=============================================
+ Coverage 54.61% 58.51% +3.89%
- Complexity 1689 15428 +13739
=============================================
Files 1067 2851 +1784
Lines 168155 280080 +111925
Branches 1226 12333 +11107
=============================================
+ Hits 91844 163885 +72041
- Misses 74116 109773 +35657
- Partials 2195 6422 +4227
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes incorrect/inconsistent pipeline result naming in the Dataflow runner.
The existing implementation had naming inconsistencies which could lead to confusion and reduced clarity in pipeline execution results.
Updated pipeline result naming logic
Ensured consistency across related components
Minor code cleanup where necessary
Built using ./gradlew :sdks:java:core:build
Ran relevant tests successfully
Verified formatting with spotlessCheck
No breaking changes introduced.
closes #18064
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.