Add outstanding parameters to processElement and onTimer signatures

[stankiewicz]

Add outstanding recordId, recordOffset and fireTimestamp as they were missing in reflection module.

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Apache Beam SDK by adding new parameters to the signatures of processElement and onTimer methods in DoFn. These additions include recordId, recordOffset, and fireTimestamp, which provide more context and control within the data processing pipeline. The changes also introduce new annotations to facilitate the use of these parameters and ensure they are accessed correctly within the appropriate method contexts.

Highlights

• New Parameters: Added recordId, recordOffset, and fireTimestamp parameters to processElement and onTimer signatures, enhancing the flexibility of DoFn methods.
• Annotations: Introduced new annotations (@CurrentRecordId, @CurrentRecordOffset, @FireTimestamp) to tag parameters in DoFn methods.
• Exception Handling: Implemented specific UnsupportedOperationException messages to prevent incorrect access to recordId, recordOffset, and fireTimestamp outside their intended contexts.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

[stankiewicz]

Run Java PreCommit

[stankiewicz]

Run Java_PVR_Prism_Loopback PreCommit

[github-actions]

Assigning reviewers:

R: @kennknowles for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.75%. Comparing base (0afbdf6) to head (88a82a6).
⚠️ Report is 221 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##             master   #37933   +/-   ##
=========================================
  Coverage     54.75%   54.75%           
  Complexity     1690     1690           
=========================================
  Files          1063     1063           
  Lines        166898   166898           
  Branches       1226     1226           
=========================================
  Hits          91377    91377           
  Misses        73328    73328           
  Partials       2193     2193           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Reminder, please take a look at this pr: @kennknowles

[kennknowles]

Is fire timestamp for looking at when a timer was set to fire, even when it has an output timestamp that is different? (sorry if I just missed that one)

[stankiewicz]

Is fire timestamp for looking at when a timer was set to fire, even when it has an output timestamp that is different? (sorry if I just missed that one)

Kenn, I didn't have much thought about meaning of it, the goal was to fill the gap between OnTimerContext:

https://github.com/stankiewicz/beam/blob/a05482e92d977a0ea6b8dd39f681f1a58d4c87e8/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFn.java#L348-L351

and allowing to refer to same via signature. fire timestamp is scheduled time and is different from output timestamp.

[stankiewicz]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces three new parameter annotations for DoFn methods: @CurrentRecordId, @CurrentRecordOffset, and @FireTimestamp. These allow users to access record metadata and timer firing timestamps directly as method arguments in @ProcessElement and @ontimer methods. The changes include updates to the DoFn interface, reflection logic for signature validation, ByteBuddy-based invoker generation, and implementations across various runners (SimpleDoFnRunner, FnApiDoFnRunner). The review feedback correctly identifies several Javadoc inconsistencies where the documentation used incorrect names for the new annotations or omitted them from the supported parameter lists for @OnTimerFamily.