Conversation
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
| push: | ||
| tags: ['v*'] | ||
| branches: ['master', 'release-*'] | ||
| paths: ["sdks/python/**","release/**",".github/workflows/beam_PreCommit_PythonLint.yml"] |
There was a problem hiding this comment.
PythonLint -> Python_Pyrefly
|
|
||
| jobs: | ||
| typecheck: | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
shall we use [self-hosted, ubuntu-20.04, small] ?
|
Assigning reviewers: R: @Abacn for label build. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Reminder, please take a look at this pr: @Abacn |
|
Apologies for stopping work on this, I may have found a more impactful solution here. Will follow up and close this PR if the different approach is useful |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @liferoad for label build. Available commands:
|
|
waiting on author |
|
This got rolled into #38107, closing this |
Adds a pyrefly static type checking precommit to Beam, enforcing checks to avoid introducing new breakages.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.