Commit c2b7711
committed
Implement
For more context: https://github.com/apache/arrow-go/pull/558/changes#r2758798540
This commit introduces an implementation of `UnsafeAppendBoolToBitmap()`
to `dictionaryBuilder` and `RunEndEncodedBuilder`. The current
implementation pulled from `arrow/array/builder.go` would leave the
builders in invalid states that would panic when trying to finish a
record batch.
For `dictionaryBuilder`, we defer the implementation to the inner
`indexBuilder`, which will in turn increase the logical length of the
inner buffer and set the bit.
For `RunEndEncodedBuilder` I decided to just panic after talking to
@felipecrv since the semantics of what it should do are not clear.UnsafeAppendBoolToBitmap for dictionary and REE builders1 parent a6c0a5e commit c2b7711
2 files changed
+10
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
646 | 646 | | |
647 | 647 | | |
648 | 648 | | |
| 649 | + | |
| 650 | + | |
| 651 | + | |
| 652 | + | |
| 653 | + | |
| 654 | + | |
649 | 655 | | |
650 | 656 | | |
651 | 657 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
398 | 398 | | |
399 | 399 | | |
400 | 400 | | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
401 | 405 | | |
402 | 406 | | |
403 | 407 | | |
| |||
0 commit comments