Skip to content

fix(site): avoid default otk-agentic-bubble-list layout in docs#9606

Closed
chenshuai2144 wants to merge 1 commit intomasterfrom
cursor/otk-agentic-bubble-list-reset-3cf6
Closed

fix(site): avoid default otk-agentic-bubble-list layout in docs#9606
chenshuai2144 wants to merge 1 commit intomasterfrom
cursor/otk-agentic-bubble-list-reset-3cf6

Conversation

@chenshuai2144
Copy link
Copy Markdown
Contributor

Summary

The class .otk-agentic-bubble-list (from Ant Design Agentic) applies a fixed flex column layout with gap: 32px, min-height: 200px, padding, and scroll overflow. This change adds a site-level override so the ProComponents dumi site does not inherit that behavior for embedded Agentic bubble lists.

Changes

  • New site/theme/otkAgenticBubbleListReset.less to reset those properties to neutral values (display: block, gap: 0, min-height: 0, no extra padding, overflow: visible, and zero vertical padding on .otk-agentic-bubble-list-content-list).
  • Register the file in site-dumi-plugin.ts next to markdownExternalLink.less.

Note

pnpm run tsc was not run in this environment because node_modules is not installed.

Submitted by Cursor

Open in Web Open in Cursor 

Add site theme reset so embedded Agentic bubble list does not force
flex column, gap, min-height, padding, and scroll on ProComponents docs.

Co-authored-by: 陈帅 <wasd2144@hotmail.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 23, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1b072707-17ac-43b2-896e-add90e1cf592

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/otk-agentic-bubble-list-reset-3cf6

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.53%. Comparing base (bdbf841) to head (ff3c08d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9606   +/-   ##
=======================================
  Coverage   88.53%   88.53%           
=======================================
  Files         368      368           
  Lines       11257    11257           
  Branches     4157     4157           
=======================================
  Hits         9966     9966           
  Misses       1139     1139           
  Partials      152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new style reset file, otkAgenticBubbleListReset.less, and registers it within the site-dumi-plugin.ts configuration to adjust the layout of Ant Design Agentic bubble lists. The review feedback suggests optimizing the CSS by removing redundant flexbox properties that are inactive under display: block and recommends using idiomatic LESS nesting for descendant selectors to improve maintainability.

Comment on lines +4 to +6
display: block;
flex-direction: initial;
gap: 0;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

When display: block is applied, flex-specific properties like flex-direction and gap are ignored by the browser. While including them can be a defensive measure against other styles overriding the display property back to flex, they are technically redundant here. If the intention is to completely revert to a block layout, these lines can be removed to keep the CSS cleaner.

  display: block;
  min-height: 0;

Comment on lines +12 to +15
.otk-agentic-bubble-list .otk-agentic-bubble-list-content-list {
padding-top: 0;
padding-bottom: 0;
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In Less, it is more idiomatic to use nesting for descendant selectors. This improves readability and maintainability by visually grouping related styles.

  .otk-agentic-bubble-list-content-list {
    padding-top: 0;
    padding-bottom: 0;
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants