Autocorrecting rubocop offenses

TonsOfFun · TonsOfFun · commit e129e4be2d89 · 2025-04-11T18:44:24.000+09:00
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -4,8 +4,8 @@ inherit_gem: { rubocop-rails-omakase: rubocop.yml }
 # Overwrite or add rules to create your own house style
 #
 # # Use `[a, [b, c]]` not `[ a, [ b, c ] ]`
-Layout/SpaceInsideArrayLiteralBrackets:
-  Enabled: false
+# Layout/SpaceInsideArrayLiteralBrackets:
+#   Enabled: false
 
 AllCops:
   TargetRubyVersion: 3.3
diff --git a/activeagent.gemspec b/activeagent.gemspec
@@ -5,7 +5,7 @@ Gem::Specification.new do |spec|
   spec.version = ActiveAgent::VERSION
   spec.summary = "Rails AI Agents Framework"
   spec.description = "The only agent-oriented AI framework designed for Rails, where Agents are Controllers. Build AI features with less complexity using the MVC conventions you love."
-  spec.authors = ["Justin Bowen"]
+  spec.authors = [ "Justin Bowen" ]
   spec.email = "jusbowen@gmail.com"
   spec.files = Dir["CHANGELOG.md", "README.rdoc", "MIT-LICENSE", "lib/**/*"]
   spec.require_paths = "lib"
diff --git a/lib/active_agent/action_prompt.rb b/lib/active_agent/action_prompt.rb
@@ -85,10 +85,10 @@ def collect_responses_from_block(headers, &block)
     end
 
     def collect_responses_from_text(headers)
-      [{
+      [ {
         body: headers.delete(:body),
         content_type: headers[:content_type] || "text/plain"
-      }]
+      } ]
     end
 
     def collect_responses_from_templates(headers)
@@ -97,7 +97,7 @@ def collect_responses_from_templates(headers)
       each_template(Array(templates_path), templates_name).map do |template|
         format = template.format || formats.first
         {
-          body: render(template: template, formats: [format]),
+          body: render(template: template, formats: [ format ]),
           content_type: Mime[format].to_s
         }
       end
diff --git a/lib/active_agent/action_prompt/collector.rb b/lib/active_agent/action_prompt/collector.rb
@@ -25,7 +25,7 @@ def any(*args, &block)
 
       def custom(mime, options = {})
         options.reverse_merge!(content_type: mime.to_s)
-        @context.formats = [mime.to_sym]
+        @context.formats = [ mime.to_sym ]
         options[:body] = block_given? ? yield : @default_render.call
         @responses << options
       end
diff --git a/lib/active_agent/action_prompt/prompt.rb b/lib/active_agent/action_prompt/prompt.rb
@@ -68,7 +68,7 @@ def headers(headers = {})
       private
 
       def set_messages
-        @messages = [Message.new(content: @instructions, role: :system)] + @messages if @instructions.present?
+        @messages = [ Message.new(content: @instructions, role: :system) ] + @messages if @instructions.present?
       end
 
       def set_message
diff --git a/lib/active_agent/base.rb b/lib/active_agent/base.rb
@@ -53,7 +53,7 @@ class Base < AbstractController::Base
 
     include ActionView::Layouts
 
-    PROTECTED_IVARS = AbstractController::Rendering::DEFAULT_PROTECTED_INSTANCE_VARIABLES + [:@_action_has_layout]
+    PROTECTED_IVARS = AbstractController::Rendering::DEFAULT_PROTECTED_INSTANCE_VARIABLES + [ :@_action_has_layout ]
 
     helper ActiveAgent::PromptHelper
 
@@ -63,7 +63,7 @@ class Base < AbstractController::Base
       mime_version: "1.0",
       charset: "UTF-8",
       content_type: "text/plain",
-      parts_order: ["text/plain", "text/enriched", "text/html"]
+      parts_order: [ "text/plain", "text/enriched", "text/html" ]
     }.freeze
 
     class << self
@@ -324,7 +324,7 @@ def prompt(headers = {}, &block)
     def action_schemas
       action_methods.map do |action|
         if action != "text_prompt"
-          JSON.parse render_to_string(locals: {action_name: action}, action: action, formats: :json)
+          JSON.parse render_to_string(locals: { action_name: action }, action: action, formats: :json)
         end
       end.compact
     end
@@ -345,7 +345,7 @@ def set_content_type(m, user_content_type, class_default) # :doc:
     # If the subject has interpolations, you can pass them through the +interpolations+ parameter.
     def default_i18n_subject(interpolations = {}) # :doc:
       agent_scope = self.class.agent_name.tr("/", ".")
-      I18n.t(:subject, **interpolations.merge(scope: [agent_scope, action_name], default: action_name.humanize))
+      I18n.t(:subject, **interpolations.merge(scope: [ agent_scope, action_name ], default: action_name.humanize))
     end
 
     def apply_defaults(headers)
@@ -390,10 +390,10 @@ def collect_responses_from_block(headers)
     end
 
     def collect_responses_from_text(headers)
-      [{
+      [ {
         body: headers.delete(:body),
         content_type: headers[:content_type] || "text/plain"
-      }]
+      } ]
     end
 
     def collect_responses_from_templates(headers)
@@ -405,7 +405,7 @@ def collect_responses_from_templates(headers)
 
         format = template.format || formats.first
         {
-          body: render(template: template, formats: [format]),
+          body: render(template: template, formats: [ format ]),
           content_type: Mime[format].to_s
         }
       end.compact
diff --git a/lib/active_agent/generation_provider/open_ai_provider.rb b/lib/active_agent/generation_provider/open_ai_provider.rb
@@ -78,7 +78,7 @@ def provider_messages(messages)
           }.compact
 
           if message.content_type == "image_url"
-            provider_message[:image_url] = {url: message.content}
+            provider_message[:image_url] = { url: message.content }
           end
           provider_message
         end
@@ -110,7 +110,7 @@ def handle_actions(tool_calls)
 
         tool_calls.map do |tool_call|
           next if tool_call["function"].nil? || tool_call["function"]["name"].blank?
-          args = tool_call["function"]["arguments"].blank? ? nil : JSON.parse(tool_call["function"]["arguments"], {symbolize_names: true})
+          args = tool_call["function"]["arguments"].blank? ? nil : JSON.parse(tool_call["function"]["arguments"], { symbolize_names: true })
 
           ActiveAgent::ActionPrompt::Action.new(
             id: tool_call["id"],
diff --git a/lib/active_agent/preview.rb b/lib/active_agent/preview.rb
@@ -11,7 +11,7 @@ module Previews # :nodoc:
 
       mattr_accessor :show_previews, instance_writer: false
 
-      mattr_accessor :preview_interceptors, instance_writer: false, default: [ActiveAgent::InlinePreviewInterceptor]
+      mattr_accessor :preview_interceptors, instance_writer: false, default: [ ActiveAgent::InlinePreviewInterceptor ]
     end
 
     module ClassMethods
diff --git a/lib/active_agent/railtie.rb b/lib/active_agent/railtie.rb
@@ -29,7 +29,7 @@ class Railtie < Rails::Railtie # :nodoc:
       options.stylesheets_dir ||= paths["public/stylesheets"].first
       options.show_previews = Rails.env.development? if options.show_previews.nil?
       options.cache_store ||= Rails.cache
-      options.preview_paths |= ["#{Rails.root}/test/agents/previews"]
+      options.preview_paths |= [ "#{Rails.root}/test/agents/previews" ]
 
       # make sure readers methods get compiled
       options.asset_host ||= app.config.asset_host
@@ -45,7 +45,7 @@ class Railtie < Rails::Railtie # :nodoc:
         register_interceptors(options.delete(:interceptors))
         register_preview_interceptors(options.delete(:preview_interceptors))
         register_observers(options.delete(:observers))
-        self.view_paths = ["#{Rails.root}/app/views"]
+        self.view_paths = [ "#{Rails.root}/app/views" ]
         self.preview_paths |= options[:preview_paths]
 
         if (generation_job = options.delete(:generation_job))
diff --git a/spec/active_agent/action_prompt/message_spec.rb b/spec/active_agent/action_prompt/message_spec.rb
@@ -52,13 +52,13 @@
       message = described_class.new(
         role: "user",
         content: "hello",
-        requested_actions: ["action1", "action2"]
+        requested_actions: [ "action1", "action2" ]
       )
       expect(message.to_h).to eq({
         role: "user",
         content: "hello",
         action_requested: true,
-        requested_actions: ["action1", "action2"]
+        requested_actions: [ "action1", "action2" ]
       })
     end
   end
diff --git a/spec/active_agent/action_prompt/prompt_spec.rb b/spec/active_agent/action_prompt/prompt_spec.rb
@@ -24,8 +24,8 @@
     context "with custom attributes" do
       let(:attributes) do
         {
-          options: {foo: "bar"},
-          actions: ["action1"],
+          options: { foo: "bar" },
+          actions: [ "action1" ],
           body: "test body",
           content_type: "text/markdown",
           instructions: "test instructions",
@@ -36,8 +36,8 @@
       subject(:prompt) { described_class.new(attributes) }
 
       it "sets custom values" do
-        expect(prompt.options).to eq({foo: "bar"})
-        expect(prompt.actions).to eq(["action1"])
+        expect(prompt.options).to eq({ foo: "bar" })
+        expect(prompt.actions).to eq([ "action1" ])
         expect(prompt.body).to eq("test body")
         expect(prompt.content_type).to eq("text/markdown")
         expect(prompt.charset).to eq("ASCII")
@@ -49,25 +49,25 @@
     let(:message) { ActiveAgent::ActionPrompt::Message.new(content: "test content", role: :user) }
     let(:attributes) do
       {
-        actions: ["action1"],
+        actions: [ "action1" ],
         action_choice: "choice1",
         instructions: "test instructions",
         message: message,
-        context: ["context1"]
+        context: [ "context1" ]
       }
     end
 
     subject(:prompt) { described_class.new(attributes) }
 
     it "returns correct hash representation" do
       expect(prompt.to_h).to eq({
-        actions: ["action1"],
+        actions: [ "action1" ],
         action: "choice1",
         instructions: attributes[:instructions],
         message: message.to_h,
-        messages: [ActiveAgent::ActionPrompt::Message.new(role: :system, content: attributes[:instructions]).to_h, message.to_h],
+        messages: [ ActiveAgent::ActionPrompt::Message.new(role: :system, content: attributes[:instructions]).to_h, message.to_h ],
         headers: {},
-        context: ["context1"]
+        context: [ "context1" ]
       })
     end
   end
diff --git a/spec/active_agent/generation_provider/base_spec.rb b/spec/active_agent/generation_provider/base_spec.rb
@@ -1,7 +1,7 @@
 require "active_agent/generation_provider/base"
 
 RSpec.describe ActiveAgent::GenerationProvider::Base do
-  let(:messages) { [{role: "user", content: "test message"}] }
+  let(:messages) { [ { role: "user", content: "test message" } ] }
   let(:mock_prompt) { double("Prompt", messages: messages) }
 
   describe "#prompt_parameters" do
@@ -31,7 +31,7 @@
     end
 
     context "with custom temperature" do
-      let(:config) { {"temperature" => 0.9} }
+      let(:config) { { "temperature" => 0.9 } }
       let(:base) { described_class.new(config) }
 
       before do
diff --git a/spec/active_agent/generation_provider/open_ai_provider_spec.rb b/spec/active_agent/generation_provider/open_ai_provider_spec.rb
@@ -16,14 +16,14 @@
   end
 
   let(:message) { instance_double(ActiveAgent::ActionPrompt::Message, content: "Hello", role: "user") }
-  let(:messages) { [{role: "user", content: "Hello"}] }
-  let(:actions) { [{name: "test_action", parameters: {}}] }
+  let(:messages) { [ { role: "user", content: "Hello" } ] }
+  let(:actions) { [ { name: "test_action", parameters: {} } ] }
 
   let(:mock_prompt) do
     instance_double("ActiveAgent::ActionPrompt::Prompt",
       messages: messages,
       actions: actions,
-      options: {stream: false},
+      options: { stream: false },
       message: message).tap do |prompt|
       allow(prompt).to receive(:message=)
       allow(prompt.messages).to receive(:<<)
@@ -67,13 +67,13 @@
 
     let(:mock_response) do
       {
-        "choices" => [{
+        "choices" => [ {
           "message" => {
             "content" => "Test response",
             "role" => "assistant",
             "finish_reason" => "stop"
           }
-        }]
+        } ]
       }
     end
 
@@ -97,7 +97,7 @@
       let(:stream_proc) { proc { |chunk| } }
 
       before do
-        allow(mock_prompt).to receive(:options).and_return({stream: true})
+        allow(mock_prompt).to receive(:options).and_return({ stream: true })
       end
 
       it "includes stream parameter when streaming is enabled" do
@@ -141,9 +141,9 @@
     let(:provider) { described_class.new(config) }
     let(:embedding_response) do
       {
-        "data" => [{
-          "embedding" => [0.1, 0.2, 0.3]
-        }]
+        "data" => [ {
+          "embedding" => [ 0.1, 0.2, 0.3 ]
+        } ]
       }
     end
 
@@ -163,7 +163,7 @@
     it "wraps response in Response object with embedding data" do
       response = provider.embed(mock_prompt)
       expect(response).to be_a(ActiveAgent::GenerationProvider::Response)
-      expect(response.message.content).to eq([0.1, 0.2, 0.3])
+      expect(response.message.content).to eq([ 0.1, 0.2, 0.3 ])
     end
 
     it "handles errors appropriately" do
@@ -204,9 +204,9 @@
     let(:provider) { described_class.new(config) }
     let(:embedding_data) do
       {
-        "data" => [{
-          "embedding" => [0.1, 0.2, 0.3]
-        }]
+        "data" => [ {
+          "embedding" => [ 0.1, 0.2, 0.3 ]
+        } ]
       }
     end
 
@@ -217,7 +217,7 @@
     it "creates response with embedding data" do
       response = provider.embeddings_response(embedding_data)
       expect(response).to be_a(ActiveAgent::GenerationProvider::Response)
-      expect(response.message.content).to eq([0.1, 0.2, 0.3])
+      expect(response.message.content).to eq([ 0.1, 0.2, 0.3 ])
       expect(response.message.role).to eq("assistant")
     end
   end
diff --git a/test/dummy/config/environments/development.rb b/test/dummy/config/environments/development.rb
@@ -20,7 +20,7 @@
   if Rails.root.join("tmp/caching-dev.txt").exist?
     config.action_controller.perform_caching = true
     config.action_controller.enable_fragment_cache_logging = true
-    config.public_file_server.headers = {"cache-control" => "public, max-age=#{2.days.to_i}"}
+    config.public_file_server.headers = { "cache-control" => "public, max-age=#{2.days.to_i}" }
   else
     config.action_controller.perform_caching = false
   end
@@ -38,7 +38,7 @@
   config.action_mailer.perform_caching = false
 
   # Set localhost to be used by links generated in mailer templates.
-  config.action_mailer.default_url_options = {host: "localhost", port: 3000}
+  config.action_mailer.default_url_options = { host: "localhost", port: 3000 }
 
   # Print deprecation notices to the Rails logger.
   config.active_support.deprecation = :log
diff --git a/test/dummy/config/environments/production.rb b/test/dummy/config/environments/production.rb
@@ -16,7 +16,7 @@
   config.action_controller.perform_caching = true
 
   # Cache assets for far-future expiry since they are all digest stamped.
-  config.public_file_server.headers = {"cache-control" => "public, max-age=#{1.year.to_i}"}
+  config.public_file_server.headers = { "cache-control" => "public, max-age=#{1.year.to_i}" }
 
   # Enable serving of images, stylesheets, and JavaScripts from an asset server.
   # config.asset_host = "http://assets.example.com"
@@ -34,7 +34,7 @@
   # config.ssl_options = { redirect: { exclude: ->(request) { request.path == "/up" } } }
 
   # Log to STDOUT with the current request id as a default log tag.
-  config.log_tags = [:request_id]
+  config.log_tags = [ :request_id ]
   config.logger = ActiveSupport::TaggedLogging.logger(STDOUT)
 
   # Change to "debug" to log everything (including potentially personally-identifiable information!)
@@ -57,7 +57,7 @@
   # config.action_mailer.raise_delivery_errors = false
 
   # Set host to be used by links generated in mailer templates.
-  config.action_mailer.default_url_options = {host: "example.com"}
+  config.action_mailer.default_url_options = { host: "example.com" }
 
   # Specify outgoing SMTP server. Remember to add smtp/* credentials via rails credentials:edit.
   # config.action_mailer.smtp_settings = {
@@ -76,7 +76,7 @@
   config.active_record.dump_schema_after_migration = false
 
   # Only use :id for inspections in production.
-  config.active_record.attributes_for_inspect = [:id]
+  config.active_record.attributes_for_inspect = [ :id ]
 
   # Enable DNS rebinding protection and other `Host` header attacks.
   # config.hosts = [
diff --git a/test/dummy/config/environments/test.rb b/test/dummy/config/environments/test.rb
diff --git a/test/test_helper.rb b/test/test_helper.rb
