Skip to content

New factor should not created with deleted factor #133

Description

@lwin-kyaw

Steps to reproduce -

  • create mpc-corekit instance and login (instance1)
  • enable MFA on the instance1 and you should be able to get backup factor which will be used to login another session
  • create another corekit instance (instance2) and login with backup factor you have from above step
  • login should be successful with instance2
  • from instance1 delete the backup factor, which is used to login for instance2
  • verify the backup factor has been successfully deleted, as well as it's related metadata (commitChanges when using manualSync:true)
  • from instance2, try to create new factor with the deleted backup factor

Expected Result

From instance2, new factor should not be able to created, should throw factor not present error, since the active factor key of instance2 has been deleted from instance1

Actual Result

With deleted backup key, new factor can be created locally in instance2. MPC-Corekit throws an error only when sync with metadata service.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions