Describe the bug
In the example data frame for Data_Nutrient_UT if we were to harmonize synonyms and try to find an alias between an ATTAINS.ParameterName for UTAH from ATTAINS with TOTAL NITROGEN, MIXED FORMS, one cannot be found from prior ATTAINS assessments (the crosswalk may not return all parameters required by
an organization's assessment methodology if some parameters have never
been listed as a cause in ATTAINS), but 'total nitrogen' does exist as a CST.PollutantName alias from UTAH. Ideally this should be returned with NA for ATTAINS.ParameterName, TOTAL NITROGEN, MIXED FORMS for the TADA.CharacteristicName and 'total nitrogen' for the CST.PollutantName with the magnitude values retrieved from the CST for UTAH.
To Reproduce
Data_Nutrients_UT2 <- TADA_RunKeyFlagFunctions(Data_Nutrients_UT)
Data_Nutrients_UT_Harmonized <- TADA_HarmonizeSynonyms(Data_Nutrients_UT2)
UTAH_Criteria <- TADA_DefineCriteriaMethodology(Data_Nutrients_UT_Harmonized, org_id = "UTAHDWQ", auto_assign = TRUE, displayUniqueId = TRUE)
UTAH_with_criteria <- TADA_Analysis_Join_WQP_Criteria(Data_Nutrients_UT_Harmonized, UTAH_Criteria)
Expected behavior
Ideally this should be returned with NA for ATTAINS.ParameterName, TOTAL NITROGEN, MIXED FORMS for the TADA.CharacteristicName and 'total nitrogen' for the CST.PollutantName with the magnitude values retrieved from the CST for UTAH.
Screenshots
Describe the bug
In the example data frame for Data_Nutrient_UT if we were to harmonize synonyms and try to find an alias between an ATTAINS.ParameterName for UTAH from ATTAINS with TOTAL NITROGEN, MIXED FORMS, one cannot be found from prior ATTAINS assessments (the crosswalk may not return all parameters required by
an organization's assessment methodology if some parameters have never
been listed as a cause in ATTAINS), but 'total nitrogen' does exist as a CST.PollutantName alias from UTAH. Ideally this should be returned with NA for ATTAINS.ParameterName, TOTAL NITROGEN, MIXED FORMS for the TADA.CharacteristicName and 'total nitrogen' for the CST.PollutantName with the magnitude values retrieved from the CST for UTAH.
To Reproduce
Data_Nutrients_UT2 <- TADA_RunKeyFlagFunctions(Data_Nutrients_UT)Data_Nutrients_UT_Harmonized <- TADA_HarmonizeSynonyms(Data_Nutrients_UT2)UTAH_Criteria <- TADA_DefineCriteriaMethodology(Data_Nutrients_UT_Harmonized, org_id = "UTAHDWQ", auto_assign = TRUE, displayUniqueId = TRUE)UTAH_with_criteria <- TADA_Analysis_Join_WQP_Criteria(Data_Nutrients_UT_Harmonized, UTAH_Criteria)Expected behavior
Ideally this should be returned with NA for ATTAINS.ParameterName, TOTAL NITROGEN, MIXED FORMS for the TADA.CharacteristicName and 'total nitrogen' for the CST.PollutantName with the magnitude values retrieved from the CST for UTAH.
Screenshots