notebook render support

[prclin]

does this project support render notebook?
when i open notebook, there is a exception in the console;

Uncaught (in promise) Error: Missing proxy instance MainThreadNotebookDocumentsShape
    at RPCProtocol.assertRegistered (rpcProtocol.js:214:25)
    at ExtensionHostManager._createExtensionHostCustomers (extensionHostManager.js:228:27)
    at extensionHostManager.js:73:25
assertRegistered	@	rpcProtocol.js:214
_createExtensionHostCustomers	@	extensionHostManager.js:228
(anonymous)	@	extensionHostManager.js:73
Promise.then		
ExtensionHostManager	@	extensionHostManager.js:66
_createInstance	@	instantiationService.js:135
createInstance	@	instantiationService.js:105
_doCreateExtensionHostManager	@	abstractExtensionService.js:808
_createExtensionHostManager	@	abstractExtensionService.js:779
_startExtensionHostsIfNecessary	@	abstractExtensionService.js:767
_initialize	@	abstractExtensionService.js:438
_initialize	@	extensionService.js:112
await in _initialize		
_initializeIfNeeded	@	abstractExtensionService.js:432
(anonymous)	@	extensionService.js:101
Promise.then		
ExtensionService	@	extensionService.js:100
ExtensionServiceOverride	@	index.js:212
_createInstance	@	instantiationService.js:135
_createServiceInstance	@	instantiationService.js:263
_createServiceInstanceWithOwner	@	instantiationService.js:247
_createAndCacheServiceInstance	@	instantiationService.js:231
_safeCreateAndCacheServiceInstance	@	instantiationService.js:172
_getOrCreateServiceInstance	@	instantiationService.js:160
get	@	instantiationService.js:79
(anonymous)	@	lifecycle.js:43
invokeFunction	@	instantiationService.js:86
startup	@	lifecycle.js:41
await in startup		
initialize	@	services.js:457
initAllServices	@	apiWrapper.ts:247
await in initAllServices		
start	@	apiWrapper.ts:346
await in start		
runLangiumGrammarDsl	@	main.ts:47
await in runLangiumGrammarDsl		
(anonymous)	@	langium_extended.html:21
IndexedDB		
(anonymous)	@	main.ts:27
openDB	@	main.ts:26
(anonymous)	@	langiumDslConfig.ts:24

looks like MainThreadNotebookDocumentsShape does not registered
and i already load notebook service override

import getNotebookServiceOverride from '@codingame/monaco-vscode-notebook-service-override';
import getExtensionsServiceOverride from '@codingame/monaco-vscode-extensions-service-override';

// and 

 serviceOverrides: {
            ...getExtensionsServiceOverride(),
            ...getNotebookServiceOverride(),
            ...getKeybindingsServiceOverride(),
        },

[CGNonofr]

Yes, it does. Your issue is probably that you have a dependency version mismatch

check https://github.com/CodinGame/monaco-vscode-api/wiki/Troubleshooting#duplicate-versions

[prclin]

thanks for your reply;
but i met a new problem;

Error: Missing viewType for 'file:///tmp/crawler_task_statistics.ipynb'
    at NotebookModelResolverServiceImpl.validateResourceViewType (notebookEditorModelResolverServiceImpl.js:199:21)
    at async NotebookModelResolverServiceImpl.resolve (notebookEditorModelResolverServiceImpl.js:237:27)
    at async MainThreadNotebookDocuments.$tryOpenNotebook (mainThreadNotebookDocuments.js:119:21)

and i found it was because there is no NotebookProviderInfo added;
so viewType validate faild in here https://github.com/microsoft/vscode/blob/main/src/vs/workbench/contrib/notebook/common/notebookEditorModelResolverServiceImpl.ts#L205
but i do not know how to add NotebookProviderInfo;

[CGNonofr]

You probably also need the notebook-renderers default extension, by installing and importing @codingame/monaco-vscode-notebook-renderers-default-extension

[prclin]

thanks.
but still the same problem,NotebookProviderInfo didn`t load;

import {MonacoVscodeApiWrapper} from 'monaco-languageclient/vscodeApiWrapper';
import * as vscode from 'vscode';
import type {ExampleAppConfig} from '../../common/client/utils.js';
import {openDb, setupLangiumClientExtended} from './config/langiumDslConfig.js';
import '@codingame/monaco-vscode-theme-defaults-default-extension';
import '@codingame/monaco-vscode-notebook-renderers-default-extension';

but i am editing at the monaco-languageclient repo examples, may be in a new project process it will succeed. and i found that https://monaco-vscode-api.netlify.app/ this app can render notebook properly, does it has a github repo.

[CGNonofr]

No other errors in the console? are you sure you didn't mismatch your dependencies again by installing @codingame/monaco-vscode-notebook-renderers-default-extension?

but i am editing at the monaco-languageclient repo examples, may be in a new project process it will succeed. and i found that https://monaco-vscode-api.netlify.app/ this app can render notebook properly, does it has a github repo.

https://monaco-vscode-api.netlify.app/ is the demo project of https://github.com/CodinGame/monaco-vscode-api, which monaco-languageclient relies on, and this is where all the @codingame/XXX packages come from

[prclin]

no, version is correct.

and error in console is same:

Error: Missing viewType for 'file:///tmp/crawler_task_statistics.ipynb'
    at NotebookModelResolverServiceImpl.validateResourceViewType (notebookEditorModelResolverServiceImpl.js:199:21)
    at async NotebookModelResolverServiceImpl.resolve (notebookEditorModelResolverServiceImpl.js:237:27)
    at async MainThreadNotebookDocuments.$tryOpenNotebook (mainThreadNotebookDocuments.js:119:21)
overrideMethod	@	hook.js:608
runLangiumGrammarDsl	@	main.ts:39
await in runLangiumGrammarDsl		
(anonymous)	@	langium_extended.html:22
IndexedDB		
(anonymous)	@	langiumDslConfig.ts:26
openDb	@	langiumDslConfig.ts:25
(anonymous)	@	main.ts:13
IndexedDB		
(anonymous)	@	langiumDslConfig.ts:26
openDb	@	langiumDslConfig.ts:25
(anonymous)	@	langiumDslConfig.ts:40

is there any run with my open file method:

export const runLangiumGrammarDsl = async () => {
    try {
        const appConfig: ExampleAppConfig = await setupLangiumClientExtended();

        // perform global init
        const apiWrapper = new MonacoVscodeApiWrapper(appConfig.vscodeApiConfig);
        await apiWrapper.start();

        // init language client
        // const lcWrapper = new LanguageClientWrapper(appConfig.languageClientConfig);
        // await lcWrapper.start();

        const notebookDocument = await vscode.workspace.openNotebookDocument(vscode.Uri.file('/tmp/crawler_task_statistics.ipynb'));
        await vscode.window.showNotebookDocument(notebookDocument);
    } catch (e) {
        console.error(e);
    }
};

[CGNonofr]

You probably need the ipynb extension also :) => @codingame/monaco-vscode-ipynb-default-extension

[prclin]

thanks for your answer; it works;
but i am curious about what the extensions and services i need install when i want specific features, does it have a map or document.

[CGNonofr]

Not really. All those default vscode extensions are installed by default in any VSCode setup.

So if you don't want to worry about it, you can just install all the default VSCode extensions by using @codingame/monaco-vscode-all-default-extensions

[prclin]

thanks for your answer, really appreciate.