TurboNyma: Layers issue when loading a save state

[ReyVGM]

Using TurboNyma, when loading a save state after disabling graphic layers, the layers revert back to normal in-game but the layer options stay in the "false" position. The correct behavior should be for the layers to stay visually disabled until I manually turn them back on.

Repro

Make a save state
Disable any layers
Load the save state

Host env.
BizHawk-2.11.1-win-x64

I actually reported this exact same thing for the Genesis core some years ago and it was fixed.

Is this something that needs to be fixed on a per-core basis then?

[Morilli]

Looking at the fix for the linked issue, yes I believe this will be an issue with many more cores that needs to be resolved in the same way for each of them. Settings are usually only set when they are changed and the core is savestating that modified state, so when you're loading a savestate then the core's version of all settings are being loaded unless they are explicitly re-set on state load.

This doesn't affect sync settings (because those require a core reboot) or settings that are handled in bizhawk's frontend only, but everything that gets sent to the core needs to be re-applied on savestate load.

[ReyVGM]

Looking at the fix for the linked issue, yes I believe this will be an issue with many more cores that needs to be resolved in the same way for each of them. Settings are usually only set when they are changed and the core is savestating that modified state, so when you're loading a savestate then the core's version of all settings are being loaded unless they are explicitly re-set on state load.

This doesn't affect sync settings (because those require a core reboot) or settings that are handled in bizhawk's frontend only, but everything that gets sent to the core needs to be re-applied on savestate load.

Thanks.

Should I open a request for each core or a global request?

[YoshiRulz]

If you find any more, you can just mention them here.