Sync convolve and matmul convention (#13)

* sync SparseDiffEngine and adapt dense matmul bindings

Bump SparseDiffEngine submodule to origin/main (45f88d0), which pulls in
the new convolve atom plus dance858's cleanup of the dense matmul
constructor data-pointer convention.

new_left_matmul_dense / new_right_matmul_dense now require exactly one
of param_node / data to be non-NULL (constants: (NULL, data); parameters:
(capsule, NULL)) — the engine fprintf/exit(1)s otherwise. Update the
dense branches of make_left_matmul and make_right_matmul bindings to
match: drop the PARAM_FIXED wrapper we were building for the constant
case, and forward data=NULL when a real parameter capsule is supplied.
DNLP's helpers.py still hands in A.flatten() in both cases; the binding
absorbs the new convention so no DNLP-side change is needed.

Verified: SparseDiffEngine ctest (267/267), DNLP nlp_tests (217 passed,
77 skipped), DNLP test_convolution + test_atoms (119 passed).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* trim comments on dense matmul bindings

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: Transurgeon

SparseDiffEngine

@@ -119,7 +119,8 @@ static PyObject *py_make_left_matmul(PyObject *self, PyObject *args)
     }
     else if (strcmp(fmt, "dense") == 0)
     {
-        /* Parse: param_or_none, child, "dense", A_data_flat, m, n */
+        /* Engine requires (param_node, data) to be mutually exclusive;
+         * drop the caller's A_data when a parameter capsule is supplied. */
         PyObject *data_obj;
         int m, n;
         if (!PyArg_ParseTuple(args, "OOsOii", &param_obj, &child_capsule,
@@ -128,48 +129,34 @@ static PyObject *py_make_left_matmul(PyObject *self, PyObject *args)
             return NULL;
         }
 
-        PyArrayObject *data_array = (PyArrayObject *) PyArray_FROM_OTF(
-            data_obj, NPY_DOUBLE, NPY_ARRAY_IN_ARRAY);
-        if (!data_array)
-        {
-            return NULL;
-        }
-
-        double *A_data = (double *) PyArray_DATA(data_array);
-
-        expr *param_node = NULL;
+        expr *node;
         if (param_obj == Py_None)
         {
-            param_node = new_parameter(m * n, 1, PARAM_FIXED,
-                                       child->n_vars, A_data);
-            if (!param_node)
+            PyArrayObject *data_array = (PyArrayObject *) PyArray_FROM_OTF(
+                data_obj, NPY_DOUBLE, NPY_ARRAY_IN_ARRAY);
+            if (!data_array)
             {
-                Py_DECREF(data_array);
-                PyErr_SetString(PyExc_RuntimeError,
-                                "failed to create parameter node");
                 return NULL;
             }
+            double *A_data = (double *) PyArray_DATA(data_array);
+            node = new_left_matmul_dense(NULL, child, m, n, A_data);
+            Py_DECREF(data_array);
         }
         else
         {
-            param_node = (expr *) PyCapsule_GetPointer(param_obj,
-                                                       EXPR_CAPSULE_NAME);
+            expr *param_node = (expr *) PyCapsule_GetPointer(
+                param_obj, EXPR_CAPSULE_NAME);
             if (!param_node)
             {
-                Py_DECREF(data_array);
                 PyErr_SetString(PyExc_ValueError,
                                 "invalid parameter capsule");
                 return NULL;
             }
+            node = new_left_matmul_dense(param_node, child, m, n, NULL);
         }
 
-        expr *node =
-            new_left_matmul_dense(param_node, child, m, n, A_data);
-        Py_DECREF(data_array);
-
         if (!node)
         {
-            if (param_obj == Py_None) free_expr(param_node);
             PyErr_SetString(PyExc_RuntimeError,
                             "failed to create dense left_matmul node");
             return NULL;

sparsediffpy/_bindings/atoms/left_matmul.h

@@ -115,6 +115,8 @@ static PyObject *py_make_right_matmul(PyObject *self, PyObject *args)
     }
     else if (strcmp(fmt, "dense") == 0)
     {
+        /* Engine requires (param_node, data) to be mutually exclusive;
+         * drop the caller's A_data when a parameter capsule is supplied. */
         PyObject *data_obj;
         int m, n;
         if (!PyArg_ParseTuple(args, "OOsOii", &param_obj, &child_capsule,
@@ -123,48 +125,34 @@ static PyObject *py_make_right_matmul(PyObject *self, PyObject *args)
             return NULL;
         }
 
-        PyArrayObject *data_array = (PyArrayObject *) PyArray_FROM_OTF(
-            data_obj, NPY_DOUBLE, NPY_ARRAY_IN_ARRAY);
-        if (!data_array)
-        {
-            return NULL;
-        }
-
-        double *A_data = (double *) PyArray_DATA(data_array);
-
-        expr *param_node = NULL;
+        expr *node;
         if (param_obj == Py_None)
         {
-            param_node = new_parameter(m * n, 1, PARAM_FIXED,
-                                       child->n_vars, A_data);
-            if (!param_node)
+            PyArrayObject *data_array = (PyArrayObject *) PyArray_FROM_OTF(
+                data_obj, NPY_DOUBLE, NPY_ARRAY_IN_ARRAY);
+            if (!data_array)
             {
-                Py_DECREF(data_array);
-                PyErr_SetString(PyExc_RuntimeError,
-                                "failed to create parameter node");
                 return NULL;
             }
+            double *A_data = (double *) PyArray_DATA(data_array);
+            node = new_right_matmul_dense(NULL, child, m, n, A_data);
+            Py_DECREF(data_array);
         }
         else
         {
-            param_node = (expr *) PyCapsule_GetPointer(param_obj,
-                                                       EXPR_CAPSULE_NAME);
+            expr *param_node = (expr *) PyCapsule_GetPointer(
+                param_obj, EXPR_CAPSULE_NAME);
             if (!param_node)
             {
-                Py_DECREF(data_array);
                 PyErr_SetString(PyExc_ValueError,
                                 "invalid parameter capsule");
                 return NULL;
             }
+            node = new_right_matmul_dense(param_node, child, m, n, NULL);
         }
 
-        expr *node =
-            new_right_matmul_dense(param_node, child, m, n, A_data);
-        Py_DECREF(data_array);
-
         if (!node)
         {
-            if (param_obj == Py_None) free_expr(param_node);
             PyErr_SetString(PyExc_RuntimeError,
                             "failed to create dense right_matmul node");
             return NULL;