Skip to content

Commit 029b410

Browse files
committed
test for null vals and conflict cols
1 parent aa880c1 commit 029b410

1 file changed

Lines changed: 9 additions & 1 deletion

File tree

tests/test_fdr.py

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,13 +141,21 @@ def test_full_fdr():
141141
pep_fdr=0.5,
142142
prot_fdr=0.3,
143143
link_fdr=0.05,
144-
ppi_fdr=0.05
144+
ppi_fdr=0.05,
145+
filter_back=False
145146
)
146147
assert 'csm' in x
147148
assert 'pep' in x
148149
assert 'link' in x
149150
assert 'ppi' in x
150151

152+
# Check for _right columns and nulls in results
153+
for name, df in x.items():
154+
right_cols = [c for c in df.columns if c.endswith('_right')]
155+
assert not right_cols, f"Found _right columns in {name}: {right_cols}"
156+
if 'score' in df.columns:
157+
assert df['score'].null_count() == 0, f"Found null scores in {name} - check for join issues"
158+
151159

152160
def test_full_fdr_consistency():
153161
from xifdr.fdr import pep_cols, link_cols, ppi_cols

0 commit comments

Comments
 (0)