Skip to content

Commit 9ba5d99

Browse files
committed
Address some comments from copilot
1 parent 2ac3c4f commit 9ba5d99

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

mlir/lib/Conversion/MIGraphXToLinalg/MIGraphXToLinalg.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -519,7 +519,8 @@ LogicalResult
519519
TransposeConverter::matchAndRewrite(migraphx::TransposeOp op, OpAdaptor adaptor,
520520
ConversionPatternRewriter &rewriter) const {
521521
Location loc = op.getLoc();
522-
RankedTensorType outputType = op.getType().asTensor();
522+
RankedTensorType outputType = dyn_cast<RankedTensorType>(getTypeConverter()->convertType(op.getType()));
523+
assert(outputType && "MIXRShapedToTensorConverter TypeConverter should convert this into a RankedTensorType");
523524
auto init = tensor::EmptyOp::create(rewriter, loc, outputType, {});
524525
SmallVector<int64_t, 4> permutation;
525526
llvm::transform(op.getPermutation().getValue(), std::back_inserter(permutation), [](Attribute attr){

mlir/lib/Dialect/Rock/Transforms/ViewToTransform.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,8 @@ struct RockViewToTransform
188188

189189
target.addLegalDialect<rock::RockDialect, tosa::TosaDialect>();
190190
target.addIllegalOp<tensor::ExpandShapeOp, tensor::CollapseShapeOp,
191-
tensor::ExtractSliceOp, tosa::TransposeOp>();
191+
tensor::ExtractSliceOp, tosa::TransposeOp,
192+
linalg::TransposeOp>();
192193

193194
patterns.add<TransposeRewritePattern<tosa::TransposeOp>,
194195
TransposeRewritePattern<linalg::TransposeOp>,

0 commit comments

Comments
 (0)