Skip to content

Commit 92f6385

Browse files
committed
Fix broken tests, cleanup
1 parent af09ac5 commit 92f6385

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

src/main/java/net/ripe/rpki/ta/config/Config.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,16 @@
11
package net.ripe.rpki.ta.config;
22

33
import com.google.common.base.Preconditions;
4-
import lombok.EqualsAndHashCode;
5-
import lombok.Getter;
6-
import lombok.Setter;
7-
import lombok.ToString;
4+
import lombok.*;
85
import org.joda.time.Period;
96

107
import javax.security.auth.x500.X500Principal;
118
import java.net.URI;
129

13-
1410
@Getter
1511
@EqualsAndHashCode
1612
@ToString
13+
@NoArgsConstructor
1714
public class Config {
1815
@Setter
1916
private X500Principal trustAnchorName;
@@ -45,6 +42,7 @@ public class Config {
4542
private Period minimumValidityPeriod;
4643

4744
private final String minimalValidityErrorMessage = "Minimum validity period cannot be null";
45+
4846
public Period getMinimumValidityPeriod() {
4947
return Preconditions.checkNotNull(minimumValidityPeriod, minimalValidityErrorMessage);
5048
}

src/test/java/net/ripe/rpki/ta/integration/MainIntegrationTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -436,11 +436,11 @@ public void test_process_request_make_sure_ta_certificate_reissued_if_it_is_too_
436436
"--response=" + response.getAbsolutePath() +
437437
" --force-new-ta-certificate --env=test").exitCode).isZero();
438438

439-
final TAState taStateAfterRrdpChange = reloadTaState();
439+
final TAState taStateAfterReissue = reloadTaState();
440440

441-
assertThat(taStateAfterRrdpChange).isNotNull();
441+
assertThat(taStateAfterReissue).isNotNull();
442442

443-
final X509ResourceCertificate taCertAfter = getTaCertificate(taStateAfterRrdpChange);
443+
final X509ResourceCertificate taCertAfter = getTaCertificate(taStateAfterReissue);
444444
assertThat(taCertBefore.getSerialNumber()).isNotEqualTo(taCertAfter.getSerialNumber());
445445

446446
// Check that TA certificate was re-issued
@@ -469,7 +469,7 @@ public void test_process_request_do_not_reissue_ta_certificate_without_force_opt
469469
" --env=test");
470470
assertEquals(EXIT_ERROR_2, run.exitCode);
471471
assertThat(run.stderr).contains("The following problem occurred: " +
472-
"TA certificate has to be re-issued: Different notification.xml URL, " +
472+
"The TA certificate has to be re-issued: Different notification.xml URL, " +
473473
"request has 'https://new-url.ripe.net/notification.xml', config has 'https://localhost:7788/notification.xml', " +
474474
"bailing out. Provide force-new-ta-certificate option to force TA certificate re-issue.");
475475
}

0 commit comments

Comments
 (0)