Skip to content

Commit f38bfd5

Browse files
rustyconoverclaude
andcommitted
ci: bump VGI_REF to HEAD after upstream rename batch
The integration suite pins the .test files at VGI_REF but installs the vgi extension live from community (unpinned). Upstream advanced past the old pin (4444d66) with extension-side renames the community build already shipped, so the pinned tests called names the new extension no longer has: vgi_join_keys_limit setting -> vgi_join_keys_threshold (0504226) vgi_worker_subprocess_pool() -> vgi_worker_pool() (8381b69) vgi_worker_pool_flush() scalar -> table function (f9e78f5) All are SQL surface, not worker code — no Java change needed. Bumping VGI_REF to HEAD (3e4b68d) picks up the updated tests. HEAD also adds connection_string.test (bare connection-string / ?location= ATTACH discovery), which reuses the existing InvokeCatalogs RPC, so the worker already satisfies it. Verified the full source-built suite (185/185) and re-ran the four renamed tests + connection_string.test against the actual CI path (INSTALL vgi FROM community + local haybarn-unittest + the Java worker) — all green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 6e6e5c1 commit f38bfd5

2 files changed

Lines changed: 27 additions & 1 deletion

File tree

.github/workflows/integration.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ env:
2828
# The Query-farm/vgi commit whose test/sql/integration suite we run. Pinned
2929
# for reproducibility; bump deliberately and re-validate against the then-current
3030
# community extension (see ci/README.md).
31-
VGI_REF: 4444d669c700d9efd70e5f97db4d2c4c886f509f
31+
VGI_REF: 3e4b68da081cae8215018221092e2408f100766a
3232
# The Haybarn release providing the prebuilt haybarn-unittest binary. Must be
3333
# ABI-compatible with the community-published vgi extension (both v1.5.3).
3434
HAYBARN_RELEASE: haybarn-v1.5.3-rc7

CLAUDE.md

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -287,6 +287,32 @@ older interfaces** (`TableFunction`, `TableInOutFunction`, etc.) — the
287287
`ScalarFn` style hasn't been extended to those because their richer
288288
lifecycle methods + per-execution state don't translate one-for-one.
289289

290+
## State of play (as of 2026-06-15)
291+
292+
**2026-06-15 — re-greened CI after an upstream rename batch + bumped `VGI_REF`
293+
to HEAD (`3e4b68d`).** CI went red because the suite pins the `.test` files at
294+
`VGI_REF` but installs the `vgi` extension **live from community** (unpinned).
295+
Upstream advanced past the old pin (`4444d66`) with a cluster of rename commits
296+
that the community extension had already shipped, so the old tests called names
297+
the new extension no longer had:
298+
- `vgi_join_keys_limit` setting → `vgi_join_keys_threshold` (`0504226`)
299+
- `vgi_worker_subprocess_pool()``vgi_worker_pool()` (`8381b69`)
300+
- `vgi_worker_pool_flush()` scalar → **table** function (`f9e78f5`)
301+
302+
All three are **extension-side SQL surface, not worker code** — no Java change
303+
was needed; the failures were stale pinned tests. Fix = bump `VGI_REF` to HEAD
304+
(`integration.yml`). HEAD also adds **`connection_string.test`** (bare
305+
connection-string / `?location=` ATTACH discovery, `e19e189`/`15fe529`); that
306+
feature **reuses the existing InvokeCatalogs RPC**, so the worker already
307+
satisfies it with no port. Verified the full source-built suite (185/185) *and*
308+
re-ran the four renamed tests + `connection_string.test` against the **actual CI
309+
path**`INSTALL vgi FROM community` driving the local `haybarn-unittest` (the
310+
homebrew `/opt/homebrew/bin/haybarn-unittest`) + the Java worker — all green,
311+
proving the community build already carries the connection-string feature (the
312+
risk that gated bumping straight to HEAD). `HAYBARN_RELEASE` left at `rc7`
313+
(upstream's `rc10` bump is a Windows-MSVC build fix, not a runtime-ABI change;
314+
rc7 still passes against the current community extension).
315+
290316
## State of play (as of 2026-06-12)
291317

292318
**2026-06-12 — HTTP table-function streaming sweep (state serialization).** The

0 commit comments

Comments
 (0)