Improve modpack download resiliency, onboarding

Track and surface partial modpack download failures across core and frontend. Adds a PartialModpackInstall error and counts failed/attempted downloads in the mrpack flow, returning an error if some files failed. Frontend download pipeline now runs parallel downloads that return per-item results, reports/logs failures, and exposes retry/continue UI in onboarding.

Backend robustness improvements: deduplicate concurrent package inserts by reusing existing row on unique-hash constraint, detect hard-link collisions and verify hashes before skipping or erroring, and return meaningful errors when partial installs occur.

Other changes: propagate richer error context when stamping migrated cluster created_at, invalidate relevant queries after migration, make settings writes awaitable and update the query cache optimistically, add queryClient usage in version-migration hook, and various type/bindings updates to reflect the new PartialModpackInstall error. These changes improve reliability and UX during batch package installs and onboarding downloads.

Author: Wyvest

apps/oneclient/desktop/src/api/commands.rs

@@ -1,6 +1,7 @@
 use std::collections::HashMap;
 use std::path::{Path, PathBuf};
 
+use anyhow::Context;
 use onelauncher_core::api;
 use onelauncher_core::api::cluster::dao::ClusterId;
 use onelauncher_core::api::packages::modpack::data::{ModpackArchive, ModpackFileKind};
@@ -361,7 +362,13 @@ impl OneClientApi for OneClientApiImpl {
 
 		// Stamp the target cluster's created_at with the actual migration time so the
 		// home page can correctly identify it as a newly-migrated cluster.
-		onelauncher_core::api::cluster::dao::touch_cluster_created_at(target_id).await?;
+		onelauncher_core::api::cluster::dao::touch_cluster_created_at(target_id)
+			.await
+			.with_context(|| {
+				format!(
+					"failed to stamp migrated cluster created_at for target cluster {target_id}"
+				)
+			})?;
 
 		Ok(CopyClusterResult {
 			fallback_files: fallback_files.into_iter().collect(),

apps/oneclient/frontend/src/bindings.gen.ts

@@ -192,7 +192,7 @@ export type PackageDonationPlatform = "patreon" | "buymeacoffee" | "paypal" | "g
 
 export type PackageDonationUrl = { id: PackageDonationPlatform; url: string }
 
-export type PackageError = { type: "NoPrimaryFile"; data: string } | { type: "IsNotModPack"; data: string } | { type: "Incompatible"; data: IncompatiblePackageType } | { type: "MissingApiKey"; data: string } | { type: "UnsupportedBodyType"; data: string } | { type: "UnsupportedAuthorType"; data: string } | { type: "UnsupportedModpackFormat"; data: string }
+export type PackageError = { type: "NoPrimaryFile"; data: string } | { type: "IsNotModPack"; data: string } | { type: "PartialModpackInstall"; data: string } | { type: "Incompatible"; data: IncompatiblePackageType } | { type: "MissingApiKey"; data: string } | { type: "UnsupportedBodyType"; data: string } | { type: "UnsupportedAuthorType"; data: string } | { type: "UnsupportedModpackFormat"; data: string }
 
 export type PackageGallery = { url: string; thumbnail_url: string; title: string | null; description: string | null; featured: boolean | null }
 
@@ -325,11 +325,8 @@ export type VersionType =
  */
 "old_beta"
 
-const ARGS_MAP = { 'oneclient':'{"refreshArt":["path"],"getVersions":[],"getBundlesFor":["cluster_id"],"updateBundlePackages":["cluster_id"],"copyClusterContent":["source_id","target_id"],"isBundleSyncing":[],"downloadPackageFromBundle":["package","cluster_id","bundle_name","skip_compatibility"],"checkForUpdate":[],"installUpdate":[],"getClustersGroupedByMajor":[],"cacheArt":["path"],"extractBundleOverrides":["bundle_path","cluster_id"]}', 'core':'{"searchPackages":["provider","query"],"updateClusterById":["id","request"],"fetchMinecraftProfile":["uuid"],"getLogs":["id"],"launchCluster":["id","uuid","search_for_java"],"getClusters":[],"getProcessLogTail":["id","max_lines"],"killProcess":["pid"],"getRunningProcesses":[],"setClusterStage":["id","stage"],"getGlobalProfile":[],"getLoadersForVersion":["mc_version"],"getGameVersions":[],"getMultiplePackages":["provider","slugs"],"createSettingsProfile":["name"],"downloadPackage":["provider","package_id","version_id","cluster_id","skip_compatibility"],"getPackage":["provider","slug"],"syncCluster":["cluster_id"],"getLinkedPackages":["cluster_id"],"open":["input"],"readSettings":[],"getPackageVersions":["provider","slug","mc_version","loader","offset","limit"],"refreshAccounts":[],"getClusterById":["id"],"removeUser":["uuid"],"getDefaultUser":["fallback"],"removeCluster":["id"],"createCluster":["options"],"getWorlds":["id"],"getLogByName":["id","name"],"updateClusterProfile":["name","profile"],"setDefaultUser":["uuid"],"getUsers":[],"getPackageBody":["provider","body"],"removePackage":["cluster_id","package_hash"],"fetchLoggedInProfile":["access_token"],"setDiscordRPCMessage":["message"],"getUsersFromAuthor":["provider","author"],"isClusterRunning":["cluster_id"],"refreshAccount":["uuid"],"writeSettings":["setting"],"installModpack":["modpack","cluster_id"],"getProfileOrDefault":["name"],"removeCape":["access_token"],"getRunningProcessesByClusterId":["cluster_id"],"togglePackage":["cluster_id","package_hash"],"getScreenshots":["id"],"uploadSkinBytes":["access_token","skin_data","image_format","skin_variant"],"downloadExternalPackage":["package","cluster_id","force","skip_compatibility"],"getUser":["uuid"],"openMsaLogin":[],"changeSkin":["access_token","skin_url","skin_variant"],"convertUsernameUUID":["username_uuid"],"changeCape":["access_token","cape_uuid"]}', 'folders':'{"fromCluster":["folder_name"],"openCluster":["folder_name"]}', 'events':'{"message":["event"],"process":["event"],"ingress":["event"]}', 'debug':'{"getType":[],"getArch":[],"getFullDebugInfoParsedString":[],"getGitCommitHash":[],"getFamily":[],"getFullDebugInfo":[],"openDevTools":[],"getOsVersion":[],"getPackageVersion":[],"getPlatform":[],"getFullDebugInfoParsed":[],"isInDev":[],"getBuildTimestamp":[],"getLocale":[],"hasDevSettings":[],"getOsDistro":[]}' }
-export type Router = { 'events': { ingress: (event: IngressPayload) => Promise<void>, 
-message: (event: MessagePayload) => Promise<void>, 
-process: (event: ProcessPayload) => Promise<void> },
-'core': { getClusters: () => Promise<ClusterModel[]>, 
+const ARGS_MAP = { 'folders':'{"openCluster":["folder_name"],"fromCluster":["folder_name"]}', 'oneclient':'{"cacheArt":["path"],"refreshArt":["path"],"copyClusterContent":["source_id","target_id"],"checkForUpdate":[],"getBundlesFor":["cluster_id"],"getClustersGroupedByMajor":[],"installUpdate":[],"downloadPackageFromBundle":["package","cluster_id","bundle_name","skip_compatibility"],"updateBundlePackages":["cluster_id"],"extractBundleOverrides":["bundle_path","cluster_id"],"getVersions":[],"isBundleSyncing":[]}', 'events':'{"ingress":["event"],"message":["event"],"process":["event"]}', 'debug':'{"isInDev":[],"getFamily":[],"getLocale":[],"getArch":[],"getBuildTimestamp":[],"hasDevSettings":[],"getFullDebugInfoParsed":[],"getFullDebugInfo":[],"getFullDebugInfoParsedString":[],"getType":[],"getGitCommitHash":[],"openDevTools":[],"getPackageVersion":[],"getPlatform":[],"getOsVersion":[],"getOsDistro":[]}', 'core':'{"changeCape":["access_token","cape_uuid"],"getPackage":["provider","slug"],"installModpack":["modpack","cluster_id"],"convertUsernameUUID":["username_uuid"],"getLoadersForVersion":["mc_version"],"removeCape":["access_token"],"openMsaLogin":[],"getClusterById":["id"],"removeUser":["uuid"],"getUser":["uuid"],"refreshAccount":["uuid"],"readSettings":[],"getPackageBody":["provider","body"],"changeSkin":["access_token","skin_url","skin_variant"],"getScreenshots":["id"],"refreshAccounts":[],"launchCluster":["id","uuid","search_for_java"],"getGameVersions":[],"removeCluster":["id"],"getUsers":[],"getRunningProcessesByClusterId":["cluster_id"],"setClusterStage":["id","stage"],"getLinkedPackages":["cluster_id"],"getPackageVersions":["provider","slug","mc_version","loader","offset","limit"],"open":["input"],"createCluster":["options"],"searchPackages":["provider","query"],"setDiscordRPCMessage":["message"],"createSettingsProfile":["name"],"setDefaultUser":["uuid"],"downloadExternalPackage":["package","cluster_id","force","skip_compatibility"],"getRunningProcesses":[],"getProcessLogTail":["id","max_lines"],"getClusters":[],"getLogByName":["id","name"],"getProfileOrDefault":["name"],"killProcess":["pid"],"updateClusterById":["id","request"],"getGlobalProfile":[],"isClusterRunning":["cluster_id"],"downloadPackage":["provider","package_id","version_id","cluster_id","skip_compatibility"],"getUsersFromAuthor":["provider","author"],"updateClusterProfile":["name","profile"],"getLogs":["id"],"writeSettings":["setting"],"getMultiplePackages":["provider","slugs"],"syncCluster":["cluster_id"],"togglePackage":["cluster_id","package_hash"],"fetchMinecraftProfile":["uuid"],"fetchLoggedInProfile":["access_token"],"getWorlds":["id"],"getDefaultUser":["fallback"],"uploadSkinBytes":["access_token","skin_data","image_format","skin_variant"],"removePackage":["cluster_id","package_hash"]}' }
+export type Router = { 'core': { getClusters: () => Promise<ClusterModel[]>, 
 getClusterById: (id: number) => Promise<ClusterModel | null>, 
 removeCluster: (id: number) => Promise<null>, 
 createCluster: (options: CreateCluster) => Promise<ClusterModel>, 
@@ -383,6 +380,9 @@ removeCape: (accessToken: string) => Promise<MojangFullPlayerProfile>,
 convertUsernameUUID: (usernameUuid: string) => Promise<MowojangProfile>, 
 setDiscordRPCMessage: (message: string) => Promise<null>, 
 open: (input: string) => Promise<null> },
+'events': { ingress: (event: IngressPayload) => Promise<void>, 
+message: (event: MessagePayload) => Promise<void>, 
+process: (event: ProcessPayload) => Promise<void> },
 'folders': { fromCluster: (folderName: string) => Promise<string>, 
 openCluster: (folderName: string) => Promise<null> },
 'debug': { openDevTools: () => Promise<void>, 

apps/oneclient/frontend/src/components/DownloadMods.tsx

@@ -33,6 +33,19 @@ export interface ExternalModData extends BaseModData {
 export type ModData = ManagedModData | ExternalModData;
 export type ModDataArray = Array<ModData>;
 
+export type DownloadModsParallelResult =
+	| {
+		ok: true;
+		index: number;
+		mod: ModData;
+	}
+	| {
+		ok: false;
+		index: number;
+		mod: ModData;
+		error: unknown;
+	};
+
 export function isManagedMod(mod: ModData): mod is ManagedModData {
 	return mod.managed === true;
 }
@@ -137,15 +150,50 @@ export function buildModDataArray(modsPerCluster: Record<string, Array<ModWithBu
 	return modsList;
 }
 
-export function downloadModsParallel(items: ModDataArray, limit: number, fn: (mod: ModData, index: number) => Promise<void>) {
+export async function downloadModsParallel(
+	items: ModDataArray,
+	limit: number,
+	fn: (mod: ModData, index: number) => Promise<void>,
+): Promise<Array<DownloadModsParallelResult>> {
+	if (items.length === 0)
+		return [];
+
 	let index = 0;
-	const workers = Array.from({ length: limit }).fill(null).map(async () => {
+	const workerCount = Math.max(1, Math.min(limit, items.length));
+	const results: Array<DownloadModsParallelResult> = [];
+
+	const workers = Array.from({ length: workerCount }).fill(null).map(async () => {
 		while (index < items.length) {
-			const i = index++;
-			await fn(items[i], i);
+			const i = index;
+			index += 1;
+
+			if (i >= items.length)
+				return;
+
+			const mod = items[i];
+			try {
+				await fn(mod, i);
+				results.push({
+					ok: true,
+					index: i,
+					mod,
+				});
+			}
+			catch (error) {
+				results.push({
+					ok: false,
+					index: i,
+					mod,
+					error,
+				});
+			}
 		}
 	});
-	return Promise.all(workers);
+
+	await Promise.all(workers);
+
+	results.sort((left, right) => left.index - right.index);
+	return results;
 }
 
 function DownloadingMods({ mods, setOpen, nextPath }: { mods: ModDataArray; setOpen: React.Dispatch<React.SetStateAction<boolean>>; nextPath: string }) {
@@ -194,7 +242,7 @@ function DownloadingMods({ mods, setOpen, nextPath }: { mods: ModDataArray; setO
 
 	useEffect(() => {
 		const downloadAll = async () => {
-			await downloadModsParallel(mods, 10, async (mod) => {
+			const results = await downloadModsParallel(mods, 10, async (mod) => {
 				setModName(mod.name);
 				try {
 					await download.mutateAsync(mod);
@@ -203,9 +251,21 @@ function DownloadingMods({ mods, setOpen, nextPath }: { mods: ModDataArray; setO
 					setDownloadedMods(prev => prev + 1);
 				}
 			});
+
+			const failed = results.filter(result => !result.ok);
+			if (failed.length > 0)
+				console.error('[DownloadMods] Some mods failed to download:', {
+					failed: failed.length,
+					total: mods.length,
+					entries: failed.map(result => ({
+						index: result.index,
+						name: result.mod.name,
+						error: result.error,
+					})),
+				});
 		};
 
-		downloadAll();
+		void downloadAll();
 	// eslint-disable-next-line react-hooks/exhaustive-deps -- download is not stable, adding it would cause infinite loops
 	}, [mods]);
 

apps/oneclient/frontend/src/components/overlay/MigrationModal.tsx

@@ -7,6 +7,7 @@ import { useToast } from '@/utils/toast';
 import { getOnlineClusterForVersion } from '@/utils/versionMap';
 import { useCommand } from '@onelauncher/common';
 import { Dropdown } from '@onelauncher/common/components';
+import { useQueryClient } from '@tanstack/react-query';
 import { Announcement01Icon } from '@untitled-theme/icons-react';
 import { useEffect, useRef, useState } from 'react';
 
@@ -51,6 +52,7 @@ export function MigrationModal({
 	const [fallbackFiles, setFallbackFiles] = useState<Array<string>>([]);
 
 	const toast = useToast();
+	const queryClient = useQueryClient();
 
 	const { data: manifest } = useCommand(
 		['getVersions'],
@@ -87,6 +89,17 @@ export function MigrationModal({
 		setIsMigrating(true);
 		try {
 			const result = await bindings.oneclient.copyClusterContent(sourceId, effectiveTargetId);
+			await Promise.all([
+				queryClient.invalidateQueries({
+					queryKey: ['getClusters'],
+				}),
+				queryClient.invalidateQueries({
+					queryKey: ['getClusters', 'sortedByLastPlayed'],
+				}),
+				queryClient.invalidateQueries({
+					queryKey: ['getClustersGroupedByMajor'],
+				}),
+			]);
 			if (result.fallback_files.length > 0)
 				setFallbackFiles(result.fallback_files);
 			else

apps/oneclient/frontend/src/hooks/useSettings.ts

@@ -12,12 +12,12 @@ export function useSettings() {
 	}, [settings]);
 
 	const setSetting = useMemo(() => {
-		return function setSetting<TKey extends keyof Settings>(key: TKey, value: Settings[TKey]) {
-			bindings.core.writeSettings({
+		return async function setSetting<TKey extends keyof Settings>(key: TKey, value: Settings[TKey]) {
+			await bindings.core.writeSettings({
 				...settings.data,
 				[key]: value,
 			});
-			settings.refetch();
+			await settings.refetch();
 		};
 	}, [settings]);
 

apps/oneclient/frontend/src/hooks/useVersionMigration.ts

@@ -1,6 +1,7 @@
 import { bindings } from '@/main';
 import useMigrationStore from '@/stores/migrationStore';
 import { useCommandSuspense } from '@onelauncher/common';
+import { useQueryClient } from '@tanstack/react-query';
 import { useEffect } from 'react';
 
 const DEFAULT_SEEN_VERSIONS = ['1.21.1', '1.21.10', '1.21.11'] as const;
@@ -24,6 +25,7 @@ function areClustersEqual(
 }
 
 export function useVersionMigration() {
+	const queryClient = useQueryClient();
 	const { data: grouped } = useCommandSuspense(
 		['getClustersGroupedByMajor'],
 		bindings.oneclient.getClustersGroupedByMajor,
@@ -40,11 +42,7 @@ export function useVersionMigration() {
 	const openForDebug = useMigrationStore(state => state.openForDebug);
 
 	useEffect(() => {
-		type SettingsWithSeenVersions = typeof settingsData & {
-			seen_versions?: Array<string>;
-		};
-
-		const settings = settingsData as SettingsWithSeenVersions;
+		const settings = settingsData;
 		const storedSeenVersions = Array.isArray(settings.seen_versions) ? settings.seen_versions : [];
 		const seenVersions = [
 			...new Set([
@@ -68,10 +66,12 @@ export function useVersionMigration() {
 		if (!areClustersEqual(migrationState.allClusters, nextAllClusters))
 			setAllClusters(nextAllClusters);
 
-		if (
-			!areStringArraysEqual(migrationState.newVersions, unseenUnplayed)
-			|| !areClustersEqual(migrationState.sourceClusters, sources)
-		)
+		const migrationCandidatesChanged
+			= !areStringArraysEqual(migrationState.newVersions, unseenUnplayed)
+				|| !areClustersEqual(migrationState.sourceClusters, sources);
+
+		// Keep active modal data stable while it is open.
+		if (migrationCandidatesChanged && !migrationState.isOpen)
 			setMigrationCandidates(unseenUnplayed, sources);
 
 		if (unseenUnplayed.length > 0 && sources.length > 0 && !migrationState.isOpen)
@@ -82,12 +82,16 @@ export function useVersionMigration() {
 		const hasSeenVersionsChanged
 			= !areStringArraysEqual(nextSeenVersions, normalizedStoredSeenVersions);
 
-		if (hasSeenVersionsChanged)
-			void bindings.core.writeSettings({
+		if (hasSeenVersionsChanged) {
+			const nextSettings = {
 				...settings,
 				seen_versions: nextSeenVersions,
-			} as typeof settingsData);
-	}, [grouped, setAllClusters, setIsOpen, setMigrationCandidates, settingsData]);
+			} as typeof settingsData;
+
+			queryClient.setQueryData(['readSettings'], nextSettings);
+			void bindings.core.writeSettings(nextSettings);
+		}
+	}, [grouped, queryClient, setAllClusters, setIsOpen, setMigrationCandidates, settingsData]);
 
 	return { isOpen, isDebugPreview, setIsOpen, newVersions, sourceClusters, allClusters, openForDebug };
 }

apps/oneclient/frontend/src/routes/app/index.tsx

@@ -20,6 +20,28 @@ export const Route = createFileRoute('/app/')({
 	component: RouteComponent,
 });
 
+function getCreatedAtMs(createdAt: string): number | null {
+	const parsed = Date.parse(createdAt);
+	if (Number.isFinite(parsed))
+		return parsed;
+
+	// Normalize high-precision RFC3339 fractions for stricter engines.
+	const normalized = createdAt.replace(/\.(\d{3})\d+(?=(?:Z|[+-]\d{2}:\d{2})$)/, '.$1');
+	const normalizedParsed = Date.parse(normalized);
+	return Number.isFinite(normalizedParsed) ? normalizedParsed : null;
+}
+
+function getBoostedCreatedAtMs(cluster: ClusterModel, now: number, boostWindowMs: number): number | null {
+	if (cluster.last_played !== null)
+		return null;
+
+	const createdAtMs = getCreatedAtMs(cluster.created_at);
+	if (createdAtMs === null)
+		return null;
+
+	return (now - createdAtMs) < boostWindowMs ? createdAtMs : null;
+}
+
 function RouteComponent() {
 	// Preload the clusters for version page
 	useCommandSuspense(['getClustersGroupedByMajor'], bindings.oneclient.getClustersGroupedByMajor);
@@ -37,12 +59,16 @@ function RouteComponent() {
 	const BOOST_WINDOW_MS = 7 * 24 * 60 * 60 * 1000;
 	const now = Date.now();
 	const displayClusters = [...lastPlayedClusters].sort((a, b) => {
-		const aIsNew = a.last_played === null && (now - new Date(a.created_at).getTime()) < BOOST_WINDOW_MS;
-		const bIsNew = b.last_played === null && (now - new Date(b.created_at).getTime()) < BOOST_WINDOW_MS;
-		if (aIsNew && !bIsNew)
+		const aBoostedCreatedAtMs = getBoostedCreatedAtMs(a, now, BOOST_WINDOW_MS);
+		const bBoostedCreatedAtMs = getBoostedCreatedAtMs(b, now, BOOST_WINDOW_MS);
+
+		if (aBoostedCreatedAtMs !== null && bBoostedCreatedAtMs === null)
 			return -1;
-		if (bIsNew && !aIsNew)
+		if (bBoostedCreatedAtMs !== null && aBoostedCreatedAtMs === null)
 			return 1;
+		if (aBoostedCreatedAtMs !== null && bBoostedCreatedAtMs !== null)
+			return bBoostedCreatedAtMs - aBoostedCreatedAtMs;
+
 		return 0;
 	}).slice(0, 3);