Skip to content

Commit 38b256b

Browse files
committed
Merged revision(s) 25189 from trunk/OpenMPT:
[Fix] Plugins: DigiBooster: Fix size check in SetChunk() to check the destination size instead of bogus sizeof(mpt::const_byte_span). Broken since r8363. Fixes <https://bugs.openmpt.org/view.php?id=1966>. [Fix] Plugins: SymMOD: Fix size check in SetChunk() to check the destination size instead of bogus sizeof(mpt::const_byte_span). Fixes <https://bugs.openmpt.org/view.php?id=1966>. ........ git-svn-id: https://source.openmpt.org/svn/openmpt/branches/OpenMPT-1.32@25190 56274372-70c3-4bfc-bfc3-4c3a0b034d27
1 parent c828da8 commit 38b256b

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

soundlib/plugins/DigiBoosterEcho.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ IMixPlugin::ChunkData DigiBoosterEcho::GetChunk(bool)
208208
void DigiBoosterEcho::SetChunk(const ChunkData &chunk, bool)
209209
{
210210
auto data = chunk.data();
211-
if(chunk.size() == sizeof(chunk) && !memcmp(data, "Echo", 4))
211+
if(chunk.size() == sizeof(m_chunk) && !memcmp(data, "Echo", 4))
212212
{
213213
memcpy(&m_chunk, data, chunk.size());
214214
RecalculateEchoParams();

soundlib/plugins/SymMODEcho.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@ IMixPlugin::ChunkData SymMODEcho::GetChunk(bool)
242242
void SymMODEcho::SetChunk(const ChunkData& chunk, bool)
243243
{
244244
auto data = chunk.data();
245-
if(chunk.size() == sizeof(chunk) && !memcmp(data, "Echo", 4))
245+
if(chunk.size() == sizeof(m_chunk) && !memcmp(data, "Echo", 4))
246246
{
247247
memcpy(&m_chunk, data, chunk.size());
248248
RecalculateEchoParams();

0 commit comments

Comments
 (0)