Merge pull request #3638 from OPCFoundation/master378

Prepare release 1.5.378 from master378

Author: mrsuciu

.azurepipelines/ci.yml

@@ -10,7 +10,7 @@ jobs:
 - job: buildprep${{ parameters.jobnamesuffix }}
   displayName: Prepare Build Jobs
   pool:
-    vmImage: 'windows-2025'
+    vmImage: 'windows-2025-vs2026'
   variables:
     DOTNET_CLI_TELEMETRY_OPTOUT: true
     DOTNET_SKIP_FIRST_TIME_EXPERIENCE: true
@@ -51,7 +51,7 @@ jobs:
       arguments: '--framework ${{ parameters.framework }} --configuration Release ${{ parameters.buildoption }} /p:RCS=true'
   - task: DotNetCoreCLI@2
     displayName: Release Pack
-    condition: eq(variables['poolImage'], 'windows-2025')
+    condition: eq(variables['poolImage'], 'windows-2025-vs2026')
     inputs:
       command: pack
       packagesToPack:  '**/Opc.Ua.*.csproj'
@@ -65,7 +65,7 @@ jobs:
       arguments: '--framework ${{ parameters.framework }} --configuration Debug ${{ parameters.buildoption }} /p:RCS=true'
   - task: DotNetCoreCLI@2
     displayName: Debug Pack
-    condition: eq(variables['poolImage'], 'windows-2025')
+    condition: eq(variables['poolImage'], 'windows-2025-vs2026')
     inputs:
       command: pack
       packagesToPack:  '**/Opc.Ua.*.csproj'

.azurepipelines/get-matrix.ps1

@@ -43,7 +43,7 @@ if (![string]::IsNullOrEmpty($JobPrefix)) {
 if ($AgentTable -eq $null -or $AgentTable.Count -eq 0)
 {
     $agents = @{
-        windows = "windows-2025"
+        windows = "windows-2025-vs2026"
         linux = "ubuntu-22.04"
         mac = "macOS-15"
     }

.azurepipelines/preview.yml

@@ -19,7 +19,7 @@ jobs:
 - job: nuget${{parameters.config}}
   displayName: Pack Nugets ${{parameters.config}}
   pool:
-    vmImage: 'windows-2025'
+    vmImage: 'windows-2025-vs2026'
   variables:
   - group: codesign
   - name: msbuildversion

.azurepipelines/sln.yml

@@ -2,7 +2,7 @@
 # Build all solutions on windows
 #
 parameters:
-  poolImage: 'windows-2025'
+  poolImage: 'windows-2025-vs2026'
   jobnamesuffix: ''
 
 jobs:

.azurepipelines/test.yml

@@ -11,7 +11,7 @@ jobs:
 - job: testprep${{ parameters.jobnamesuffix }}
   displayName: Prepare Test Jobs ${{ parameters.configuration }} (${{ parameters.framework }})
   pool:
-    vmImage: 'windows-2025'
+    vmImage: 'windows-2025-vs2026'
   variables:
     DOTNET_CLI_TELEMETRY_OPTOUT: true
     DOTNET_SKIP_FIRST_TIME_EXPERIENCE: true
@@ -92,3 +92,8 @@ jobs:
       command: test
       projects: $(file)
       arguments: '--no-restore ${{ variables.DotCliCommandline }} --configuration ${{ parameters.configuration }}'
+  - task: PublishBuildArtifacts@1
+    displayName: 'Publish Fuzzing artifacts on failure'
+    condition: and(failed(), ne(variables['fuzzingartifacts.secureFilePath'], ''))
+    inputs:
+      PathtoPublish: '$(Agent.TempDirectory)/FuzzingArtifacts.zip'

.azurepipelines/testcc.yml

@@ -106,3 +106,8 @@ jobs:
       COMMIT_UUID: '$(Build.SourceVersion)'
     continueOnError: true
     displayName: 'Upload to Codacy'
+  - task: PublishBuildArtifacts@1
+    displayName: 'Publish Fuzzing artifacts on failure'
+    condition: and(failed(), ne(variables['fuzzingartifacts.secureFilePath'], ''))
+    inputs:
+      PathtoPublish: '$(Agent.TempDirectory)/FuzzingArtifacts.zip'

.gitignore

@@ -267,4 +267,5 @@ testEnvironments.json
 # UA Fuzzing findings folders
 /Fuzzing/**/findings/
 /Fuzzing/**/Testcases/
-!/Fuzzing/**/Testcases/*.bin
+!/Fuzzing/**/Testcases/*.bin
+**/Properties/launchSettings.json

Applications/ConsoleReferenceClient/ClientSamples.cs

@@ -74,7 +74,8 @@ public ClientSamples(
         {
             m_telemetry = telemetry;
             m_logger = telemetry.CreateLogger<ClientSamples>();
-            m_validateResponse = validateResponse ?? ClientBase.ValidateResponse;
+            m_validate = validateResponse;
+
             m_quitEvent = quitEvent;
             m_verbose = verbose;
             m_desiredEventFields = [];
@@ -146,7 +147,7 @@ public async Task ReadNodesAsync(ISession session, CancellationToken ct = defaul
                 DiagnosticInfoCollection diagnosticInfos = response.DiagnosticInfos;
 
                 // Validate the results
-                m_validateResponse(resultsValues, nodesToRead);
+                ValidateResponse(resultsValues, nodesToRead);
 
                 // Display the results.
                 foreach (DataValue result in resultsValues)
@@ -187,7 +188,7 @@ public async Task WriteNodesAsync(ISession session, CancellationToken ct = defau
                 // Int32 Node - Objects\CTT\Scalar\Scalar_Static\Int32
                 var intWriteVal = new WriteValue
                 {
-                    NodeId = new NodeId("ns=2;s=Scalar_Static_Int32"),
+                    NodeId = NodeId.Parse("ns=2;s=Scalar_Static_Int32"),
                     AttributeId = Attributes.Value,
                     Value = new DataValue { Value = 100 }
                 };
@@ -196,7 +197,7 @@ public async Task WriteNodesAsync(ISession session, CancellationToken ct = defau
                 // Float Node - Objects\CTT\Scalar\Scalar_Static\Float
                 var floatWriteVal = new WriteValue
                 {
-                    NodeId = new NodeId("ns=2;s=Scalar_Static_Float"),
+                    NodeId = NodeId.Parse("ns=2;s=Scalar_Static_Float"),
                     AttributeId = Attributes.Value,
                     Value = new DataValue { Value = (float)100.5 }
                 };
@@ -205,7 +206,7 @@ public async Task WriteNodesAsync(ISession session, CancellationToken ct = defau
                 // String Node - Objects\CTT\Scalar\Scalar_Static\String
                 var stringWriteVal = new WriteValue
                 {
-                    NodeId = new NodeId("ns=2;s=Scalar_Static_String"),
+                    NodeId = NodeId.Parse("ns=2;s=Scalar_Static_String"),
                     AttributeId = Attributes.Value,
                     Value = new DataValue { Value = "String Test" }
                 };
@@ -224,7 +225,7 @@ public async Task WriteNodesAsync(ISession session, CancellationToken ct = defau
                 DiagnosticInfoCollection diagnosticInfos = response.DiagnosticInfos;
 
                 // Validate the response
-                m_validateResponse(results, nodesToWrite);
+                ValidateResponse(results, nodesToWrite);
 
                 // Display the results.
                 Console.WriteLine("Write Results :");
@@ -302,8 +303,8 @@ public async Task CallMethodAsync(ISession session, CancellationToken ct = defau
                 // Define the UA Method to call
                 // Parent node - Objects\CTT\Methods
                 // Method node - Objects\CTT\Methods\Add
-                var objectId = new NodeId("ns=2;s=Methods");
-                var methodId = new NodeId("ns=2;s=Methods_Add");
+                var objectId = NodeId.Parse("ns=2;s=Methods");
+                var methodId = NodeId.Parse("ns=2;s=Methods_Add");
 
                 // Define the method parameters
                 // Input argument requires a Float and an UInt32 value
@@ -351,8 +352,8 @@ public async Task EnableEventsAsync(
                 // Define the UA Method to call
                 // Parent node - Objects\CTT\Alarms
                 // Method node - Objects\CTT\Alarms\Start
-                var objectId = new NodeId("ns=7;s=Alarms");
-                var methodId = new NodeId("ns=7;s=Alarms.Start");
+                var objectId = NodeId.Parse("ns=7;s=Alarms");
+                var methodId = NodeId.Parse("ns=7;s=Alarms.Start");
 
                 // Define the method parameters
                 // Input argument requires a Float and an UInt32 value
@@ -457,7 +458,7 @@ public async Task<bool> SubscribeToDataChangesAsync(
                 var intMonitoredItem = new MonitoredItem(subscription.DefaultItem)
                 {
                     // Int32 Node - Objects\CTT\Scalar\Simulation\Int32
-                    StartNodeId = new NodeId("ns=2;s=Scalar_Simulation_Int32"),
+                    StartNodeId = NodeId.Parse("ns=2;s=Scalar_Simulation_Int32"),
                     AttributeId = Attributes.Value,
                     DisplayName = "Int32 Variable",
                     SamplingInterval = itemSamplingInterval,
@@ -471,7 +472,7 @@ public async Task<bool> SubscribeToDataChangesAsync(
                 var floatMonitoredItem = new MonitoredItem(subscription.DefaultItem)
                 {
                     // Float Node - Objects\CTT\Scalar\Simulation\Float
-                    StartNodeId = new NodeId("ns=2;s=Scalar_Simulation_Float"),
+                    StartNodeId = NodeId.Parse("ns=2;s=Scalar_Simulation_Float"),
                     AttributeId = Attributes.Value,
                     DisplayName = "Float Variable",
                     SamplingInterval = itemSamplingInterval,
@@ -484,7 +485,7 @@ public async Task<bool> SubscribeToDataChangesAsync(
                 var stringMonitoredItem = new MonitoredItem(subscription.DefaultItem)
                 {
                     // String Node - Objects\CTT\Scalar\Simulation\String
-                    StartNodeId = new NodeId("ns=2;s=Scalar_Simulation_String"),
+                    StartNodeId = NodeId.Parse("ns=2;s=Scalar_Simulation_String"),
                     AttributeId = Attributes.Value,
                     DisplayName = "String Variable",
                     SamplingInterval = itemSamplingInterval,
@@ -496,7 +497,7 @@ public async Task<bool> SubscribeToDataChangesAsync(
 
                 var eventMonitoredItem = new MonitoredItem(subscription.DefaultItem)
                 {
-                    StartNodeId = new NodeId(ObjectIds.Server),
+                    StartNodeId = ObjectIds.Server,
                     AttributeId = Attributes.EventNotifier,
                     DisplayName = "Event Variable",
                     SamplingInterval = itemSamplingInterval,
@@ -529,7 +530,7 @@ public async Task<bool> SubscribeToDataChangesAsync(
                 };
                 var desiredEventType = new LiteralOperand
                 {
-                    Value = new Variant(new NodeId(ObjectTypeIds.ExclusiveLevelAlarmType))
+                    Value = new Variant(ObjectTypeIds.ExclusiveLevelAlarmType)
                 };
 
                 whereClause.Push(FilterOperator.Equals, [existingEventType, desiredEventType]);
@@ -715,7 +716,7 @@ public async Task<IList<INode>> FetchAllNodesNodeCacheAsync(
         /// <param name="browseDescription">An optional BrowseDescription to use.</param>
         public async Task<ReferenceDescriptionCollection> ManagedBrowseFullAddressSpaceAsync(
             IUAClient uaClient,
-            NodeId startingNode = null,
+            NodeId startingNode = default,
             BrowseDescription browseDescription = null,
             CancellationToken ct = default)
         {
@@ -891,7 +892,7 @@ await uaClient
         /// <param name="browseDescription">An optional BrowseDescription to use.</param>
         public async Task<ReferenceDescriptionCollection> BrowseFullAddressSpaceAsync(
             IUAClient uaClient,
-            NodeId startingNode = null,
+            NodeId startingNode = default,
             BrowseDescription browseDescription = null,
             CancellationToken ct = default)
         {
@@ -990,8 +991,8 @@ BrowseDescriptionCollection browseDescriptionCollection
                     }
                     catch (ServiceResultException sre)
                     {
-                        if (sre.StatusCode is StatusCodes.BadEncodingLimitsExceeded or StatusCodes
-                            .BadResponseTooLarge)
+                        if (sre.StatusCode == StatusCodes.BadEncodingLimitsExceeded ||
+                            sre.StatusCode == StatusCodes.BadResponseTooLarge)
                         {
                             // try to address by overriding operation limit
                             maxNodesPerBrowse =
@@ -1119,7 +1120,7 @@ public async Task<ComplexTypeSystem> LoadTypeSystemAsync(
             stopWatch.Start();
 
             var complexTypeSystem = new ComplexTypeSystem(session, m_telemetry);
-            await complexTypeSystem.LoadAsync(ct: ct).ConfigureAwait(false);
+            await complexTypeSystem.LoadAsync(throwOnError: true, ct: ct).ConfigureAwait(false);
 
             stopWatch.Stop();
 
@@ -1775,7 +1776,21 @@ private static ByteStringCollection PrepareBrowseNext(
             return continuationPoints;
         }
 
-        private readonly Action<IList, IList> m_validateResponse;
+        private void ValidateResponse<TRequest, TResponse>(
+            IReadOnlyList<TRequest> requests,
+            IReadOnlyList<TResponse> responses)
+        {
+            if (m_validate != null)
+            {
+                m_validate(requests?.ToList(), responses?.ToList());
+            }
+            else
+            {
+                ClientBase.ValidateResponse(responses, requests);
+            }
+        }
+
+        private readonly Action<IList, IList> m_validate;
         private readonly ITelemetryContext m_telemetry;
         private readonly ILogger m_logger;
         private readonly ManualResetEvent m_quitEvent;

Applications/ConsoleReferenceClient/Program.cs

@@ -36,7 +36,6 @@
 using System.Text;
 using System.Threading;
 using System.Threading.Tasks;
-using System.Xml.Linq;
 using Microsoft.Extensions.Logging;
 using Opc.Ua;
 using Opc.Ua.Client;
@@ -455,7 +454,7 @@ CertificateIdentifier userCertificateIdentifier
                         application.ApplicationConfiguration,
                         reverseConnectManager,
                         telemetry,
-                        ClientBase.ValidateResponse
+                        null
                     )
                     {
                         AutoAccept = autoAccept,
@@ -482,7 +481,7 @@ CertificateIdentifier userCertificateIdentifier
                         uaClient.Session.TransferSubscriptionsOnReconnect = true;
                         var samples = new ClientSamples(
                             telemetry,
-                            ClientBase.ValidateResponse,
+                            null,
                             quitEvent,
                             verbose);
                         if (loadTypes)
@@ -733,14 +732,14 @@ await samples.SubscribeToDataChangesAsync(
                                     if (waitCounters == closeSessionTime &&
                                         uaClient.Session.SubscriptionCount == 1)
                                     {
-                                        Console.WriteLine($"Closing Session (CurrentTime: {DateTime.Now.ToLongTimeString()})");
+                                        Console.WriteLine($"Closing Session (CurrentTime: {DateTime.Now:T})");
                                         await uaClient.Session.CloseAsync(closeChannel: false, ct: ct)
                                             .ConfigureAwait(false);
                                     }
 
                                     if (waitCounters == restartSessionTime)
                                     {
-                                        Console.WriteLine($"Restarting Session (CurrentTime: {DateTime.Now.ToLongTimeString()})");
+                                        Console.WriteLine($"Restarting Session (CurrentTime: {DateTime.Now:T})");
                                         await uaClient
                                             .DurableSubscriptionTransferAsync(
                                                 serverUrl.ToString(),

Applications/ConsoleReferenceClient/UAClient.cs

@@ -220,8 +220,7 @@ public async Task<bool> ConnectAsync(
                             {
                                 throw new ServiceResultException(
                                     StatusCodes.BadTimeout,
-                                    "Waiting for a reverse connection timed out."
-                                );
+                                    "Waiting for a reverse connection timed out.");
                             }
                             if (endpointDescription == null)
                             {