Add line number click selection feature

Eli Belash · claude · Eli Belash · commit 396c1114911d · 2025-11-29T21:14:20.000+02:00
Click on line numbers in the left margin to select entire lines: - Single click: selects the entire line - Shift+click: extends selection to clicked line - Click and drag: select multiple lines Based on PR microsoft#622 by jenia90 (microsoft#622) Also adds additional dialog logging coverage (log_dialog_open/close). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
diff --git a/README.md b/README.md
@@ -8,6 +8,7 @@ OGEdit aims to deliver more features faster with less bureaucracy.
 
 - [Key Features](#features)
   - [Selection Auto-Highlight](#selection-auto-highlight)
+  - [Line Number Click Selection](#line-number-click-selection)
   - [Ctrl+D Duplicate Line](#ctrld-duplicate-line)
   - [File Watcher](#file-watcher)
   - [F5 Reload from Disk](#f5-reload-from-disk)
@@ -43,6 +44,18 @@ When you select text, all identical occurrences in the document are highlighted
 
 **Performance:** Limited to 1000 matches to maintain responsiveness in large files.
 
+### Line Number Click Selection
+
+Click on line numbers in the left margin to quickly select entire lines:
+
+- **Single click**: Selects the entire line
+- **Shift+click**: Extends selection from current position to the clicked line
+- **Click and drag**: Select multiple lines by dragging across line numbers
+
+This feature only works when line numbers are visible (enabled by default, configurable via `line_numbers` setting).
+
+*Based on [PR #622](https://github.com/microsoft/edit/pull/622) by [jenia90](https://github.com/jenia90).*
+
 ### Ctrl+D Duplicate Line
 
 Duplicate the current line or selection with `Ctrl+D`. Also available via **Edit → Duplicate** menu (accelerator key: `D`).
diff --git a/src/bin/edit/draw_editor.rs b/src/bin/edit/draw_editor.rs
@@ -488,6 +488,7 @@ pub fn draw_goto_menu(ctx: &mut Context, state: &mut State) {
                 match validate_goto_point(&state.goto_target) {
                     Ok(point) => {
                         logging::log_goto(point);
+                        logging::log_dialog_close("Go to Line", &format!("Ln {}", point.y + 1));
                         let mut buf = doc.buffer.borrow_mut();
                         buf.cursor_move_to_logical(point);
                         buf.make_cursor_visible();
diff --git a/src/bin/edit/draw_filepicker.rs b/src/bin/edit/draw_filepicker.rs
@@ -223,6 +223,7 @@ pub fn draw_file_picker(ctx: &mut Context, state: &mut State) {
                 && let Some(path) = doit.as_deref()
                 && path.exists()
             {
+                logging::log_dialog_open("Overwrite Warning");
                 state.file_picker_overwrite_warning = doit.take();
             }
         }
@@ -258,6 +259,7 @@ pub fn draw_file_picker(ctx: &mut Context, state: &mut State) {
                 ctx.inherit_focus();
 
                 if ctx.button("no", loc(LocId::No), ButtonStyle::default()) {
+                    logging::log_dialog_close("Overwrite Warning", "No");
                     state.file_picker_overwrite_warning = None;
                 }
             }
@@ -296,12 +298,14 @@ pub fn draw_file_picker(ctx: &mut Context, state: &mut State) {
             Ok(..) => {
                 if is_open {
                     logging::log_file_open(&path_str);
+                    logging::log_dialog_close("File Picker", "file opened");
                     // Track in recent files
                     state.config.add_recent_file(&path);
                     // Start watching for external modifications
                     state.file_watcher.watch(&path);
                 } else {
                     logging::log_file_save(&path_str);
+                    logging::log_dialog_close("File Picker", "file saved");
                     // Save the parent directory as the last-used save folder for this project
                     if let Some(parent) = path.parent() {
                         let parent_str = parent.to_string_lossy().to_string();
diff --git a/src/bin/edit/draw_menubar.rs b/src/bin/edit/draw_menubar.rs
@@ -23,6 +23,7 @@ pub fn draw_menubar(ctx: &mut Context, state: &mut State) {
             draw_menu_file(ctx, state);
         }
         if !contains_focus && ctx.consume_shortcut(vk::F10) {
+            logging::log_action("SHORTCUT: F10 -> Activate menubar");
             ctx.steal_focus();
         }
         if state.documents.active().is_some() {
diff --git a/src/bin/edit/draw_statusbar.rs b/src/bin/edit/draw_statusbar.rs
@@ -63,17 +63,23 @@ pub fn draw_statusbar(ctx: &mut Context, state: &mut State) {
                 {
                     if ctx.button("reopen", loc(LocId::EncodingReopen), ButtonStyle::default()) {
                         logging::log_action("ENCODING_METHOD: Reopen");
+                        logging::log_dialog_close("Encoding Picker", "Reopen");
+                        logging::log_dialog_open("Encoding Change");
                         state.wants_encoding_change = StateEncodingChange::Reopen;
                     }
                     ctx.focus_on_first_present();
                     if ctx.button("convert", loc(LocId::EncodingConvert), ButtonStyle::default()) {
                         logging::log_action("ENCODING_METHOD: Convert");
+                        logging::log_dialog_close("Encoding Picker", "Convert");
+                        logging::log_dialog_open("Encoding Change");
                         state.wants_encoding_change = StateEncodingChange::Convert;
                     }
                 }
                 ctx.block_end();
             } else {
                 // Can't reopen a file that doesn't exist.
+                logging::log_dialog_close("Encoding Picker", "Convert (no file)");
+                logging::log_dialog_open("Encoding Change");
                 state.wants_encoding_change = StateEncodingChange::Convert;
             }
 
@@ -306,6 +312,7 @@ pub fn draw_dialog_encoding_change(ctx: &mut Context, state: &mut State) {
     if let Some(encoding) = change
         && let Some(doc) = state.documents.active_mut()
     {
+        logging::log_dialog_close("Encoding Change", encoding);
         let old_encoding = doc.buffer.borrow().encoding();
         logging::log_encoding_change(old_encoding, encoding);
 
@@ -390,6 +397,7 @@ pub fn draw_go_to_file(ctx: &mut Context, state: &mut State) {
                 let activated = ctx.styled_list_item_end(false) == ListSelection::Activated;
                 if activated {
                     logging::log_action(&format!("SWITCH_DOCUMENT: {}", doc.filename));
+                    logging::log_dialog_close("Go to File", "document selected");
                 }
                 activated
             }) {
@@ -421,6 +429,7 @@ pub fn draw_go_to_file(ctx: &mut Context, state: &mut State) {
                                     state.config.add_recent_file(&path);
                                     // Start watching for external modifications
                                     state.file_watcher.watch(&path);
+                                    logging::log_dialog_close("Go to File", "recent file opened");
                                     state.wants_go_to_file = false;
                                     ctx.needs_rerender();
                                 }
diff --git a/src/bin/edit/main.rs b/src/bin/edit/main.rs
@@ -619,23 +619,27 @@ fn draw_handle_clipboard_change(ctx: &mut Context, state: &mut State) {
 
             if over_limit {
                 if ctx.button("ok", loc(LocId::Ok), ButtonStyle::default()) {
+                    logging::log_dialog_close("Large Clipboard Warning", "Ok");
                     done = Some(true);
                 }
                 ctx.inherit_focus();
             } else {
                 if ctx.button("always", loc(LocId::Always), ButtonStyle::default()) {
+                    logging::log_dialog_close("Large Clipboard Warning", "Always");
                     state.osc_clipboard_always_send = true;
                     done = Some(true);
                 }
 
                 if ctx.button("yes", loc(LocId::Yes), ButtonStyle::default()) {
+                    logging::log_dialog_close("Large Clipboard Warning", "Yes");
                     done = Some(true);
                 }
                 if data_len < 10 * LARGE_CLIPBOARD_THRESHOLD {
                     ctx.inherit_focus();
                 }
 
                 if ctx.button("no", loc(LocId::No), ButtonStyle::default()) {
+                    logging::log_dialog_close("Large Clipboard Warning", "No");
                     done = Some(false);
                 }
                 if data_len >= 10 * LARGE_CLIPBOARD_THRESHOLD {
@@ -646,6 +650,7 @@ fn draw_handle_clipboard_change(ctx: &mut Context, state: &mut State) {
         ctx.table_end();
     }
     if ctx.modal_end() {
+        logging::log_dialog_close("Large Clipboard Warning", "Escape");
         done = Some(false);
     }
 
diff --git a/src/bin/edit/state.rs b/src/bin/edit/state.rs
@@ -322,6 +322,8 @@ pub fn draw_add_untitled_document(ctx: &mut Context, state: &mut State) {
 pub fn error_log_add(ctx: &mut Context, state: &mut State, err: apperr::Error) {
     let msg = format!("{}", FormatApperr::from(err));
     if !msg.is_empty() {
+        logging::log_error(&msg);
+        logging::log_dialog_open("Error");
         state.error_log[state.error_log_index] = msg;
         state.error_log_index = (state.error_log_index + 1) % state.error_log.len();
         state.error_log_count = state.error_log.len().min(state.error_log_count + 1);
@@ -353,12 +355,14 @@ pub fn draw_error_log(ctx: &mut Context, state: &mut State) {
         ctx.block_end();
 
         if ctx.button("ok", loc(LocId::Ok), ButtonStyle::default()) {
+            logging::log_dialog_close("Error", "Ok");
             state.error_log_count = 0;
         }
         ctx.attr_position(Position::Center);
         ctx.inherit_focus();
     }
     if ctx.modal_end() {
+        logging::log_dialog_close("Error", "Escape");
         state.error_log_count = 0;
     }
 }
diff --git a/src/tui.rs b/src/tui.rs
@@ -2230,7 +2230,40 @@ impl<'a> Context<'a, '_> {
                 y: mouse.y - inner.top + tc.scroll_offset.y,
             };
 
-            if text_rect.contains(self.tui.mouse_down_position) {
+            // Margin/gutter area for line number clicks
+            // Credit: jenia90 (https://github.com/microsoft/edit/pull/622)
+            let margin_rect = Rect {
+                left: inner.left,
+                top: inner.top,
+                right: inner.left + tb.margin_width(),
+                bottom: inner.bottom,
+            };
+
+            if margin_rect.contains(self.tui.mouse_down_position) && tb.margin_width() > 0 {
+                // Clicking in the margin (line numbers) selects entire lines
+                if self.tui.mouse_is_drag {
+                    // Dragging across line numbers extends selection
+                    if !tb.has_selection() {
+                        tb.start_selection();
+                    }
+                    tb.selection_update_visual(Point { x: CoordType::MAX, y: pos.y });
+                    tc.preferred_column = tb.cursor_visual_pos().x;
+                } else if self.tui.mouse_state == InputMouseState::Left {
+                    // Single click on line number
+                    if self.input_mouse_modifiers.contains(kbmod::SHIFT) {
+                        // Shift+click extends selection to this line
+                        tb.selection_update_visual(Point { x: CoordType::MAX, y: pos.y });
+                    } else {
+                        // Regular click selects the entire line
+                        tb.cursor_move_to_visual(Point { x: 0, y: pos.y });
+                        tb.select_line();
+                    }
+                    tc.preferred_column = tb.cursor_visual_pos().x;
+                }
+                make_cursor_visible = true;
+                self.set_input_consumed();
+                return make_cursor_visible;
+            } else if text_rect.contains(self.tui.mouse_down_position) {
                 if self.tui.mouse_is_drag {
                     tb.selection_update_visual(pos);
                     tc.preferred_column = tb.cursor_visual_pos().x;

Original file line number	Diff line number	Diff line change
`@@ -223,6 +223,7 @@ pub fn draw_file_picker(ctx: &mut Context, state: &mut State) {`
`223`	`223`	`&& let Some(path) = doit.as_deref()`
`224`	`224`	`&& path.exists()`
`225`	`225`	`{`
	`226`	`+ logging::log_dialog_open("Overwrite Warning");`
`226`	`227`	`state.file_picker_overwrite_warning = doit.take();`
`227`	`228`	`}`
`228`	`229`	`}`
`@@ -258,6 +259,7 @@ pub fn draw_file_picker(ctx: &mut Context, state: &mut State) {`
`258`	`259`	`ctx.inherit_focus();`
`259`	`260`
`260`	`261`	`if ctx.button("no", loc(LocId::No), ButtonStyle::default()) {`
	`262`	`+ logging::log_dialog_close("Overwrite Warning", "No");`
`261`	`263`	`state.file_picker_overwrite_warning = None;`
`262`	`264`	`}`
`263`	`265`	`}`
`@@ -296,12 +298,14 @@ pub fn draw_file_picker(ctx: &mut Context, state: &mut State) {`
`296`	`298`	`Ok(..) => {`
`297`	`299`	`if is_open {`
`298`	`300`	`logging::log_file_open(&path_str);`
	`301`	`+ logging::log_dialog_close("File Picker", "file opened");`
`299`	`302`	`// Track in recent files`
`300`	`303`	`state.config.add_recent_file(&path);`
`301`	`304`	`// Start watching for external modifications`
`302`	`305`	`state.file_watcher.watch(&path);`
`303`	`306`	`} else {`
`304`	`307`	`logging::log_file_save(&path_str);`
	`308`	`+ logging::log_dialog_close("File Picker", "file saved");`
`305`	`309`	`// Save the parent directory as the last-used save folder for this project`
`306`	`310`	`if let Some(parent) = path.parent() {`
`307`	`311`	`let parent_str = parent.to_string_lossy().to_string();`
Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,7 @@ pub fn draw_menubar(ctx: &mut Context, state: &mut State) {`
`23`	`23`	`draw_menu_file(ctx, state);`
`24`	`24`	`}`
`25`	`25`	`if !contains_focus && ctx.consume_shortcut(vk::F10) {`
	`26`	`+ logging::log_action("SHORTCUT: F10 -> Activate menubar");`
`26`	`27`	`ctx.steal_focus();`
`27`	`28`	`}`
`28`	`29`	`if state.documents.active().is_some() {`
Original file line number	Diff line number	Diff line change
`@@ -63,17 +63,23 @@ pub fn draw_statusbar(ctx: &mut Context, state: &mut State) {`
`63`	`63`	`{`
`64`	`64`	`if ctx.button("reopen", loc(LocId::EncodingReopen), ButtonStyle::default()) {`
`65`	`65`	`logging::log_action("ENCODING_METHOD: Reopen");`
	`66`	`+ logging::log_dialog_close("Encoding Picker", "Reopen");`
	`67`	`+ logging::log_dialog_open("Encoding Change");`
`66`	`68`	`state.wants_encoding_change = StateEncodingChange::Reopen;`
`67`	`69`	`}`
`68`	`70`	`ctx.focus_on_first_present();`
`69`	`71`	`if ctx.button("convert", loc(LocId::EncodingConvert), ButtonStyle::default()) {`
`70`	`72`	`logging::log_action("ENCODING_METHOD: Convert");`
	`73`	`+ logging::log_dialog_close("Encoding Picker", "Convert");`
	`74`	`+ logging::log_dialog_open("Encoding Change");`
`71`	`75`	`state.wants_encoding_change = StateEncodingChange::Convert;`
`72`	`76`	`}`
`73`	`77`	`}`
`74`	`78`	`ctx.block_end();`
`75`	`79`	`} else {`
`76`	`80`	`// Can't reopen a file that doesn't exist.`
	`81`	`+ logging::log_dialog_close("Encoding Picker", "Convert (no file)");`
	`82`	`+ logging::log_dialog_open("Encoding Change");`
`77`	`83`	`state.wants_encoding_change = StateEncodingChange::Convert;`
`78`	`84`	`}`
`79`	`85`
`@@ -306,6 +312,7 @@ pub fn draw_dialog_encoding_change(ctx: &mut Context, state: &mut State) {`
`306`	`312`	`if let Some(encoding) = change`
`307`	`313`	`&& let Some(doc) = state.documents.active_mut()`
`308`	`314`	`{`
	`315`	`+ logging::log_dialog_close("Encoding Change", encoding);`
`309`	`316`	`let old_encoding = doc.buffer.borrow().encoding();`
`310`	`317`	`logging::log_encoding_change(old_encoding, encoding);`
`311`	`318`
`@@ -390,6 +397,7 @@ pub fn draw_go_to_file(ctx: &mut Context, state: &mut State) {`
`390`	`397`	`let activated = ctx.styled_list_item_end(false) == ListSelection::Activated;`
`391`	`398`	`if activated {`
`392`	`399`	`logging::log_action(&format!("SWITCH_DOCUMENT: {}", doc.filename));`
	`400`	`+ logging::log_dialog_close("Go to File", "document selected");`
`393`	`401`	`}`
`394`	`402`	`activated`
`395`	`403`	`}) {`
`@@ -421,6 +429,7 @@ pub fn draw_go_to_file(ctx: &mut Context, state: &mut State) {`
`421`	`429`	`state.config.add_recent_file(&path);`
`422`	`430`	`// Start watching for external modifications`
`423`	`431`	`state.file_watcher.watch(&path);`
	`432`	`+ logging::log_dialog_close("Go to File", "recent file opened");`
`424`	`433`	`state.wants_go_to_file = false;`
`425`	`434`	`ctx.needs_rerender();`
`426`	`435`	`}`
Original file line number	Diff line number	Diff line change
`@@ -619,23 +619,27 @@ fn draw_handle_clipboard_change(ctx: &mut Context, state: &mut State) {`
`619`	`619`
`620`	`620`	`if over_limit {`
`621`	`621`	`if ctx.button("ok", loc(LocId::Ok), ButtonStyle::default()) {`
	`622`	`+ logging::log_dialog_close("Large Clipboard Warning", "Ok");`
`622`	`623`	`done = Some(true);`
`623`	`624`	`}`
`624`	`625`	`ctx.inherit_focus();`
`625`	`626`	`} else {`
`626`	`627`	`if ctx.button("always", loc(LocId::Always), ButtonStyle::default()) {`
	`628`	`+ logging::log_dialog_close("Large Clipboard Warning", "Always");`
`627`	`629`	`state.osc_clipboard_always_send = true;`
`628`	`630`	`done = Some(true);`
`629`	`631`	`}`
`630`	`632`
`631`	`633`	`if ctx.button("yes", loc(LocId::Yes), ButtonStyle::default()) {`
	`634`	`+ logging::log_dialog_close("Large Clipboard Warning", "Yes");`
`632`	`635`	`done = Some(true);`
`633`	`636`	`}`
`634`	`637`	`if data_len < 10 * LARGE_CLIPBOARD_THRESHOLD {`
`635`	`638`	`ctx.inherit_focus();`
`636`	`639`	`}`
`637`	`640`
`638`	`641`	`if ctx.button("no", loc(LocId::No), ButtonStyle::default()) {`
	`642`	`+ logging::log_dialog_close("Large Clipboard Warning", "No");`
`639`	`643`	`done = Some(false);`
`640`	`644`	`}`
`641`	`645`	`if data_len >= 10 * LARGE_CLIPBOARD_THRESHOLD {`
`@@ -646,6 +650,7 @@ fn draw_handle_clipboard_change(ctx: &mut Context, state: &mut State) {`
`646`	`650`	`ctx.table_end();`
`647`	`651`	`}`
`648`	`652`	`if ctx.modal_end() {`
	`653`	`+ logging::log_dialog_close("Large Clipboard Warning", "Escape");`
`649`	`654`	`done = Some(false);`
`650`	`655`	`}`
`651`	`656`
Original file line number	Diff line number	Diff line change
`@@ -322,6 +322,8 @@ pub fn draw_add_untitled_document(ctx: &mut Context, state: &mut State) {`
`322`	`322`	`pub fn error_log_add(ctx: &mut Context, state: &mut State, err: apperr::Error) {`
`323`	`323`	`let msg = format!("{}", FormatApperr::from(err));`
`324`	`324`	`if !msg.is_empty() {`
	`325`	`+ logging::log_error(&msg);`
	`326`	`+ logging::log_dialog_open("Error");`
`325`	`327`	`state.error_log[state.error_log_index] = msg;`
`326`	`328`	`state.error_log_index = (state.error_log_index + 1) % state.error_log.len();`
`327`	`329`	`state.error_log_count = state.error_log.len().min(state.error_log_count + 1);`
`@@ -353,12 +355,14 @@ pub fn draw_error_log(ctx: &mut Context, state: &mut State) {`
`353`	`355`	`ctx.block_end();`
`354`	`356`
`355`	`357`	`if ctx.button("ok", loc(LocId::Ok), ButtonStyle::default()) {`
	`358`	`+ logging::log_dialog_close("Error", "Ok");`
`356`	`359`	`state.error_log_count = 0;`
`357`	`360`	`}`
`358`	`361`	`ctx.attr_position(Position::Center);`
`359`	`362`	`ctx.inherit_focus();`
`360`	`363`	`}`
`361`	`364`	`if ctx.modal_end() {`
	`365`	`+ logging::log_dialog_close("Error", "Escape");`
`362`	`366`	`state.error_log_count = 0;`
`363`	`367`	`}`
`364`	`368`	`}`