fix(responses): NCMEC file IDs are hex strings, not integers

The /finish reportDoneResponse returns 32-char hex fileId values (e.g.
3a1d4fd4106b82499b7c93442aa7dca4). They were typed as list[int], so parsing a
real finished-report response raised 7 validation errors and the caller saw a
502 — even though NCMEC had accepted and filed the report.

- _Files.file_id: list[int] -> list[str]; file_ids property returns list[str].
- Regression test uses the real production payload (report 250799407, 7 hex ids).
- Fix the two prior tests that baked in the wrong int assumption (why it shipped).

Bump 0.1.0 -> 0.1.1.

Author: Nachtalb

pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "ncmec-cybertip"
-version = "0.1.0"
+version = "0.1.1"
 description = "A fully typed async client for the NCMEC CyberTipline Reporting API"
 readme = "README.md"
 license = "MIT"

src/ncmec_cybertip/responses.py

@@ -24,7 +24,7 @@ class ReportResponse(Base, tag="reportResponse"):
 class _Files(Base, tag="files"):
     """Wrapper for the list of file IDs in a done response."""
 
-    file_id: list[int] = element(tag="fileId", default_factory=list)
+    file_id: list[str] = element(tag="fileId", default_factory=list)
 
 
 class ReportDoneResponse(Base, tag="reportDoneResponse"):
@@ -35,6 +35,11 @@ class ReportDoneResponse(Base, tag="reportDoneResponse"):
     files: _Files = element(default_factory=_Files)
 
     @property
-    def file_ids(self) -> list[int]:
-        """The file IDs of files successfully uploaded to the finished report."""
+    def file_ids(self) -> list[str]:
+        """The file IDs of files successfully uploaded to the finished report.
+
+        NCMEC assigns each uploaded file a 32-char hex identifier (e.g.
+        ``3a1d4fd4106b82499b7c93442aa7dca4``) — these are opaque strings, not
+        integers.
+        """
         return self.files.file_id

tests/test_client.py

@@ -33,7 +33,7 @@
 _OK_FINISH = (
     b"<reportDoneResponse><responseCode>0</responseCode>"
     b"<reportId>4564654</reportId>"
-    b"<files><fileId>1</fileId></files></reportDoneResponse>"
+    b"<files><fileId>b0754af766b426f2928a02c651ed4b99</fileId></files></reportDoneResponse>"
 )
 
 
@@ -130,7 +130,7 @@ async def test_finish() -> None:
     )
     async with _client() as client:
         done = await client.finish(4564654)
-    assert done.file_ids == [1]
+    assert done.file_ids == ["b0754af766b426f2928a02c651ed4b99"]
     assert b"id=4564654" in route.calls.last.request.content
 
 

tests/test_models.py

@@ -252,15 +252,35 @@ def test_report_response_parses() -> None:
 
 
 def test_report_done_response_exposes_file_ids() -> None:
+    # NCMEC returns 32-char hex file IDs (opaque strings), not integers.
+    # Regression: report 250799407's real /finish response 502'd because these
+    # were previously typed as list[int]. This is the actual production payload.
     xml = (
+        b'<?xml version="1.0" encoding="UTF-8" standalone="yes"?>'
         b"<reportDoneResponse><responseCode>0</responseCode>"
-        b"<reportId>4564654</reportId>"
-        b"<files><fileId>1</fileId><fileId>2</fileId></files>"
+        b"<reportId>250799407</reportId>"
+        b"<files>"
+        b"<fileId>3a1d4fd4106b82499b7c93442aa7dca4</fileId>"
+        b"<fileId>23eb425911143eadc4987a2b3e221c09</fileId>"
+        b"<fileId>abd6aa21e080470e22c4c8c9cb8cf2af</fileId>"
+        b"<fileId>01d21d1cc0a6c34885973d6cda08f537</fileId>"
+        b"<fileId>d6aed6fe40d471c011640a6781b4a648</fileId>"
+        b"<fileId>3c62d4a8c475524b7ecd3f4764eeed94</fileId>"
+        b"<fileId>084fe41db96ac651eb0b8b2e0b400de0</fileId>"
+        b"</files>"
         b"</reportDoneResponse>"
     )
     done = ReportDoneResponse.from_xml(xml)
-    assert done.report_id == 4564654
-    assert done.file_ids == [1, 2]
+    assert done.report_id == 250799407
+    assert done.file_ids == [
+        "3a1d4fd4106b82499b7c93442aa7dca4",
+        "23eb425911143eadc4987a2b3e221c09",
+        "abd6aa21e080470e22c4c8c9cb8cf2af",
+        "01d21d1cc0a6c34885973d6cda08f537",
+        "d6aed6fe40d471c011640a6781b4a648",
+        "3c62d4a8c475524b7ecd3f4764eeed94",
+        "084fe41db96ac651eb0b8b2e0b400de0",
+    ]
 
 
 def test_report_done_response_empty_files() -> None: