feat(compute): add apple-container driver#1888
Draft
shiju-nv wants to merge 1 commit into
Draft
Conversation
Add an opt-in Apple Container compute driver for local macOS gateways. The driver shells out to Apple's container CLI using JSON output where available, creates per-sandbox containers with OpenShell supervisor wiring, and reports lifecycle state through the existing compute-driver contract. Register the driver in gateway configuration, telemetry, and server runtime selection. Derive the sandbox callback endpoint from the gateway bind port so Apple Container guests can reach the gateway through host.container.internal. Cover the Apple host callback alias in generated local TLS server certificates, and reject non-empty Apple driver_config payloads until the driver has a supported per-sandbox config schema. Keep Apple validation aligned with the Docker driver contract: validate preflight-safe template/image fields before JWT minting, then enforce the sandbox token only inside the create path after the gateway injects it. Serialize compute create with delete and watch reconciliation so the store record cannot be removed before backend creation starts. Propagate user template labels to Apple Container runtime containers while preserving OpenShell-managed labels, matching Docker and Podman label behavior. Document the driver, its CLI prerequisite, integer CPU-limit behavior, TLS/JWT expectations, explicit driver selection, and supervisor delivery model. Add focused parser, config, lifecycle, resource, and server wiring tests. Signed-off-by: Shiju <shiju@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Collaborator
|
See #1887 (comment). Let's close for now. We can revisit once runtime improvements and topologies have started to materialize. I don't see any E2E tests, so I'm also curious if this actually works with Apple's default kernel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an opt-in
apple-containercompute driver for local macOS gateways. The driver shells out to Apple'scontainerCLI, wires the OpenShell supervisor into Apple Container guests, and keeps the runtime explicit-only so existing Kubernetes, Podman, and Docker auto-detection behavior is unchanged.Related Issue
Closes #1887
Changes
openshell-driver-apple-containercrate with Apple CLI JSON parsing, lifecycle operations, status mapping, watch polling, and a gRPC driver adapter.apple-containerin compute-driver configuration, telemetry, server runtime selection, gateway config parsing, and local mTLS defaults.host.container.internal, and register the discovered Apple Container network gateway listener when needed.driver_configpayloads until the driver has a supported per-sandbox config schema.Testing
mise run pre-commitpassesChecklist