Skip to content

Commit 5df55b9

Browse files
committed
refactor(core): move DEFAULT_K8S_NAMESPACE into K8s driver
The constant is Kubernetes-specific (used only by KubernetesComputeConfig's Default impl) and does not belong in openshell-core. Relocate it to the driver crate that owns the K8s vocabulary; openshell-core retains only truly cross-cutting defaults.
1 parent 919cc7c commit 5df55b9

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

crates/openshell-core/src/config.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,6 @@ pub const DEFAULT_SUPERVISOR_IMAGE: &str = "openshell/supervisor:latest";
4242
/// Default image pull policy for sandbox images.
4343
pub const DEFAULT_IMAGE_PULL_POLICY: &str = "missing";
4444

45-
/// Default Kubernetes namespace for sandbox resources.
46-
pub const DEFAULT_K8S_NAMESPACE: &str = "openshell";
47-
4845
/// CDI device identifier for requesting all NVIDIA GPUs.
4946
pub const CDI_GPU_DEVICE_ALL: &str = "nvidia.com/gpu=all";
5047

crates/openshell-driver-kubernetes/src/config.rs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,12 @@
11
// SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
22
// SPDX-License-Identifier: Apache-2.0
33

4-
use openshell_core::config::{DEFAULT_K8S_NAMESPACE, DEFAULT_SUPERVISOR_IMAGE};
4+
use openshell_core::config::DEFAULT_SUPERVISOR_IMAGE;
55
use serde::{Deserialize, Serialize};
66

7+
/// Default Kubernetes namespace for sandbox resources.
8+
pub const DEFAULT_K8S_NAMESPACE: &str = "openshell";
9+
710
/// How the supervisor binary is delivered into sandbox pods.
811
#[derive(Debug, Clone, Copy, PartialEq, Eq, Default, Serialize, Deserialize)]
912
#[serde(rename_all = "kebab-case")]

0 commit comments

Comments
 (0)