Merge branch 'main' into fix/eou-latency-drift

Author: stevehuang52

.claude/skills/babysit-pr/SKILL.md

@@ -1,28 +1,51 @@
 ---
 name: verify
-description: Run style checks and tests on changed files to verify code quality before committing.
+description: Verify a NeMo Speech change or pull request before commit, push, or review by checking the complete diff, formatting, tests, documentation, and DCO sign-offs. Use when asked to verify changes, prepare a commit or PR, or review a PR's validation and coverage.
 ---
 
-Run verification on the current changes:
+Verify the current change proportionally to its risk. Do not report success for checks that were not run.
+
+1. **Establish the complete scope.** Inspect committed, staged, unstaged, and untracked changes:
 
-1. **Find changed files**:
    ```bash
-   git diff --name-only HEAD
+   git status --short
+   git diff --name-only origin/main...HEAD
+   git diff --name-only
+   git diff --cached --name-only
    ```
-   Also include any files you've been editing in this session.
 
-2. **Style check** on each changed Python file or its parent directory:
+   Replace `origin/main` if the PR targets another branch. Read the full diff and any applicable nested `AGENTS.md` or `CLAUDE.md` files.
+
+2. **Review tests and documentation.** Before running commands, determine whether the change is adequately covered:
+
+   - Require a regression test for a bug fix and focused unit tests for new or changed behavior, including important edge cases. If no test is appropriate, require a concrete explanation.
+   - Check whether changes to public APIs, configuration, CLI behavior, examples, or user workflows are reflected in the relevant documentation. If no documentation update is needed, record why.
+
+3. **Run repository checks.** For staged changes, run:
+
+   ```bash
+   pre-commit run
+   ```
+
+   For committed branch changes, run `pre-commit run --from-ref origin/main --to-ref HEAD`. If pre-commit is unavailable, use `uvx pre-commit` for the same command. Review and stage hook fixes, then rerun until clean. Also run `git diff --check`.
+
+4. **Run the smallest relevant tests.** Prefer focused test files or test names while iterating, then expand to the affected collection when practical:
+
+   - `nemo/collections/asr/` → `uv run pytest tests/collections/asr -m "not pleasefixme"`
+   - `nemo/collections/tts/` → `uv run pytest tests/collections/tts -m "not pleasefixme"`
+   - `nemo/collections/audio/` → `uv run pytest tests/collections/audio -m "not pleasefixme"`
+   - `nemo/collections/speechlm2/` → `uv run pytest tests/collections/speechlm2 -m "not pleasefixme"`
+   - `nemo/collections/common/` → `uv run pytest tests/collections/common -m "not pleasefixme"`
+   - `nemo/core/` → `uv run pytest tests/core -m "not pleasefixme"`
+
+   Add `--with_downloads` only for tests marked as requiring model downloads. Use `--cpu` when supported and a GPU is unavailable. If documentation changed, install its dependencies with `uv sync --locked --group docs` and build it with `uv run make -C docs html`.
+
+5. **Verify commit sign-offs.** Every commit in the PR must have a DCO `Signed-off-by` trailer:
+
    ```bash
-   python setup.py style --scope <path>
+   git log --format='%h %s%n%(trailers:key=Signed-off-by)' origin/main..HEAD
    ```
-   If issues are found, fix them with `--fix` and report what changed.
 
-3. **Run relevant tests** based on which collection was modified:
-   - `nemo/collections/asr/` → `pytest tests/collections/asr --download -m "not pleasefixme" -v --timeout=300`
-   - `nemo/collections/tts/` → `pytest tests/collections/tts --download -m "not pleasefixme" -v --timeout=300`
-   - `nemo/collections/audio/` → `pytest tests/collections/audio --download -m "not pleasefixme" -v --timeout=300`
-   - `nemo/collections/speechlm2/` → `pytest tests/collections/speechlm2 -m "not pleasefixme" -v --timeout=300`
-   - `nemo/collections/common/` → `pytest tests/collections/common -m "not pleasefixme" -v --timeout=300`
-   - `nemo/core/` → `pytest tests/core -m "not pleasefixme" -v --timeout=300`
+   Create commits with `git commit -s`. Add a missing trailer to your own latest commit with `git commit --amend --no-edit -s`; do not rewrite other contributors' commits without authorization.
 
-4. **Report results**: summarize passes and failures. For failures, show relevant error output and suggest fixes.
+6. **Report results.** Summarize the reviewed diff, test-coverage and documentation conclusions, exact commands and outcomes, commit sign-off status, and any skipped checks with reasons. For failures, include the relevant error and a concrete next step.

.claude/skills/verify/SKILL.md

@@ -25,9 +25,8 @@ Add a one line overview of what this PR aims to accomplish.
 
 The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
 
-The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
-To re-run CI remove and add the label again.
-To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
+Trusted PRs run automatically through copy-pr-bot. For an untrusted PR, a maintainer can trigger CI by commenting
+`/ok to test <head-sha>`; repeat this after a new push if the PR remains untrusted.
 
 # Before your PR is "Ready for review"