-
-
Notifications
You must be signed in to change notification settings - Fork 351
Use standard IDisposible implementation #1056
Copy link
Copy link
Open
Labels
breaking-changeRequires user code changes: API removals, behavioral breaks, or pipeline workflow changesRequires user code changes: API removals, behavioral breaks, or pipeline workflow changesenhancementImprovement to an existing feature: better defaults, expanded support, or quality-of-lifeImprovement to an existing feature: better defaults, expanded support, or quality-of-lifescope: apiPublic API surface: types, signatures, properties, interfaces, or serialization contractsPublic API surface: types, signatures, properties, interfaces, or serialization contracts
Milestone
Metadata
Metadata
Assignees
Labels
breaking-changeRequires user code changes: API removals, behavioral breaks, or pipeline workflow changesRequires user code changes: API removals, behavioral breaks, or pipeline workflow changesenhancementImprovement to an existing feature: better defaults, expanded support, or quality-of-lifeImprovement to an existing feature: better defaults, expanded support, or quality-of-lifescope: apiPublic API surface: types, signatures, properties, interfaces, or serialization contractsPublic API surface: types, signatures, properties, interfaces, or serialization contracts
Description
As I'm going through the code base and updating it to close out issues, I'm coming across classes that don't implement
IDisposablein the standard pattern when the class or interfaces are meant to be inherited. The standard implementation should beAs making this change for several classes would be considered a breaking change, I'm using this issue to keep track and as a reminder so they can be included with the next major SemVer release.
Implementations To Fix
SimpleDrawableComponentWorldUpdateSystem