refactor: make trending token query params extensible#8729
Open
sahar-fehri wants to merge 3 commits intomainfrom
Open
refactor: make trending token query params extensible#8729sahar-fehri wants to merge 3 commits intomainfrom
sahar-fehri wants to merge 3 commits intomainfrom
Conversation
sahar-fehri
changed the title
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
10 tasks
sahar-fehri
changed the title
juanmigdr
previously approved these changes
May 7, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 28da12d. Configure here.
Contributor
Prithpal-Sooriya
left a comment
Prithpal-Sooriya
left a comment
There was a problem hiding this comment.
Approved with 1 nit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Makes trending token query params extensible so new API parameters can be added without requiring a core release.
Changes:
Extract TrendingTokensQueryParams type with an index signature to allow arbitrary params to pass through
BREAKING: Rename sortBy => sort parameter in getTrendingTokens to match the actual API parameter name
Update getTrendingTokens and getTrendingTokensURL to use spread operator instead of explicitly destructuring every param
Impact: Mobile can now add new params directly in the getTrendingTokens call without waiting for a core update.
References
Checklist
Note
Medium Risk
Medium risk because it introduces a breaking API change (
sortBy->sort) and alters how query parameters are constructed/passed through to the trending tokens endpoint, which could affect callers and request URLs.Overview
Makes
getTrendingTokens/getTrendingTokensURLaccept an exported, extensibleTrendingTokensQueryParamstype (with an index signature) so arbitrary new API query params can be forwarded without core changes.Introduces a breaking rename from
sortBytosortto match the backend parameter, updates URL-building to spread/forward params (while preserving defaultincludeRwaData/usePriceApiDatabehavior), and expands tests/changelog to cover passthrough params (e.g.,vsCurrency).Reviewed by Cursor Bugbot for commit 6a81d44. Bugbot is set up for automated code reviews on this repo. Configure here.