fix py test setup

Author: patrickwwbutler

misc/python/materialize/mzcompose/services/mysql.py

@@ -14,14 +14,14 @@
 )
 
 
-def create_mysql_server_args(server_id: str, is_master: bool) -> list[str]:
+def create_mysql_server_args(server_id: str, is_master: bool, binlog_full_metadata: str = "full") -> list[str]:
     args = [
         "--log-bin=mysql-bin",
         "--gtid_mode=ON",
         "--enforce_gtid_consistency=ON",
         "--binlog-format=row",
         "--binlog-row-image=full",
-        "--binlog-row-metadata=full",
+        f"--binlog-row-metadata={binlog_full_metadata}",
         f"--server-id={server_id}",
         "--max-connections=500",
     ]

test/mysql-cdc-old-syntax/mzcompose.py

@@ -31,7 +31,7 @@
     CockroachOrPostgresMetadata,
 )
 from materialize.mzcompose.services.minio import Minio
-from materialize.mzcompose.services.mysql import MySql
+from materialize.mzcompose.services.mysql import MySql, create_mysql_server_args
 from materialize.mzcompose.services.mz import Mz
 from materialize.mzcompose.services.test_certs import TestCerts
 from materialize.mzcompose.services.testdrive import Testdrive
@@ -42,21 +42,15 @@
 
 def create_mysql(mysql_version: str) -> MySql:
     return MySql(
-        version=mysql_version, additional_args=["--binlog_row_metadata=MINIMAL"]
+        version=mysql_version, additional_args=create_mysql_server_args(server_id="1", is_master=True, binlog_full_metadata="minimal")
     )
 
 
 def create_mysql_replica(mysql_version: str) -> MySql:
     return MySql(
         name="mysql-replica",
         version=mysql_version,
-        additional_args=[
-            "--gtid_mode=ON",
-            "--enforce_gtid_consistency=ON",
-            "--skip-replica-start",
-            "--server-id=2",
-            "--binlog_row_metadata=MINIMAL",
-        ],
+        additional_args=create_mysql_server_args(server_id="2", is_master=False, binlog_full_metadata="minimal"),
     )