Skip to content

Commit 10b4c82

Browse files
fix py test setup
1 parent bbce9d4 commit 10b4c82

2 files changed

Lines changed: 12 additions & 11 deletions

File tree

misc/python/materialize/mzcompose/services/mysql.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,16 @@
1414
)
1515

1616

17-
def create_mysql_server_args(server_id: str, is_master: bool) -> list[str]:
17+
def create_mysql_server_args(
18+
server_id: str, is_master: bool, binlog_full_metadata: str = "full"
19+
) -> list[str]:
1820
args = [
1921
"--log-bin=mysql-bin",
2022
"--gtid_mode=ON",
2123
"--enforce_gtid_consistency=ON",
2224
"--binlog-format=row",
2325
"--binlog-row-image=full",
24-
"--binlog-row-metadata=full",
26+
f"--binlog-row-metadata={binlog_full_metadata}",
2527
f"--server-id={server_id}",
2628
"--max-connections=500",
2729
]

test/mysql-cdc-old-syntax/mzcompose.py

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
CockroachOrPostgresMetadata,
3232
)
3333
from materialize.mzcompose.services.minio import Minio
34-
from materialize.mzcompose.services.mysql import MySql
34+
from materialize.mzcompose.services.mysql import MySql, create_mysql_server_args
3535
from materialize.mzcompose.services.mz import Mz
3636
from materialize.mzcompose.services.test_certs import TestCerts
3737
from materialize.mzcompose.services.testdrive import Testdrive
@@ -42,21 +42,20 @@
4242

4343
def create_mysql(mysql_version: str) -> MySql:
4444
return MySql(
45-
version=mysql_version, additional_args=["--binlog_row_metadata=MINIMAL"]
45+
version=mysql_version,
46+
additional_args=create_mysql_server_args(
47+
server_id="1", is_master=True, binlog_full_metadata="minimal"
48+
),
4649
)
4750

4851

4952
def create_mysql_replica(mysql_version: str) -> MySql:
5053
return MySql(
5154
name="mysql-replica",
5255
version=mysql_version,
53-
additional_args=[
54-
"--gtid_mode=ON",
55-
"--enforce_gtid_consistency=ON",
56-
"--skip-replica-start",
57-
"--server-id=2",
58-
"--binlog_row_metadata=MINIMAL",
59-
],
56+
additional_args=create_mysql_server_args(
57+
server_id="2", is_master=False, binlog_full_metadata="minimal"
58+
),
6059
)
6160

6261

0 commit comments

Comments
 (0)