chore: include manual fixes (READMEs, director baskets)

Author: markuslf

check-plugins/by-ssh/icingaweb2-module-director/by-ssh.json

@@ -458,7 +458,7 @@
         "3": {
             "varname": "by_ssh_configfile",
             "caption": "By SSH: Configfile",
-            "description": "SSH: Specifies an alternative per-user configuration file. If a configuration file is given on the command line, the system-wide configuration file (`/etc/ssh/ssh_config`) will be ignored. The default for the per-user configuration file is `~/.ssh/config`. If set to `none`, no configuration files will be read.",
+            "description": "SSH: Alternative per-user configuration file. If a configuration file is given on the command line, the system-wide configuration file (`/etc/ssh/ssh_config`) will be ignored. The default for the per-user configuration file is `~/.ssh/config`. If set to `none`, no configuration files will be read.",
             "datatype": "Icinga\\Module\\Director\\DataType\\DataTypeString",
             "format": null,
             "settings": {
@@ -522,7 +522,7 @@
         "9": {
             "varname": "by_ssh_identity",
             "caption": "By SSH: Identity",
-            "description": "SSH: Selects a file from which the identity (private key) for public key authentication is read. You can also specify a public key file to use the corresponding private key that is loaded in ssh-agent(1) when the private key file is not present locally. The default is `~/.ssh/id_dsa`, `~/.ssh/id_ecdsa`, `~/.ssh/id_ecdsa_sk`, `~/.ssh/id_ed25519`, `~/.ssh/id_ed25519_sk` and `~/.ssh/id_rsa`. Identity files may also be specified on a per-host basis in the configuration file. It is possible to have multiple --identity options (and multiple identities specified in configuration files). If no certificates have been explicitly specified by the CertificateFile directive, ssh will also try to load certificate information from the filename obtained by appending `-cert.pub` to identity filenames.",
+            "description": "SSH: File from which the identity (private key) for public key authentication is read. You can also specify a public key file to use the corresponding private key that is loaded in ssh-agent(1) when the private key file is not present locally. The default is `~/.ssh/id_dsa`, `~/.ssh/id_ecdsa`, `~/.ssh/id_ecdsa_sk`, `~/.ssh/id_ed25519`, `~/.ssh/id_ed25519_sk` and `~/.ssh/id_rsa`. Identity files may also be specified on a per-host basis in the configuration file. It is possible to have multiple --identity options (and multiple identities specified in configuration files). If no certificates have been explicitly specified by the CertificateFile directive, ssh will also try to load certificate information from the filename obtained by appending `-cert.pub` to identity filenames.",
             "datatype": "Icinga\\Module\\Director\\DataType\\DataTypeArray",
             "format": null,
             "settings": {

check-plugins/csv-values/icingaweb2-module-director/csv-values.json

@@ -332,7 +332,7 @@
         "7": {
             "varname": "csv_values_filename",
             "caption": "Csv Values: Filename",
-            "description": "Path to CSV file. This is mutually exclusive with -u / --url.",
+            "description": "Path to CSV file. Mutually exclusive with --url.",
             "datatype": "Icinga\\Module\\Director\\DataType\\DataTypeString",
             "format": null,
             "settings": {

check-plugins/dhcp-scope-usage/icingaweb2-module-director/dhcp-scope-usage.json

@@ -400,7 +400,7 @@
         "3": {
             "varname": "dhcp_scope_usage_hostname",
             "caption": "Dhcp Scope Usage: Hostname",
-            "description": "Specifies the DNS name, or IPv4 or IPv6 address, of the target computer that runs the DHCP server service.",
+            "description": "DNS name, IPv4, or IPv6 address of the DHCP server.",
             "datatype": "Icinga\\Module\\Director\\DataType\\DataTypeString",
             "format": null,
             "settings": {
@@ -499,7 +499,7 @@
         "12": {
             "varname": "dhcp_scope_usage_windows_hostname",
             "caption": "Dhcp Scope Usage: Hostname",
-            "description": "Specifies the DNS name, or IPv4 or IPv6 address, of the target computer that runs the DHCP server service.",
+            "description": "DNS name, IPv4, or IPv6 address of the DHCP server.",
             "datatype": "Icinga\\Module\\Director\\DataType\\DataTypeString",
             "format": null,
             "settings": {

check-plugins/network-port-tcp/README.md

@@ -31,10 +31,10 @@ Checks whether a TCP network port is reachable by attempting to establish a conn
 
 ```text
 Traceback (most recent call last):
-  File "/home/markusfrei/git/linuxfabrik/github/monitoring-plugins/check-plugins/network-port-tcp/network-port-tcp", line 141, in 'module'
+  File "/home/markusfrei/git/linuxfabrik/github/monitoring-plugins/check-plugins/network-port-tcp/network-port-tcp", line 140, in 'module'
     main()
     ~~~~^^
-  File "/home/markusfrei/git/linuxfabrik/github/monitoring-plugins/check-plugins/network-port-tcp/network-port-tcp", line 105, in main
+  File "/home/markusfrei/git/linuxfabrik/github/monitoring-plugins/check-plugins/network-port-tcp/network-port-tcp", line 104, in main
     args = parse_args()
   File "/home/markusfrei/git/linuxfabrik/github/monitoring-plugins/check-plugins/network-port-tcp/network-port-tcp", line 72, in parse_args
     help=lib.args.help('--severity') + ' Default: %(default)s',

check-plugins/systemd-unit/README.md

@@ -33,16 +33,58 @@ Checks the state of a specific systemd unit (service, socket, device, mount, tim
 ## Help
 
 ```text
-Traceback (most recent call last):
-  File "/home/markusfrei/git/linuxfabrik/github/monitoring-plugins/check-plugins/systemd-unit/systemd-unit", line 317, in 'module'
-    main()
-    ~~~~^^
-  File "/home/markusfrei/git/linuxfabrik/github/monitoring-plugins/check-plugins/systemd-unit/systemd-unit", line 215, in main
-    args = parse_args()
-  File "/home/markusfrei/git/linuxfabrik/github/monitoring-plugins/check-plugins/systemd-unit/systemd-unit", line 102, in parse_args
-    help=lib.args.help('--severity') + ' Default: %(default)s',
-         ^^^^^^^^
-AttributeError: module 'lib' has no attribute 'args'
+usage: systemd-unit [-h] [-V]
+                    [--activestate {None,activating,active,deactivating,failed,inactive}]
+                    [--loadstate {None,activating,active,deactivating,failed,inactive,loaded,maintenance,masked,not-found,reloading}]
+                    [--machine MACHINE] [--severity {warn,crit}]
+                    [--substate {None,abandoned,activating,activating-done,active,auto-restart,cleaning,condition,deactivating,deactivating-sigkill,deactivating-sigterm,dead,elapsed,exited,failed,final-sigkill,final-sigterm,final-watchdog,listening,mounted,mounting,mounting-done,plugged,reload,remounting,remounting-sigkill,remounting-sigterm,running,start,start-chown,start-post,start-pre,stop,stop-post,stop-pre,stop-pre-sigkill,stop-pre-sigterm,stop-sigkill,stop-sigterm,stop-watchdog,tentative,unmounting,unmounting-sigkill,unmounting-sigterm,waiting}]
+                    --unit UNIT
+                    [--unitfilestate {None,bad,disabled,empty,enabled,enabled-runtime,generated,indirect,linked,linked-runtime,masked,masked-runtime,static,transient}]
+                    [--user]
+
+Checks the state of a specific systemd unit (service, socket, device, mount,
+timer, scope, etc.) via systemctl. Verifies the active state, sub-state, load
+state, and unit file state against expected values. Alerts when the unit is
+not in the expected state. Requires root or sudo.
+
+options:
+  -h, --help            show this help message and exit
+  -V, --version         show program's version number and exit
+  --activestate {None,activating,active,deactivating,failed,inactive}
+                        Expected systemd ActiveState (high-level unit
+                        activation state, i.e. generalization of SUB). Can be
+                        specified multiple times. If omitted or set to "None",
+                        the unit's active state will not be checked.
+  --loadstate {None,activating,active,deactivating,failed,inactive,loaded,maintenance,masked,not-found,reloading}
+                        Expected systemd LoadState, reflecting whether the
+                        unit definition was properly loaded. If omitted or set
+                        to "None", the unit's load state will not be checked.
+                        Default: loaded
+  --machine MACHINE     Execute operation on a local container. Specify a
+                        container name to connect to, optionally prefixed by a
+                        user name and a separating "@" character. The special
+                        string ".host" connects to the local system (useful
+                        for reaching a specific user's bus: `--user
+                        --machine=lennart@.host`). Without "@" syntax, the
+                        connection is made as root. With "@" syntax, either
+                        side may be omitted (but not both), defaulting to the
+                        local user name and ".host".
+  --severity {warn,crit}
+                        Severity for alerting. Default: warn
+  --substate {None,abandoned,activating,activating-done,active,auto-restart,cleaning,condition,deactivating,deactivating-sigkill,deactivating-sigterm,dead,elapsed,exited,failed,final-sigkill,final-sigterm,final-watchdog,listening,mounted,mounting,mounting-done,plugged,reload,remounting,remounting-sigkill,remounting-sigterm,running,start,start-chown,start-post,start-pre,stop,stop-post,stop-pre,stop-pre-sigkill,stop-pre-sigterm,stop-sigkill,stop-sigterm,stop-watchdog,tentative,unmounting,unmounting-sigkill,unmounting-sigterm,waiting}
+                        Expected systemd SubState (low-level unit activation
+                        state; values depend on unit type). Can be specified
+                        multiple times. If omitted or set to "None", the
+                        unit's substate will not be checked.
+  --unit UNIT           Systemd unit name to check (service, timer, mount,
+                        etc.). Required. Example: `--unit sshd.service`.
+  --unitfilestate {None,bad,disabled,empty,enabled,enabled-runtime,generated,indirect,linked,linked-runtime,masked,masked-runtime,static,transient}
+                        Expected systemd UnitFileState. If set to "empty",
+                        checks exactly for `UnitFileState=""`. If omitted or
+                        set to "None", the unit's unit-file state will not be
+                        checked.
+  --user                Talk to the service manager of the calling user rather
+                        than the service manager of the system.
 ```
 
 

check-plugins/xca-cert/icingaweb2-module-director/xca-cert.json

@@ -133,7 +133,7 @@
         "2": {
             "varname": "xca_cert_defaults_file",
             "caption": "XCA Cert: Defaults File",
-            "description": "Specifies a cnf file to read parameters like user, host and password from (for MySQL/MariaDB cnf-style files). Example: `/var/spool/icinga2/.my.cnf`.",
+            "description": "Specifies a cnf file to read parameters like user, host and password from (for MySQL/MariaDB cnf-style files). (for MySQL/MariaDB cnf-style files). Example: `/var/spool/icinga2/.my.cnf`.",
             "datatype": "Icinga\\Module\\Director\\DataType\\DataTypeString",
             "format": null,
             "settings": {