test: add Batch 2 mysql-* container tests and fix uptime=0 crashes

Add happy-path container integration tests for 11 mysql-* plugins
(mysql-innodb-log-waits, mysql-joins, mysql-open-files,
mysql-slow-queries, mysql-sorts, mysql-table-cache,
mysql-table-definition-cache, mysql-table-locks, mysql-temp-tables,
mysql-thread-cache, mysql-traffic). Each test iterates over the
MARIADB_LTS_IMAGES matrix from lib.lftest, spanning MariaDB 10.6,
10.11, 11.4 and 11.8 across sclorg and upstream images, and uses
the lib.lftest.run_mariadb() helper to hide the startup and
.my.cnf boilerplate. mysql-table-cache pins the expected WARN
state on a cold table cache because a freshly booted server
legitimately trips the hit-rate alert and the test exists to keep
that behavior in place.

Fix two crashes exposed by the new tests:

* mysql-joins: ZeroDivisionError in the joins-per-day calculation
  when `SHOW GLOBAL STATUS LIKE 'Uptime'` returns 0 in the first
  second after a server boot.
* mysql-traffic: ZeroDivisionError in the qps calculation for the
  same reason, on top of the AttributeError crash caused by a
  missing `import lib.args` (the latter was already picked up by
  the ruff-format sweep in d60210d but appears here in the
  CHANGELOG because this commit pins it as intentional).

Both plugins now clamp Uptime to a minimum of 1 second.

Author: markuslf

CHANGELOG.md

@@ -150,8 +150,10 @@ Monitoring Plugins:
 * keycloak-stats: fix incorrect symlink for lib
 * keycloak-version: detect the Keycloak version reliably even if the format of `/opt/keycloak/version.txt` changes, and fall back to the API when the file cannot be parsed ([#1070](https://github.com/Linuxfabrik/monitoring-plugins/issues/1070))
 * logfile: fix `OverflowError` when inode exceeds SQLite INTEGER range on Windows/NTFS ([#1035](https://github.com/Linuxfabrik/monitoring-plugins/issues/1035))
+* mysql-joins: fix `ZeroDivisionError` crash on a freshly booted server where `SHOW GLOBAL STATUS LIKE 'Uptime'` can return 0 in the first second after startup
 * mysql-memory: fix a crash in the "other process memory" calculation on hosts running psutil older than 5.3.0 ([#1070](https://github.com/Linuxfabrik/monitoring-plugins/issues/1070))
 * mysql-table-locks: fix the "X immediate / Y locks" summary - the "Y" value now correctly shows the total lock count (immediate + waited) instead of the immediate count twice ([#1070](https://github.com/Linuxfabrik/monitoring-plugins/issues/1070))
+* mysql-traffic: fix `AttributeError` crash caused by a missing `lib.args` import, and fix `ZeroDivisionError` crash on a freshly booted server where `SHOW GLOBAL STATUS LIKE 'Uptime'` can return 0 in the first second after startup
 * needs-restarting: the "Running Kernel X != Installed Kernel Y" line now shows up on Debian-based systems when `needrestart` reports a pending kernel upgrade
 * network-connections: the plugin now exits with the correct WARN/CRIT state when any threshold is violated; previously it always reported OK regardless of the loop's accumulated state ([#1070](https://github.com/Linuxfabrik/monitoring-plugins/issues/1070))
 * nextcloud-security-scan: only trigger a rescan for scans that are actually in the past; future-dated scans caused by clock skew no longer trigger an unnecessary rescan ([#1070](https://github.com/Linuxfabrik/monitoring-plugins/issues/1070))

check-plugins/mysql-innodb-log-waits/unit-test/run

@@ -0,0 +1,72 @@
+#!/usr/bin/env python3
+# -*- coding: utf-8; py-indent-offset: 4 -*-
+#
+# Author:  Linuxfabrik GmbH, Zurich, Switzerland
+# Contact: info (at) linuxfabrik (dot) ch
+#          https://www.linuxfabrik.ch/
+# License: The Unlicense, see LICENSE file.
+
+# https://github.com/Linuxfabrik/monitoring-plugins/blob/main/CONTRIBUTING.md
+
+"""Integration tests for the mysql-innodb-log-waits check plugin.
+
+The plugin opens a real `pymysql` connection and reads
+`innodb_log_waits` / `innodb_log_writes` from `SHOW GLOBAL STATUS`,
+so a static fixture cannot drive it - we spin up an actual
+MariaDB server and let the plugin talk to it over TCP.
+
+Per CONTRIBUTING's "Combine container tests with fixtures" rule,
+this file holds only the happy-path integration test. A freshly
+booted, idle MariaDB has zero log waits, which is STATE_OK with
+the plugin's defaults.
+
+Runs against the current MariaDB LTS releases
+(`lib.lftest.MARIADB_LTS_IMAGES`).
+
+Requirements:
+- podman (or docker) with a reachable socket
+- `pip install testcontainers`
+- `tools/run-unit-tests` auto-sets `CONTAINER_HOST` and
+  `TESTCONTAINERS_RYUK_DISABLED`
+"""
+
+import os
+import subprocess
+import sys
+import unittest
+
+sys.path.insert(0, '..')
+
+import lib.lftest
+from lib.globals import STATE_OK
+
+IMAGES = lib.lftest.MARIADB_LTS_IMAGES
+
+
+class TestCheck(unittest.TestCase):
+    pass
+
+
+def _check_image(test, image_pair):
+    image, label = image_pair
+    print(f'\n=== Testing {label} ({image}) ===', flush=True)
+    with lib.lftest.run_mariadb(image) as (_container, defaults_file):
+        cmd = [
+            'python3', '../mysql-innodb-log-waits',
+            f'--defaults-file={defaults_file}',
+        ]
+        print(f'Run plugin: {" ".join(cmd)}', flush=True)
+        result = subprocess.run(
+            cmd,
+            cwd=os.path.dirname(os.path.abspath(__file__)),
+            capture_output=True,
+            text=True,
+        )
+        combined = result.stdout + result.stderr
+        print(f'Script output:\n{combined.strip()}', flush=True)
+
+        test.assertEqual(result.returncode, STATE_OK)
+        test.assertIn("|'mysql_", combined)
+
+
+lib.lftest.attach_each(TestCheck, IMAGES, _check_image, id_func=lambda it: it[1])

check-plugins/mysql-joins/mysql-joins

@@ -21,7 +21,7 @@ import lib.txt
 from lib.globals import STATE_OK, STATE_UNKNOWN, STATE_WARN
 
 __author__ = 'Linuxfabrik GmbH, Zurich/Switzerland'
-__version__ = '2026040801'
+__version__ = '2026041301'
 
 DESCRIPTION = """Checks the rate of joins executed without indexes in MySQL/MariaDB. A high rate of
 full joins indicates missing indexes and can severely impact query performance.
@@ -137,8 +137,13 @@ def main():
     mycalc['joins_without_indexes'] = int(mystat['Select_range_check']) + int(
         mystat['Select_full_join']
     )
+    # Clamp Uptime to a minimum of 1 second so the per-day rate is
+    # well-defined on a freshly booted server where
+    # `SHOW GLOBAL STATUS LIKE 'Uptime'` can legitimately return 0 in
+    # the first second after startup.
+    uptime = max(int(mystat.get('Uptime') or 0), 1)
     mycalc['joins_without_indexes_per_day'] = round(
-        mycalc['joins_without_indexes'] / (int(mystat['Uptime']) / 86400), 1
+        mycalc['joins_without_indexes'] / (uptime / 86400), 1
     )
 
     # Joins

check-plugins/mysql-joins/unit-test/run

@@ -0,0 +1,76 @@
+#!/usr/bin/env python3
+# -*- coding: utf-8; py-indent-offset: 4 -*-
+#
+# Author:  Linuxfabrik GmbH, Zurich, Switzerland
+# Contact: info (at) linuxfabrik (dot) ch
+#          https://www.linuxfabrik.ch/
+# License: The Unlicense, see LICENSE file.
+
+# https://github.com/Linuxfabrik/monitoring-plugins/blob/main/CONTRIBUTING.md
+
+"""Integration tests for the mysql-joins check plugin.
+
+The plugin opens a real `pymysql` connection and reads join
+counters from `SHOW GLOBAL STATUS`, so a static fixture cannot
+drive it - we spin up an actual MariaDB server and let the plugin
+talk to it over TCP.
+
+Per CONTRIBUTING's "Combine container tests with fixtures" rule,
+this file holds only the happy-path integration test. A freshly
+booted, idle MariaDB has near-zero join counters, which is
+STATE_OK with the plugin's defaults.
+
+Runs against the current MariaDB LTS releases
+(`lib.lftest.MARIADB_LTS_IMAGES`).
+
+Requirements:
+- podman (or docker) with a reachable socket
+- `pip install testcontainers`
+- `tools/run-unit-tests` auto-sets `CONTAINER_HOST` and
+  `TESTCONTAINERS_RYUK_DISABLED`
+"""
+
+import os
+import subprocess
+import sys
+import unittest
+
+sys.path.insert(0, '..')
+
+import lib.lftest
+from lib.globals import STATE_OK
+
+IMAGES = lib.lftest.MARIADB_LTS_IMAGES
+
+
+class TestCheck(unittest.TestCase):
+    pass
+
+
+def _check_image(test, image_pair):
+    image, label = image_pair
+    print(f'\n=== Testing {label} ({image}) ===', flush=True)
+    with lib.lftest.run_mariadb(image) as (_container, defaults_file):
+        cmd = [
+            'python3', '../mysql-joins',
+            f'--defaults-file={defaults_file}',
+        ]
+        print(f'Run plugin: {" ".join(cmd)}', flush=True)
+        result = subprocess.run(
+            cmd,
+            cwd=os.path.dirname(os.path.abspath(__file__)),
+            capture_output=True,
+            text=True,
+        )
+        combined = result.stdout + result.stderr
+        print(f'Script output:\n{combined.strip()}', flush=True)
+
+        test.assertEqual(result.returncode, STATE_OK)
+        test.assertIn("|'mysql_", combined)
+
+
+lib.lftest.attach_each(TestCheck, IMAGES, _check_image, id_func=lambda it: it[1])
+
+
+if __name__ == '__main__':
+    unittest.main()

check-plugins/mysql-open-files/unit-test/run

@@ -0,0 +1,78 @@
+#!/usr/bin/env python3
+# -*- coding: utf-8; py-indent-offset: 4 -*-
+#
+# Author:  Linuxfabrik GmbH, Zurich, Switzerland
+# Contact: info (at) linuxfabrik (dot) ch
+#          https://www.linuxfabrik.ch/
+# License: The Unlicense, see LICENSE file.
+
+# https://github.com/Linuxfabrik/monitoring-plugins/blob/main/CONTRIBUTING.md
+
+"""Integration tests for the mysql-open-files check plugin.
+
+The plugin opens a real `pymysql` connection and reads
+`open_files` from `SHOW GLOBAL STATUS` against the
+`open_files_limit` variable, so a static fixture cannot drive it
+- we spin up an actual MariaDB server and let the plugin talk to
+it over TCP.
+
+Per CONTRIBUTING's "Combine container tests with fixtures" rule,
+this file holds only the happy-path integration test. A freshly
+booted MariaDB holds only a few file descriptors against a
+`open_files_limit` of 1024+, which is STATE_OK with the plugin's
+defaults.
+
+Runs against the current MariaDB LTS releases
+(`lib.lftest.MARIADB_LTS_IMAGES`).
+
+Requirements:
+- podman (or docker) with a reachable socket
+- `pip install testcontainers`
+- `tools/run-unit-tests` auto-sets `CONTAINER_HOST` and
+  `TESTCONTAINERS_RYUK_DISABLED`
+"""
+
+import os
+import subprocess
+import sys
+import unittest
+
+sys.path.insert(0, '..')
+
+import lib.lftest
+from lib.globals import STATE_OK
+
+IMAGES = lib.lftest.MARIADB_LTS_IMAGES
+
+
+class TestCheck(unittest.TestCase):
+    pass
+
+
+def _check_image(test, image_pair):
+    image, label = image_pair
+    print(f'\n=== Testing {label} ({image}) ===', flush=True)
+    with lib.lftest.run_mariadb(image) as (_container, defaults_file):
+        cmd = [
+            'python3', '../mysql-open-files',
+            f'--defaults-file={defaults_file}',
+        ]
+        print(f'Run plugin: {" ".join(cmd)}', flush=True)
+        result = subprocess.run(
+            cmd,
+            cwd=os.path.dirname(os.path.abspath(__file__)),
+            capture_output=True,
+            text=True,
+        )
+        combined = result.stdout + result.stderr
+        print(f'Script output:\n{combined.strip()}', flush=True)
+
+        test.assertEqual(result.returncode, STATE_OK)
+        test.assertIn("|'mysql_", combined)
+
+
+lib.lftest.attach_each(TestCheck, IMAGES, _check_image, id_func=lambda it: it[1])
+
+
+if __name__ == '__main__':
+    unittest.main()

check-plugins/mysql-slow-queries/unit-test/run

@@ -0,0 +1,76 @@
+#!/usr/bin/env python3
+# -*- coding: utf-8; py-indent-offset: 4 -*-
+#
+# Author:  Linuxfabrik GmbH, Zurich, Switzerland
+# Contact: info (at) linuxfabrik (dot) ch
+#          https://www.linuxfabrik.ch/
+# License: The Unlicense, see LICENSE file.
+
+# https://github.com/Linuxfabrik/monitoring-plugins/blob/main/CONTRIBUTING.md
+
+"""Integration tests for the mysql-slow-queries check plugin.
+
+The plugin opens a real `pymysql` connection and reads
+`slow_queries` / `questions` from `SHOW GLOBAL STATUS`, so a
+static fixture cannot drive it - we spin up an actual MariaDB
+server and let the plugin talk to it over TCP.
+
+Per CONTRIBUTING's "Combine container tests with fixtures" rule,
+this file holds only the happy-path integration test. A freshly
+booted, idle MariaDB has zero slow queries, which is STATE_OK
+with the plugin's defaults.
+
+Runs against the current MariaDB LTS releases
+(`lib.lftest.MARIADB_LTS_IMAGES`).
+
+Requirements:
+- podman (or docker) with a reachable socket
+- `pip install testcontainers`
+- `tools/run-unit-tests` auto-sets `CONTAINER_HOST` and
+  `TESTCONTAINERS_RYUK_DISABLED`
+"""
+
+import os
+import subprocess
+import sys
+import unittest
+
+sys.path.insert(0, '..')
+
+import lib.lftest
+from lib.globals import STATE_OK
+
+IMAGES = lib.lftest.MARIADB_LTS_IMAGES
+
+
+class TestCheck(unittest.TestCase):
+    pass
+
+
+def _check_image(test, image_pair):
+    image, label = image_pair
+    print(f'\n=== Testing {label} ({image}) ===', flush=True)
+    with lib.lftest.run_mariadb(image) as (_container, defaults_file):
+        cmd = [
+            'python3', '../mysql-slow-queries',
+            f'--defaults-file={defaults_file}',
+        ]
+        print(f'Run plugin: {" ".join(cmd)}', flush=True)
+        result = subprocess.run(
+            cmd,
+            cwd=os.path.dirname(os.path.abspath(__file__)),
+            capture_output=True,
+            text=True,
+        )
+        combined = result.stdout + result.stderr
+        print(f'Script output:\n{combined.strip()}', flush=True)
+
+        test.assertEqual(result.returncode, STATE_OK)
+        test.assertIn("|'mysql_", combined)
+
+
+lib.lftest.attach_each(TestCheck, IMAGES, _check_image, id_func=lambda it: it[1])
+
+
+if __name__ == '__main__':
+    unittest.main()