Skip to content

Commit 264be26

Browse files
committed
Fix CI workflows: Add SentencePiece dependency
All workflows were failing with: CMake Error: Could not find SentencePiece. Install via: brew install sentencepiece Changes: - Added sentencepiece to all brew install commands across workflows - Updated ci.yml (cpp-build and cpp-tests jobs) - Updated release.yml (build-app job) - Updated daemon-test.yml (all 4 jobs) - Updated README.md to document SentencePiece requirement SentencePiece is required by CMake build for tokenization support. It's available via Homebrew on GitHub's macOS runners. This fixes the build error preventing Metal kernel compilation, C++ builds, and all subsequent tests from running.
1 parent 32abbab commit 264be26

4 files changed

Lines changed: 11 additions & 7 deletions

File tree

.github/workflows/README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ This directory contains GitHub Actions workflows for continuous integration, tes
2727
- macOS 14 (Sonoma) runner with Apple Silicon
2828
- Xcode with Metal compiler
2929
- MLX framework via Homebrew
30+
- SentencePiece via Homebrew (for tokenization)
3031

3132
**Example:** Every push to a branch automatically:
3233
- Compiles Metal kernels
@@ -61,6 +62,7 @@ This directory contains GitHub Actions workflows for continuous integration, tes
6162
**Requirements:**
6263
- macOS 14 runner
6364
- Node.js for UI build
65+
- SentencePiece for tokenization
6466
- XcodeGen (optional, for project generation)
6567

6668
**Usage:**
@@ -98,6 +100,7 @@ git push origin v1.0.0
98100

99101
**Requirements:**
100102
- macOS 14 runner
103+
- MLX and SentencePiece via Homebrew
101104
- ApacheBench for stress testing
102105

103106
**Example Tests:**
@@ -200,6 +203,7 @@ curl http://127.0.0.1:11434/health
200203
- Check CMake configuration in `CMakeLists.txt`
201204
- Verify dependencies: `brew list`
202205
- Check MLX installation: `python -c "import mlx"`
206+
- Ensure SentencePiece is installed: `brew list sentencepiece`
203207

204208
**Daemon fails to start:**
205209
- Check for port conflicts: `lsof -i :11434`

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ jobs:
5454

5555
- name: Install dependencies
5656
run: |
57-
brew install cmake ninja mlx
57+
brew install cmake ninja mlx sentencepiece
5858
5959
- name: Download Metal libraries
6060
uses: actions/download-artifact@v4
@@ -101,7 +101,7 @@ jobs:
101101

102102
- name: Install dependencies
103103
run: |
104-
brew install mlx
104+
brew install mlx sentencepiece
105105
106106
- name: Download Metal libraries
107107
uses: actions/download-artifact@v4

.github/workflows/daemon-test.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ jobs:
2929

3030
- name: Install dependencies
3131
run: |
32-
brew install cmake ninja mlx
32+
brew install cmake ninja mlx sentencepiece
3333
3434
- name: Set up Conda
3535
uses: conda-incubator/setup-miniconda@v3
@@ -91,7 +91,7 @@ jobs:
9191

9292
- name: Install dependencies
9393
run: |
94-
brew install mlx
94+
brew install mlx sentencepiece
9595
9696
- name: Download daemon artifacts
9797
uses: actions/download-artifact@v4
@@ -143,7 +143,7 @@ jobs:
143143

144144
- name: Install dependencies
145145
run: |
146-
brew install mlx
146+
brew install mlx sentencepiece
147147
148148
- name: Download daemon artifacts
149149
uses: actions/download-artifact@v4
@@ -260,7 +260,7 @@ jobs:
260260

261261
- name: Install dependencies
262262
run: |
263-
brew install mlx apache-bench
263+
brew install mlx sentencepiece apache-bench
264264
265265
- name: Download daemon artifacts
266266
uses: actions/download-artifact@v4

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ jobs:
4040
4141
- name: Install dependencies
4242
run: |
43-
brew install cmake ninja mlx node
43+
brew install cmake ninja mlx sentencepiece node
4444
4545
- name: Set up Conda
4646
uses: conda-incubator/setup-miniconda@v3

0 commit comments

Comments
 (0)