You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
make WorkoutSession and WorkoutDto one class
Whats the difference between WorkoutSession and WorkoutDto? Are both needed? If so, why?
ok I understand 🤔 but I think this is kinda confusing. I would merge these 2 together because it represents the same object but the session have just a few extra states.
That way consumer of this object (or within the app) you firstly check in what State is the WorkoutDto and based on that you can/cant read it's properties.
If you are worried that consumers of this object would call e.g. Resume, End and other methods, then make them internal(only this library can call them).
That way you simplify working with this object....because there will be only one. And it will be uniform.
You are saying I cant do something like GetActiveSession in those libraries...even though I started that session in the app before?
add possibility to write records #6 (comment)
I just wanted to add a note in case you all weren't aware.
The DataOrigin on Android is not writeable.
You can set it and send it but Android will always overwrite it with the package name of the app that is writing the data. I just ran a test trying to write "com.fitbit.FitbitMobile" in an attempt to spoof steps from a fitbit device but the origin when read back out was my app's package name that inserted the data.
Followup for:
#6
is null preference editorcofig
add possibility to write records #6 (comment)
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0041
check if all generic extension methods are made internal
add possibility to write records #6 (comment)
prefer [] instead of new List<>()
add possibility to write records #6 (comment)
remove temp vars
add possibility to write records #6 (comment)
update android lib to latest stable
review for loop
add possibility to write records #6 (comment)
make WorkoutSession and WorkoutDto one class
Whats the difference between WorkoutSession and WorkoutDto? Are both needed? If so, why?
ok I understand 🤔 but I think this is kinda confusing. I would merge these 2 together because it represents the same object but the session have just a few extra states.
That way consumer of this object (or within the app) you firstly check in what State is the WorkoutDto and based on that you can/cant read it's properties.
If you are worried that consumers of this object would call e.g. Resume, End and other methods, then make them internal(only this library can call them).
That way you simplify working with this object....because there will be only one. And it will be uniform.
You are saying I cant do something like GetActiveSession in those libraries...even though I started that session in the app before?
Reflection
add possibility to write records #6 (comment)
extract reflection
add possibility to write records #6 (comment)
add possibility to write records #6 (comment)
I just wanted to add a note in case you all weren't aware.
The DataOrigin on Android is not writeable.
You can set it and send it but Android will always overwrite it with the package name of the app that is writing the data. I just ran a test trying to write "com.fitbit.FitbitMobile" in an attempt to spoof steps from a fitbit device but the origin when read back out was my app's package name that inserted the data.
get rid of state-fullness of WorkoutSession