style: fix clippy warnings

Author: MilesCranmer

src/bin/jlpkg.rs

@@ -1,5 +1,5 @@
 use anyhow::Result;
-use clap::{CommandFactory, Parser, Subcommand, ValueEnum};
+use clap::{Parser, Subcommand, ValueEnum};
 use juliaup::cli::CompletionShell;
 
 // IMPORTANT: This CLI wrapper for Julia's Pkg does NOT include the following REPL-only commands:
@@ -380,7 +380,7 @@ fn parse_arguments(args: &[String]) -> ParsedArgs {
 
 /// Show help message and exit
 fn show_help() -> Result<std::process::ExitCode> {
-    match Cli::try_parse_from(&["jlpkg", "--help"]) {
+    match Cli::try_parse_from(["jlpkg", "--help"]) {
         Ok(_) => {}
         Err(e) => {
             // Clap returns an error for --help but prints to stderr

tests/jlpkg_parity_test.rs

@@ -53,7 +53,7 @@ fn test_status_parity() {
     // Run with julia
     let julia_output = julia()
         .current_dir(&temp_dir)
-        .args(&["--project=.", "--startup-file=no", "--threads=auto", "-e"])
+        .args(["--project=.", "--startup-file=no", "--threads=auto", "-e"])
         .arg("using Pkg; isdefined(Pkg.REPLMode, :PRINTED_REPL_WARNING) && (Pkg.REPLMode.PRINTED_REPL_WARNING[] = true); Pkg.REPLMode.pkgstr(\"status\")")
         .output()
         .unwrap();
@@ -89,17 +89,17 @@ fn test_help_subcommands() {
 
     for cmd in subcommands {
         // Test basic help
-        jlpkg().args(&[cmd, "--help"]).assert().success();
+        jlpkg().args([cmd, "--help"]).assert().success();
 
         // Test help with Julia flags before
         jlpkg()
-            .args(&["--project=/tmp", cmd, "--help"])
+            .args(["--project=/tmp", cmd, "--help"])
             .assert()
             .success();
 
         // Test help with multiple Julia flags
         jlpkg()
-            .args(&["--threads=4", "--color=no", cmd, "--help"])
+            .args(["--threads=4", "--color=no", cmd, "--help"])
             .assert()
             .success();
     }