Skip to content

[nanoPOCL] Re-enable error reporting in 1.12+ - #681

Merged
vchuravy merged 1 commit into
mainfrom
error1.12
Jun 9, 2026
Merged

[nanoPOCL] Re-enable error reporting in 1.12+#681
vchuravy merged 1 commit into
mainfrom
error1.12

Conversation

@christiangnrd

Copy link
Copy Markdown
Member

Partial revert of #674 but keeps the typo fixes

@github-actions

github-actions Bot commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

Benchmark Results

main 08522a2... main / 08522a2...
saxpy/default/Float32/1024 0.0399 ± 0.021 ms 0.0325 ± 0.022 ms 1.23 ± 1
saxpy/default/Float32/1048576 0.374 ± 0.038 ms 0.376 ± 0.036 ms 0.993 ± 0.14
saxpy/default/Float32/16384 0.051 ± 0.023 ms 0.0488 ± 0.023 ms 1.04 ± 0.68
saxpy/default/Float32/2048 0.0486 ± 0.018 ms 0.0403 ± 0.021 ms 1.21 ± 0.78
saxpy/default/Float32/256 31.1 ± 18 μs 25.6 ± 6.1 μs 1.22 ± 0.77
saxpy/default/Float32/262144 0.134 ± 0.023 ms 0.136 ± 0.025 ms 0.99 ± 0.25
saxpy/default/Float32/32768 0.0545 ± 0.025 ms 0.052 ± 0.023 ms 1.05 ± 0.66
saxpy/default/Float32/4096 0.0515 ± 0.022 ms 0.0468 ± 0.021 ms 1.1 ± 0.68
saxpy/default/Float32/512 0.033 ± 0.02 ms 27 ± 11 μs 1.22 ± 0.9
saxpy/default/Float32/64 29.3 ± 14 μs 25.5 ± 7.3 μs 1.15 ± 0.65
saxpy/default/Float32/65536 0.0693 ± 0.025 ms 0.0666 ± 0.023 ms 1.04 ± 0.52
saxpy/default/Float64/1024 0.0475 ± 0.02 ms 0.0365 ± 0.024 ms 1.3 ± 1
saxpy/default/Float64/1048576 0.721 ± 0.072 ms 0.706 ± 0.056 ms 1.02 ± 0.13
saxpy/default/Float64/16384 0.0562 ± 0.027 ms 0.0572 ± 0.028 ms 0.981 ± 0.67
saxpy/default/Float64/2048 0.0498 ± 0.018 ms 0.0449 ± 0.022 ms 1.11 ± 0.68
saxpy/default/Float64/256 30.7 ± 17 μs 26.1 ± 6.9 μs 1.18 ± 0.71
saxpy/default/Float64/262144 0.21 ± 0.02 ms 0.212 ± 0.02 ms 0.991 ± 0.13
saxpy/default/Float64/32768 0.0676 ± 0.028 ms 0.0644 ± 0.028 ms 1.05 ± 0.63
saxpy/default/Float64/4096 0.0525 ± 0.019 ms 0.0518 ± 0.021 ms 1.01 ± 0.55
saxpy/default/Float64/512 0.0352 ± 0.02 ms 26.4 ± 10 μs 1.33 ± 0.91
saxpy/default/Float64/64 29.1 ± 15 μs 25.1 ± 2.7 μs 1.16 ± 0.6
saxpy/default/Float64/65536 0.0886 ± 0.025 ms 0.0858 ± 0.025 ms 1.03 ± 0.42
saxpy/static workgroup=(1024,)/Float32/1024 0.0364 ± 0.02 ms 27.6 ± 14 μs 1.32 ± 1
saxpy/static workgroup=(1024,)/Float32/1048576 0.368 ± 0.039 ms 0.366 ± 0.034 ms 1.01 ± 0.14
saxpy/static workgroup=(1024,)/Float32/16384 0.0475 ± 0.023 ms 0.045 ± 0.022 ms 1.05 ± 0.74
saxpy/static workgroup=(1024,)/Float32/2048 0.047 ± 0.018 ms 0.0401 ± 0.02 ms 1.17 ± 0.74
saxpy/static workgroup=(1024,)/Float32/256 0.0328 ± 0.018 ms 26.5 ± 9.1 μs 1.24 ± 0.79
saxpy/static workgroup=(1024,)/Float32/262144 0.132 ± 0.025 ms 0.132 ± 0.025 ms 1 ± 0.26
saxpy/static workgroup=(1024,)/Float32/32768 0.0503 ± 0.024 ms 0.0489 ± 0.023 ms 1.03 ± 0.68
saxpy/static workgroup=(1024,)/Float32/4096 0.0507 ± 0.018 ms 0.0476 ± 0.019 ms 1.06 ± 0.57
saxpy/static workgroup=(1024,)/Float32/512 0.0341 ± 0.019 ms 26.8 ± 11 μs 1.27 ± 0.88
saxpy/static workgroup=(1024,)/Float32/64 30.7 ± 16 μs 24.8 ± 7.5 μs 1.24 ± 0.73
saxpy/static workgroup=(1024,)/Float32/65536 0.064 ± 0.023 ms 0.0608 ± 0.022 ms 1.05 ± 0.54
saxpy/static workgroup=(1024,)/Float64/1024 0.0454 ± 0.019 ms 0.0319 ± 0.024 ms 1.42 ± 1.2
saxpy/static workgroup=(1024,)/Float64/1048576 0.721 ± 0.061 ms 0.714 ± 0.067 ms 1.01 ± 0.13
saxpy/static workgroup=(1024,)/Float64/16384 0.0516 ± 0.025 ms 0.0529 ± 0.025 ms 0.975 ± 0.66
saxpy/static workgroup=(1024,)/Float64/2048 0.0483 ± 0.019 ms 0.0416 ± 0.021 ms 1.16 ± 0.73
saxpy/static workgroup=(1024,)/Float64/256 0.0348 ± 0.018 ms 27.8 ± 9.4 μs 1.25 ± 0.79
saxpy/static workgroup=(1024,)/Float64/262144 0.207 ± 0.02 ms 0.206 ± 0.019 ms 1.01 ± 0.13
saxpy/static workgroup=(1024,)/Float64/32768 0.0625 ± 0.025 ms 0.0606 ± 0.026 ms 1.03 ± 0.61
saxpy/static workgroup=(1024,)/Float64/4096 0.05 ± 0.018 ms 0.0495 ± 0.019 ms 1.01 ± 0.53
saxpy/static workgroup=(1024,)/Float64/512 0.0367 ± 0.019 ms 26.2 ± 11 μs 1.4 ± 0.93
saxpy/static workgroup=(1024,)/Float64/64 30.4 ± 15 μs 26.1 ± 9.3 μs 1.16 ± 0.7
saxpy/static workgroup=(1024,)/Float64/65536 0.086 ± 0.022 ms 0.081 ± 0.024 ms 1.06 ± 0.41
time_to_load 0.952 ± 0.0036 s 0.966 ± 0.0037 s 0.986 ± 0.0053

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@codecov

codecov Bot commented Feb 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.31%. Comparing base (17bdaed) to head (08522a2).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/pocl/device/runtime.jl 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #681      +/-   ##
==========================================
+ Coverage   52.21%   52.31%   +0.09%     
==========================================
  Files          22       22              
  Lines        1691     1688       -3     
==========================================
  Hits          883      883              
+ Misses        808      805       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vchuravy

vchuravy commented Jun 9, 2026

Copy link
Copy Markdown
Member

Blocked by #624 it seems like

@vchuravy

vchuravy commented Jun 9, 2026

Copy link
Copy Markdown
Member

Looks like this was also the Khronos backend.

@vchuravy
vchuravy merged commit 2a6bcc7 into main Jun 9, 2026
49 of 50 checks passed
@vchuravy
vchuravy deleted the error1.12 branch June 9, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants