efcore

feat: pluggable binary event serialization (IEventBinarySerializer) (#388) #575

Triggered via pull request August 2, 2026 18:36

jeremydmiller

opened #402

feat-388-binary-event-serialization

Status Success

Total duration 7m 36s

Artifacts –

efcore.yml

on: pull_request

Matrix: test

Annotations

20 warnings

test (edge) / test: src/Polecat/Storage/SqlServerDocumentStorageDescriptorBuilder.cs#L104

'this' argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicProperties' in call to 'System.Type.GetProperty(String)'. The generic parameter 'TDoc' of 'Polecat.Storage.SqlServerDocumentStorageDescriptorBuilder.Build<TDoc, TId>(DocumentMapping, IIdentification<TDoc, TId>, StoreOptions)' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.

test (edge) / test: src/Polecat/Storage/SqlServerDocumentStorageDescriptorBuilder.cs#L92

test (edge) / test: src/Polecat/Storage/SqlServerDocumentStorageDescriptorBuilder.cs#L78

test (edge) / test: src/Polecat/PolecatStoreServiceCollectionExtensions.cs#L75

Using member 'Polecat.Internal.SecondaryStoreProxyFactory.GetOrCreate(Type)' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. Generates a runtime subclass per secondary-store interface via System.Reflection.Emit.

test (edge) / test: src/Polecat/Storage/DocumentMappingExpression.cs#L110

Ambiguous reference in cref attribute: 'JsonIndex'. Assuming 'Polecat.Storage.DocumentMappingExpression<T>.JsonIndex(System.Linq.Expressions.Expression<System.Func<T, object?>>, System.Action<Polecat.Storage.JsonIndex>?)', but could have also matched other overloads including 'Polecat.Storage.DocumentMappingExpression<T>.JsonIndex(System.Action<Polecat.Storage.JsonIndex>?)'.

test (edge) / test: src/Polecat/Internal/Operations/RecordProgressionOperation.cs#L9

XML comment on 'RecordProgressionOperation' has a paramref tag for 'upsert', but there is no parameter by that name

test (edge) / test: src/Polecat/Internal/DocumentSessionBase.cs#L1028

Possible null reference assignment.

test (edge) / test: src/Polecat/Internal/DocumentSessionBase.cs#L1027

Possible null reference assignment.

test (edge) / test: src/Polecat/Internal/DocumentSessionBase.cs#L1026

Possible null reference assignment.

test (edge) / test: src/Polecat/Events/Storage/PolecatQuickAppendEventsOperation.cs#L339

Nullability of reference types in type of parameter 'transformed' of 'bool PolecatQuickAppendEventsOperation.TryTransform(Exception original, out Exception? transformed)' doesn't match implicitly implemented member 'bool IExceptionTransform.TryTransform(Exception original, out Exception? transformed)' (possibly because of nullability attributes).

test (default) / test: src/Polecat/Storage/SqlServerDocumentStorageDescriptorBuilder.cs#L104