Makefile to also generate targets for impacted objects when targetting specific objects

Author: worksofliam

cli/src/builders/make.ts

@@ -1,6 +1,6 @@
 import { existsSync, readFileSync } from 'fs';
 import path from 'path';
-import { ILEObject, ILEObjectTarget, ObjectType, Targets } from '../targets';
+import { ILEObject, ILEObjectTarget, ImpactedObject, ObjectType, Targets } from '../targets';
 import { asPosix } from '../utils';
 
 interface CompileData {
@@ -209,6 +209,24 @@ export class MakeProject {
 	public generateTargets(specificObjects?: ILEObject[]): string[] {
 		let lines = [];
 
+		if (specificObjects) {
+			const impacts = specificObjects.map(o => this.targets.getImpactFor(o));
+
+			let allAffected: ILEObject[] = [];
+
+			const addImpact = (impactedObj: ImpactedObject) => {
+				if (!allAffected.some(o => o.name === impactedObj.ileObject.name && o.type === impactedObj.ileObject.type)) {
+					allAffected.push(impactedObj.ileObject);
+				}
+
+				impactedObj.children.forEach(child => addImpact(child));
+			}
+
+			impacts.forEach(impact => addImpact(impact));
+
+			specificObjects = allAffected;
+		}
+
 		const all = specificObjects || [
 			...(this.targets.binderRequired() ? [this.targets.getBinderTarget()] : []),
 			...this.targets.getParentObjects(`PGM`),

cli/test/project.test.ts

@@ -248,7 +248,7 @@ describe.skipIf(files.length === 0)(`company_system tests`, () => {
     ].join());
   });
 
-  test(`Checking makefile rule generation`, async () => {
+  test(`Checking makefile rule generation`, () => {
     const project = new MakeProject(cwd, targets);
 
     const headerContent = project.generateGenericRules();
@@ -259,6 +259,52 @@ describe.skipIf(files.length === 0)(`company_system tests`, () => {
     expect(headerContent.find(l => l === `$(PREPATH)/DEPARTMENT.FILE: qddssrc/department.table`)).toBeDefined();
   });
 
+  test(`Makefile targets for all`, () => {
+    const project = new MakeProject(cwd, targets);
+
+    // Generate targets on it's own will have BNDDIR, PGM, etc
+    const headerContent = project.generateTargets();
+
+    const allTarget = headerContent.find(l => l.startsWith(`all:`));
+    expect(allTarget).toBeDefined();
+
+    expect(allTarget).toContain(`all: .logs .evfevent library`);
+    // The order cannot be guaranteed, so we just check for the presence of the targets
+    expect(allTarget).toContain(`$(PREPATH)/$(APP_BNDDIR).BNDDIR`);
+    expect(allTarget).toContain(`$(PREPATH)/MYPGM.PGM`);
+    expect(allTarget).toContain(`$(PREPATH)/DEPTS.PGM`);
+    expect(allTarget).toContain(`$(PREPATH)/EMPLOYEES.PGM`);
+  });
+
+  test(`Makefile targets for specific object (DEPTS display file)`, () => {
+    const project = new MakeProject(cwd, targets);
+
+    const deptsFile = targets.getDep({name: `DEPTS`, type: `FILE`});
+
+    // Generate targets on it's own will have BNDDIR, PGM, etc
+    const headerContent = project.generateTargets([deptsFile]);
+
+    const allTarget = headerContent.find(l => l.startsWith(`all:`));
+    expect(allTarget).toBeDefined();
+
+    expect(allTarget).toBe(`all: .logs .evfevent library $(PREPATH)/DEPTS.FILE $(PREPATH)/DEPTS.PGM`);
+  });
+
+  test(`Makefile targets for specific object (EMPLOYEE table)`, () => {
+    const project = new MakeProject(cwd, targets);
+
+    const deptsFile = targets.getDep({name: `EMPLOYEE`, type: `FILE`});
+
+    // Generate targets on it's own will have BNDDIR, PGM, etc
+    const headerContent = project.generateTargets([deptsFile]);
+
+    const allTarget = headerContent.find(l => l.startsWith(`all:`));
+    expect(allTarget).toBeDefined();
+
+    expect(allTarget).toBe(`all: .logs .evfevent library $(PREPATH)/EMPLOYEE.FILE $(PREPATH)/EMPLOYEES.PGM $(PREPATH)/DEPTS.PGM`);
+  });
+
+
   test(`Impact of EMPLOYEES`, () => {
     const empPgm = targets.getDep({name: `EMPLOYEES`, type: `PGM`});
     expect(empPgm.relativePath).toBe(path.join(`qrpglesrc`, `employees.pgm.sqlrpgle`));