Update static analyzer

* Rework tracking of source code coordinates in compiler
* Fix diagnostics
* Remove never worked warnings
* Remove unused variable states
* Organize, extend and clean up tests
* Improve diagnostic messages

Also

* Make test runner multithreaded
* Bump version to 4.13.7

Author: VasiliyRyabtsev

include/squirrel.h

@@ -78,7 +78,7 @@ namespace SQCompilation
 
 #define SQUIRREL_VERSION_NUMBER_MAJOR 4
 #define SQUIRREL_VERSION_NUMBER_MINOR 13
-#define SQUIRREL_VERSION_NUMBER_PATCH 0
+#define SQUIRREL_VERSION_NUMBER_PATCH 7
 
 #define SQ_STRINGIFY_HELPER(x) #x
 #define SQ_STRINGIFY(x) SQ_STRINGIFY_HELPER(x)

squirrel/ast_tools/ast_indent_render.h

@@ -243,11 +243,11 @@ class IndentedTreeRenderer : public Visitor {
                 ++_indent;
                 writeIndentedFmtString("Left\n");
                 ++_indent;
-                expr->_lhs->visit(this);
+                expr->lhs()->visit(this);
                 --_indent;
                 writeIndentedFmtString("Right\n");
                 ++_indent;
-                expr->_rhs->visit(this);
+                expr->rhs()->visit(this);
                 --_indent;
                 --_indent;
                 break;

squirrel/compiler/arena.h

@@ -229,12 +229,27 @@ class ArenaVector {
 public:
     using size_type = uint32_t;
 
-    ArenaVector(Arena *arena) :
-    _arena(arena),
-    _vals(NULL),
-    _size(0),
-    _allocated(0) {
+    ArenaVector(Arena *arena)
+        : _arena(arena)
+        , _vals(NULL)
+        , _size(0)
+        , _allocated(0)
+    {
+    }
 
+    // Implement if needed
+    ArenaVector(const ArenaVector&) = delete;
+    ArenaVector& operator=(const ArenaVector&) = delete;
+
+    ArenaVector(ArenaVector&& other) noexcept
+        : _arena(other._arena)
+        , _vals(other._vals)
+        , _size(other._size)
+        , _allocated(other._allocated)
+    {
+        other._vals = nullptr;
+        other._size = 0;
+        other._allocated = 0;
     }
 
     inline T &push_back(const T& val = T())

squirrel/compiler/ast.cpp

@@ -321,6 +321,8 @@ void IncExpr::transformChildren(Transformer *transformer) {
   _arg = _arg->transform(transformer)->asExpression();
 }
 
+DeclExpr::DeclExpr(Decl *decl) : Expr(TO_DECL_EXPR, decl->sourceSpan()), _decl(decl) {}
+
 void DeclExpr::visitChildren(Visitor *visitor) { _decl->visit(visitor); }
 
 void DeclExpr::transformChildren(Transformer *transformer) {
@@ -411,7 +413,11 @@ void FunctionDecl::transformChildren(Transformer *transformer) {
   setBody(body()->transform(transformer)->asStatement()->asBlock());
 }
 
-void FunctionDecl::setBody(Block *body) { _body = body; body->setIsBody(); }
+void FunctionDecl::setBody(Block *body) {
+    _body = body;
+    body->setIsBody();
+    setSpanEnd(body->sourceSpan().end);
+}
 
 void ConstDecl::visitChildren(Visitor *visitor) {
   _value->visit(visitor);
@@ -422,7 +428,6 @@ void ConstDecl::transformChildren(Transformer *transformer) {
 }
 
 void DeclGroup::visitChildren(Visitor *visitor) {
-
     for (auto decl : declarations())
         decl->visit(visitor);
 }