Bug in Example file, sign_csr writes from wrong certificate?

[DanielGahler]

Should this not be cert.public bytes instead of csr.public bytes?

Surely we need the public bytes of the signed certificate, not of the original CSR?

@oroulet @olivier

Originally posted by @DanielGahler in 83a64f1

originally discovered by @cbosoft

[DanielGahler]

Above is the commit that introduced the change. It is on master:

opcua-asyncio/examples/generate_certificates.py

Line 115 in b5006cc

await f.write(csr.public_bytes(encoding=Encoding.PEM))

[DanielGahler]

Also this line appears redundant:

opcua-asyncio/examples/generate_certificates.py

Line 91 in b5006cc

key: RSAPrivateKey = generate_private_key()

No point in generating a new key, especially when it's directly overwritten by the loaded key in the next line.