Engine: Log index rebuild progress and failures

Also make sure that we pass a HubContextProgressNotifier to
IndexRebuildService.RebuildIndexAsync().

This also removes some private methods that are not really necessary.

Author: kennethmyhra

Applications/Spark.Web.Shared/Hubs/HubContextProgressNotifier.cs

@@ -5,9 +5,9 @@
  */
 
 using Microsoft.AspNetCore.SignalR;
-using Tasks = System.Threading.Tasks;
 using Microsoft.Extensions.Logging;
 using Spark.Engine.Service.FhirServiceExtensions;
+using System.Threading.Tasks;
 
 namespace Spark.Web.Hubs;
 
@@ -31,10 +31,20 @@ public HubContextProgressNotifier(
         _logger = logger;
     }
 
-    public async Tasks.Task SendProgressUpdate(int progress, string message)
+    public Task ReportProgressAsync(int progress, string message)
     {
-        _logger.LogInformation($"[{progress}%] {message}");
+        _logger.LogInformation("[{Progress}%] {Message}", progress, message);
+        return SendProgressUpdate(progress, message);
+    }
+
+    public Task ReportErrorAsync(string message)
+    {
+        _logger.LogError("[{Progress}%] {Message}", _progress, message);
+        return SendProgressUpdate(_progress, message);
+    }
 
+    private Task SendProgressUpdate(int progress, string message)
+    {
         _progress = progress;
 
         var msg = new ProgressMessage
@@ -43,23 +53,6 @@ public async Tasks.Task SendProgressUpdate(int progress, string message)
             Progress = progress
         };
 
-        await _hubContext.Clients.All.SendAsync("UpdateProgress", msg);
-    }
-
-    public async Tasks.Task Progress(string message)
-    {
-        await SendProgressUpdate(_progress, message);
-    }
-
-    public async Tasks.Task ReportProgressAsync(int progress, string message)
-    {
-        await SendProgressUpdate(progress, message)
-            .ConfigureAwait(false);
-    }
-
-    public async Tasks.Task ReportErrorAsync(string message)
-    {
-        await Progress(message)
-            .ConfigureAwait(false);
+        return _hubContext.Clients.All.SendAsync("UpdateProgress", msg);
     }
 }

Applications/Spark.Web.Shared/Hubs/MaintenanceHub.cs

@@ -89,7 +89,7 @@ public async Task RebuildIndex()
         try
         {
             await _hubContext.Clients.All.SendAsync("UpdateProgress", "Rebuilding index...");
-            await _indexRebuildService.RebuildIndexAsync();
+            await _indexRebuildService.RebuildIndexAsync(new HubContextProgressNotifier(_hubContext, _logger));
             await _hubContext.Clients.All.SendAsync("UpdateProgress", "Index rebuilt!");
         }
         catch (Exception e)