ENG-9556: Remove url for breadcrumbs with no associated doc page (reflex-dev#6591)

* ENG-9556: Remove url for breadcrumbs with no associated doc page

* update

---------

Co-authored-by: Farhan Ali Raza <62690310+FarhanAliRaza@users.noreply.github.com>

Author: carlosabadia

docs/app/reflex_docs/templates/docpage/docpage.py

@@ -24,6 +24,15 @@
 
 _REGISTERED_DOC_ROUTES: set[str] = set()
 
+# Title-cased breadcrumb labels that should be displayed as acronyms.
+_BREADCRUMB_LABEL_OVERRIDES: dict[str, str] = {
+    "Ai": "AI",
+    "Api": "API",
+    "Sdk": "SDK",
+    "Cli": "CLI",
+    "Css": "CSS",
+}
+
 
 def _normalize_doc_route(path: str) -> str:
     """Normalize a docs route to use leading and trailing slashes."""
@@ -38,8 +47,24 @@ def _register_doc_route(path: str) -> None:
 
 def _resolve_breadcrumb_href(
     href: str, registered_routes: Collection[str] | None = None
-) -> str:
-    """Resolve a generated breadcrumb href to a registered docs route."""
+) -> str | None:
+    """Resolve a generated breadcrumb href to a registered docs route.
+
+    Breadcrumbs are built from path segments, but intermediate segments (e.g.
+    ``/ai`` or ``/hosting``) are often just categories with no page of their
+    own. This returns the matching route, preferring an ``overview`` child when
+    the bare path is not itself a page, or ``None`` when no registered route
+    exists so the caller can render the segment as non-clickable text instead of
+    a broken link.
+
+    Args:
+        href: The generated, app-relative breadcrumb href (no ``/docs`` prefix).
+        registered_routes: Routes to match against. Defaults to the routes
+            registered through the docpage template.
+
+    Returns:
+        The resolved route, or ``None`` if no registered route matches.
+    """
     routes = _REGISTERED_DOC_ROUTES if registered_routes is None else registered_routes
     route = _normalize_doc_route(href)
     if route in routes:
@@ -49,7 +74,7 @@ def _resolve_breadcrumb_href(
     if overview_route in routes:
         return overview_route
 
-    return href
+    return None
 
 
 class FeedbackState(rx.State):
@@ -678,17 +703,31 @@ def breadcrumb(path: str, nav_sidebar: rx.Component, doc_content: str | None = N
     for i, segment in enumerate(segments):
         current_path += f"/{segment}"
 
-        # Add the breadcrumb item to the list
-        breadcrumbs.append(
-            rx.el.a(
-                to_title_case(to_snake_case(segment), sep=" "),
-                class_name="min-h-8 flex items-center text-sm font-[525] text-m-slate-12 dark:text-m-slate-3 last:text-m-slate-7 dark:last:text-m-slate-6 hover:text-primary-10 dark:hover:text-primary-9"
-                + (" truncate" if i == len(segments) - 1 else ""),
-                underline="none",
-                href=_resolve_breadcrumb_href(current_path),
-            )
+        label = to_title_case(to_snake_case(segment), sep=" ")
+        label = _BREADCRUMB_LABEL_OVERRIDES.get(label, label)
+        base_class = ui.cn(
+            "min-h-8 flex items-center text-sm font-[525] text-m-slate-12 dark:text-m-slate-3 last:text-m-slate-7 dark:last:text-m-slate-6",
+            "truncate" if i == len(segments) - 1 else "",
         )
 
+        # Category segments (e.g. /ai, /hosting) often have no page of their own.
+        # Render those as plain text so the breadcrumb doesn't link to a 404.
+        href = _resolve_breadcrumb_href(current_path)
+        if href is None:
+            breadcrumbs.append(rx.el.span(label, class_name=base_class))
+        else:
+            breadcrumbs.append(
+                rx.el.a(
+                    label,
+                    class_name=ui.cn(
+                        base_class,
+                        "hover:text-primary-10 dark:hover:text-primary-9",
+                    ),
+                    underline="none",
+                    href=href,
+                )
+            )
+
         # If it's not the last segment, add a separator
         if i < len(segments) - 1:
             breadcrumbs.append(

docs/app/tests/test_breadcrumbs.py

@@ -26,3 +26,37 @@ def test_enterprise_parent_breadcrumb_uses_overview_route(monkeypatch):
     assert 'to:"/enterprise/overview/"' in rendered
     assert 'to:"/enterprise/ag-grid/"' in rendered
     assert 'to:"/enterprise/ag-grid/pivot-mode/"' in rendered
+
+
+def test_missing_parent_breadcrumb_is_not_clickable(monkeypatch):
+    """Breadcrumb segments without a real route should not be clickable links."""
+    docpage_module = importlib.import_module("reflex_docs.templates.docpage.docpage")
+    # Only the leaf page is a registered route; the "ai" and "ai/overview"
+    # parents have no page and no overview child (mirrors /docs/ai 404s).
+    monkeypatch.setattr(
+        docpage_module,
+        "_REGISTERED_DOC_ROUTES",
+        {"/ai/overview/some-feature/"},
+        raising=False,
+    )
+
+    rendered = str(docpage_module.breadcrumb("/ai/overview/some-feature/", rx.box()))
+
+    # The leaf resolves to a real route and stays clickable.
+    assert 'to:"/ai/overview/some-feature/"' in rendered
+    # The missing parents must not render as links to broken URLs.
+    assert 'to:"/ai/"' not in rendered
+    assert 'to:"/ai/overview/"' not in rendered
+    # Their labels are still shown as plain text ("ai" renders as "AI").
+    assert "AI" in rendered
+    assert "Overview" in rendered
+
+
+def test_resolve_breadcrumb_href_returns_none_for_missing_route():
+    """A path with no registered route or overview child resolves to None."""
+    docpage_module = importlib.import_module("reflex_docs.templates.docpage.docpage")
+
+    assert (
+        docpage_module._resolve_breadcrumb_href("/hosting", {"/hosting/deploy/"})
+        is None
+    )