Deprecate lucy-2.1-vton

Author: AdirAmsalem

include/decart/models.h

@@ -27,7 +27,7 @@ namespace models {
 
 /// Resolve a realtime model by name.
 ///
-/// Accepts canonical names ("lucy-2.1", "lucy-2.1-vton", "lucy-vton-2",
+/// Accepts canonical names ("lucy-2.1", "lucy-vton-2",
 /// "lucy-vton-3", "lucy-restyle-2"), server-resolved aliases ("lucy-latest",
 /// "lucy-vton-latest", "lucy-restyle-latest"), and deprecated names (which emit
 /// no error but resolve to the same stream endpoint).

src/models.cpp

@@ -20,10 +20,9 @@ struct Entry {
 
 // Realtime model registry. Kept in sync with the shared model list across the
 // Decart SDKs. All realtime models stream over `/v1/stream` at 30 fps.
-constexpr std::array<Entry, 11> kRealtime = {{
+constexpr std::array<Entry, 9> kRealtime = {{
     // Canonical
     {"lucy-2.1", 1088, 624, true},
-    {"lucy-2.1-vton", 1088, 624, true},
     {"lucy-vton-2", 1088, 624, true},
     {"lucy-vton-3", 1088, 624, true},
     {"lucy-restyle-2", 1280, 704, true},
@@ -33,7 +32,6 @@ constexpr std::array<Entry, 11> kRealtime = {{
     {"lucy-restyle-latest", 1280, 704, false},
     // Deprecated aliases (still accepted)
     {"mirage_v2", 1280, 704, false},
-    {"lucy-vton", 1088, 624, false},
     {"lucy-2.1-vton-2", 1088, 624, false},
 }};
 

tests/test_models.cpp

@@ -23,12 +23,16 @@ TEST_CASE("realtime() accepts latest and deprecated aliases") {
   CHECK(models::realtime("lucy-latest").urlPath == "/v1/stream");
   CHECK(models::realtime("lucy-vton-latest").name == "lucy-vton-latest");
   CHECK(models::realtime("mirage_v2").width == 1280); // deprecated -> restyle geometry
-  CHECK(models::isRealtimeModel("lucy-vton"));
+  CHECK(models::isRealtimeModel("lucy-2.1-vton-2"));
 }
 
 TEST_CASE("realtime() throws ModelNotFound for unknown names") {
   CHECK_FALSE(models::isRealtimeModel("not-a-model"));
+  CHECK_FALSE(models::isRealtimeModel("lucy-2.1-vton"));
+  CHECK_FALSE(models::isRealtimeModel("lucy-vton"));
   CHECK_THROWS_AS(models::realtime("not-a-model"), Exception);
+  CHECK_THROWS_AS(models::realtime("lucy-2.1-vton"), Exception);
+  CHECK_THROWS_AS(models::realtime("lucy-vton"), Exception);
   try {
     models::realtime("nope");
   } catch (const Exception& e) {
@@ -41,6 +45,10 @@ TEST_CASE("realtime() throws ModelNotFound for unknown names") {
 TEST_CASE("listRealtime() honors canonicalOnly") {
   auto all = models::listRealtime(/*canonicalOnly=*/false);
   auto canonical = models::listRealtime(/*canonicalOnly=*/true);
-  CHECK(canonical.size() == 5);
-  CHECK(all.size() > canonical.size());
+  CHECK(canonical.size() == 4);
+  CHECK(all.size() == 9);
+  for (const auto& model : all) {
+    CHECK(model.name != "lucy-2.1-vton");
+    CHECK(model.name != "lucy-vton");
+  }
 }