Merge pull request #11 from qld-gov-au/develop

Fix fullname update

Author: smotornyuk

ckanext/oidc_pkce/config.py

@@ -137,7 +137,7 @@ def same_id() -> bool:
 
 
 def munge_password() -> bool:
-    """Override existing pasword for account with a random one, preventing
+    """Override existing password for account with a random one, preventing
     direct login.
 
     """

ckanext/oidc_pkce/interfaces.py

@@ -50,6 +50,8 @@ def get_oidc_user(self, userinfo: dict[str, Any]) -> Optional[model.User]:
             data = self.oidc_info_into_user_dict(userinfo)
             data["id"] = user.id
             data.pop("name")
+            if user_dict.get("fullname", None):
+                data.pop("fullname")  # Don't override fullname if it is already populated
 
             if not config.munge_password():
                 data.pop("password")
@@ -59,9 +61,7 @@ def get_oidc_user(self, userinfo: dict[str, Any]) -> Optional[model.User]:
 
             user_dict.update(data)
             user_dict.pop("name")  # Username is untouched, so exclude it from the update payload.
-            if user_dict.get("fullname", None):
-                data.pop("fullname")  # Don't override fullname if it is already populated
-            tk.get_action("user_update")({"user": admin["name"]}, user_dict)
+            tk.get_action("user_patch")({"user": admin["name"]}, user_dict)
 
             signals.user_sync.send(user.id)
             return user