switch to a better action without lvm hacks

Author: rochdev

.github/actions/pull_images/action.yml

@@ -22,6 +22,18 @@ inputs:
 runs:
   using: composite
   steps:
+    - name: Free Disk Space
+      uses: endersonmenezes/free-disk-space@v3
+      with:
+        remove_android: false # Takes a long time to remove even with rmz
+        remove_dotnet: true # Pretty quick and saves a lot
+        remove_haskell: true # Extremely quick and saves a lot
+        remove_tool_cache: false # Decent savings but not fast enough
+        remove_packages: false # By far the slowest option
+        remove_packages_one_command: true
+        remove_folders: "/usr/share/swift /usr/share/az* /usr/local/share/chromium"
+        rm_cmd: "rmz"  # Use 'rmz' for faster deletion (default: 'rm')
+        rmz_version: "3.1.1"  # Required when rm_cmd is 'rmz'
     - name: Get image list
       shell: bash
       run: |

.github/workflows/run-end-to-end.yml

@@ -118,111 +118,6 @@ jobs:
       SYSTEM_TESTS_FORCE_EXECUTE: ${{ inputs.force_execute }}
       SYSTEM_TESTS_DEV_MODE: ${{ inputs._system_tests_dev_mode }}
     steps:
-      # Cleanup code from https://github.com/easimon/maximize-build-space
-    - name: Disk space report before modification
-      shell: bash
-      run: |
-        echo "Memory and swap:"
-        sudo free -h
-        echo
-        sudo swapon --show
-        echo
-
-        echo "Available storage:"
-        sudo df -h
-        echo
-    - name: Maximize build disk space
-      shell: bash
-      run: |
-        set -euo pipefail
-
-        # # absolute file path for the LVM image created on the root filesystem
-        # PV_LOOP_PATH="/pv.img"
-
-        # # absolute file path for the LVM image created on the temp filesystem
-        # TMP_PV_LOOP_PATH="/mnt/tmp-pv.img"
-
-        # # store owner of $GITHUB_WORKSPACE in case the action deletes it
-        # WORKSPACE_OWNER="$(stat -c '%U:%G' "${GITHUB_WORKSPACE}")"
-
-        # # ensure mount path exists before the action
-        # sudo mkdir -p "${GITHUB_WORKSPACE}"
-        # sudo find "${GITHUB_WORKSPACE}" -maxdepth 0 ! -empty -exec echo 'WARNING: directory [{}] is not empty, data loss might occur. Content:' \; -exec ls -al "{}" \;
-
-        # only android system images removed, the rest takes too long
-        # docker cache not removed because we use Docker so it could be useful
-        echo "Removing unwanted software... "
-        echo "  Android System Images... "
-        sudo rm -rf /usr/local/lib/android/sdk/system-images
-        echo "  .NET... "
-        sudo rm -rf /usr/share/dotnet
-        echo "  Haskell... "
-        sudo rm -rf /opt/ghc
-        echo "  CodeQL... "
-        sudo rm -rf /opt/hostedtoolcache/CodeQL
-        echo "... done"
-
-        # VG_NAME=buildvg
-
-        # # github runners have an active swap file in /mnt/swapfile
-        # # we want to reuse the temp disk, so first unmount swap and clean the temp disk
-        # echo "Unmounting and removing swap file."
-        # sudo swapoff -a
-        # sudo rm -f /mnt/swapfile
-
-        # echo "Creating LVM Volume."
-        # echo "  Creating LVM PV on root fs."
-        # # create loop pv image on root fs
-        # ROOT_RESERVE_KB=$(expr 1024 \* 1024)
-        # ROOT_FREE_KB=$(df --block-size=1024 --output=avail / | tail -1)
-        # ROOT_LVM_SIZE_KB=$(expr $ROOT_FREE_KB - $ROOT_RESERVE_KB)
-        # ROOT_LVM_SIZE_BYTES=$(expr $ROOT_LVM_SIZE_KB \* 1024)
-        # sudo touch "${PV_LOOP_PATH}" && sudo fallocate -z -l "${ROOT_LVM_SIZE_BYTES}" "${PV_LOOP_PATH}"
-        # export ROOT_LOOP_DEV=$(sudo losetup --find --show "${PV_LOOP_PATH}")
-        # sudo pvcreate -f "${ROOT_LOOP_DEV}"
-
-        # # create pv on temp disk
-        # echo "  Creating LVM PV on temp fs."
-        # TMP_RESERVE_KB=$(expr 100 \* 1024)
-        # TMP_FREE_KB=$(df --block-size=1024 --output=avail /mnt | tail -1)
-        # TMP_LVM_SIZE_KB=$(expr $TMP_FREE_KB - $TMP_RESERVE_KB)
-        # TMP_LVM_SIZE_BYTES=$(expr $TMP_LVM_SIZE_KB \* 1024)
-        # sudo touch "${TMP_PV_LOOP_PATH}" && sudo fallocate -z -l "${TMP_LVM_SIZE_BYTES}" "${TMP_PV_LOOP_PATH}"
-        # export TMP_LOOP_DEV=$(sudo losetup --find --show "${TMP_PV_LOOP_PATH}")
-        # sudo pvcreate -f "${TMP_LOOP_DEV}"
-
-        # # create volume group from these pvs
-        # sudo vgcreate "${VG_NAME}" "${TMP_LOOP_DEV}" "${ROOT_LOOP_DEV}"
-
-        # echo "Recreating swap"
-        # # create and activate swap
-        # sudo lvcreate -L "4096M" -n swap "${VG_NAME}"
-        # sudo mkswap "/dev/mapper/${VG_NAME}-swap"
-        # sudo swapon "/dev/mapper/${VG_NAME}-swap"
-
-        # echo "Creating build volume"
-        # # create and mount build volume
-        # sudo lvcreate -l 100%FREE -n buildlv "${VG_NAME}"
-        # sudo mkfs.ext4 -Enodiscard -m0 "/dev/mapper/${VG_NAME}-buildlv"
-        # sudo mount "/dev/mapper/${VG_NAME}-buildlv" "${GITHUB_WORKSPACE}"
-        # sudo chown -R "runner:runner" "${GITHUB_WORKSPACE}"
-
-        # # if build mount path is a parent of $GITHUB_WORKSPACE, and has been deleted, recreate it
-        # if [[ ! -d "${GITHUB_WORKSPACE}" ]]; then
-        #   sudo mkdir -p "${GITHUB_WORKSPACE}"
-        #   sudo chown -R "${WORKSPACE_OWNER}" "${GITHUB_WORKSPACE}"
-        # fi
-    - name: Disk space report after modification
-      shell: bash
-      run: |
-        echo "Memory and swap:"
-        sudo free -h
-        echo
-        sudo swapon --show
-        echo
-
-        echo "Available storage:"
-        sudo df -h
     - name: Compute ref
       id: compute_ref
       run: |
@@ -267,17 +162,6 @@ jobs:
         scenarios: ${{ inputs.scenarios }}
         dockerhub_username: ${{ secrets.DOCKERHUB_USERNAME }}
         dockerhub_token: ${{ secrets.DOCKERHUB_TOKEN }}
-    - name: Disk space report after pulling
-      shell: bash
-      run: |
-        echo "Memory and swap:"
-        sudo free -h
-        echo
-        sudo swapon --show
-        echo
-
-        echo "Available storage:"
-        sudo df -h
     - name: Build weblog
       id: build
       run: |