Skip to content

Commit df8d6c4

Browse files
Fixed tests for arm64
1 parent ca702f5 commit df8d6c4

File tree

2 files changed

+27
-17
lines changed

2 files changed

+27
-17
lines changed

.gitlab-ci.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -839,6 +839,7 @@ muzzle-dep-report:
839839
TESTCONTAINERS_HUB_IMAGE_NAME_PREFIX: "registry.ddbuild.io/images/mirror/"
840840
JETTY_AVAILABLE_PROCESSORS: 4
841841
before_script:
842+
- source .gitlab/gitlab-utils.sh
842843
- apt-get update
843844
- apt-get install -y --no-install-recommends git
844845
- export ORG_GRADLE_PROJECT_mavenRepositoryProxy=$MAVEN_REPOSITORY_PROXY
@@ -854,6 +855,12 @@ muzzle-dep-report:
854855
- export GRADLE_USER_HOME=$(pwd)/.gradle
855856
- sed -i "s|https://repo.maven.apache.org/maven2/|$MAVEN_REPOSITORY_PROXY|g" .mvn/wrapper/maven-wrapper.properties
856857
- *normalize_node_index
858+
- gitlab_section_start "gradle-dance" "Fix .gradle directory permissions"
859+
- cp -r .gradle .gradle-copy
860+
- rm -rf .gradle
861+
- mv .gradle-copy .gradle
862+
- ls -la
863+
- gitlab_section_end "gradle-dance"
857864
- *prepare_test_env
858865
- export GRADLE_OPTS="-Dorg.gradle.jvmargs='-Xms$GRADLE_MEMORY_MIN -Xmx$GRADLE_MEMORY_MAX -XX:ErrorFile=/tmp/hs_err_pid%p.log -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=/tmp -Djava.util.prefs.userRoot=/tmp/.java/.userPrefs-${CI_JOB_ID}' -Ddatadog.forkedMinHeapSize=128M -Ddatadog.forkedMaxHeapSize=1024M"
859866
- export GRADLE_ARGS="--build-cache --stacktrace --no-daemon --parallel --max-workers=$GRADLE_WORKERS"

communication/src/test/java/datadog/communication/serialization/msgpack/MsgPackWriterTest.java

Lines changed: 20 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package datadog.communication.serialization.msgpack;
22

33
import static datadog.trace.util.stacktrace.StackTraceEvent.DEFAULT_LANGUAGE;
4+
import static java.nio.charset.StandardCharsets.UTF_8;
45
import static org.junit.jupiter.api.Assertions.assertArrayEquals;
56
import static org.junit.jupiter.api.Assertions.assertEquals;
67
import static org.junit.jupiter.api.Assertions.assertFalse;
@@ -19,7 +20,6 @@
1920
import java.math.BigDecimal;
2021
import java.nio.ByteBuffer;
2122
import java.nio.CharBuffer;
22-
import java.nio.charset.StandardCharsets;
2323
import java.util.ArrayList;
2424
import java.util.Arrays;
2525
import java.util.Collections;
@@ -33,6 +33,9 @@
3333
import org.msgpack.core.MessageUnpacker;
3434

3535
public class MsgPackWriterTest {
36+
private static final String NON_ASCII_STRING = "foobár";
37+
private static final byte[] NON_ASCII_BYTES = NON_ASCII_STRING.getBytes(UTF_8);
38+
private static final int NON_ASCII_BUFFER_CAPACITY = NON_ASCII_BYTES.length + 4;
3639

3740
@Test
3841
public void testOverflow() {
@@ -141,13 +144,12 @@ public void testWriteBinaryNoArgVariant() {
141144
MessageUnpacker unpacker = MessagePack.newDefaultUnpacker(buffer);
142145
try {
143146
assertEquals(unpacker.unpackBinaryHeader(), 6);
144-
assertArrayEquals(
145-
unpacker.readPayload(6), "foobar".getBytes(StandardCharsets.UTF_8));
147+
assertArrayEquals(unpacker.readPayload(6), "foobar".getBytes(UTF_8));
146148
} catch (IOException e) {
147149
Assertions.fail(e.getMessage());
148150
}
149151
}));
150-
writer.writeBinary("foobar".getBytes(StandardCharsets.UTF_8));
152+
writer.writeBinary("foobar".getBytes(UTF_8));
151153
}
152154

153155
@Test
@@ -628,16 +630,17 @@ public void testWriteObjectArray() {
628630

629631
@Test
630632
public void testWriteStringUTF8BytesString() {
631-
UTF8BytesString value = UTF8BytesString.create("foobár");
633+
UTF8BytesString value = UTF8BytesString.create(NON_ASCII_STRING);
634+
int encodedLength = value.encodedLength();
632635
MsgPackWriter writer =
633636
new MsgPackWriter(
634637
newBuffer(
635-
20,
638+
(encodedLength + 4) * 2,
636639
(messageCount, buffer) -> {
637640
MessageUnpacker unpacker = MessagePack.newDefaultUnpacker(buffer);
638641
try {
639-
assertEquals(unpacker.unpackString(), "foobár");
640-
assertEquals(unpacker.unpackString(), "foobár");
642+
assertEquals(unpacker.unpackString(), NON_ASCII_STRING);
643+
assertEquals(unpacker.unpackString(), NON_ASCII_STRING);
641644
} catch (IOException e) {
642645
Assertions.fail(e.getMessage());
643646
}
@@ -671,7 +674,7 @@ public void testWriteObjectStringGeneralPath() {
671674
new Object() {
672675
@Override
673676
public String toString() {
674-
return "foobár";
677+
return NON_ASCII_STRING;
675678
}
676679
};
677680
MsgPackWriter writer =
@@ -681,31 +684,31 @@ public String toString() {
681684
(messageCount, buffer) -> {
682685
MessageUnpacker unpacker = MessagePack.newDefaultUnpacker(buffer);
683686
try {
684-
assertEquals(unpacker.unpackString(), "foobár");
687+
assertEquals(unpacker.unpackString(), NON_ASCII_STRING);
685688
assertEquals(unpacker.unpackString(), "foobàr");
686689
} catch (IOException e) {
687690
Assertions.fail(e.getMessage());
688691
}
689692
}));
690693
writer.writeObjectString(value, null);
691-
writer.writeObjectString(value, s -> "foobàr".getBytes(StandardCharsets.UTF_8));
694+
writer.writeObjectString(value, s -> "foobàr".getBytes(UTF_8));
692695
}
693696

694697
@Test
695698
public void testWriteStringGeneralCharSequence() {
696699
MsgPackWriter writer =
697700
new MsgPackWriter(
698701
newBuffer(
699-
10,
702+
NON_ASCII_BUFFER_CAPACITY,
700703
(messageCount, buffer) -> {
701704
MessageUnpacker unpacker = MessagePack.newDefaultUnpacker(buffer);
702705
try {
703-
assertEquals(unpacker.unpackString(), "foobár");
706+
assertEquals(unpacker.unpackString(), NON_ASCII_STRING);
704707
} catch (IOException e) {
705708
Assertions.fail(e.getMessage());
706709
}
707710
}));
708-
CharBuffer charSeq = CharBuffer.wrap("foobár");
711+
CharBuffer charSeq = CharBuffer.wrap(NON_ASCII_STRING);
709712
writer.writeString(charSeq, null);
710713
}
711714

@@ -714,16 +717,16 @@ public void testWriteStringEncodingCache() {
714717
MsgPackWriter writer =
715718
new MsgPackWriter(
716719
newBuffer(
717-
10,
720+
NON_ASCII_BUFFER_CAPACITY,
718721
(messageCount, buffer) -> {
719722
MessageUnpacker unpacker = MessagePack.newDefaultUnpacker(buffer);
720723
try {
721-
assertEquals(unpacker.unpackString(), "foobár");
724+
assertEquals(unpacker.unpackString(), NON_ASCII_STRING);
722725
} catch (IOException e) {
723726
Assertions.fail(e.getMessage());
724727
}
725728
}));
726-
writer.writeString("", s -> "foobár".getBytes(StandardCharsets.UTF_8));
729+
writer.writeString("", s -> NON_ASCII_BYTES);
727730
}
728731

729732
@Test

0 commit comments

Comments
 (0)