move logging of cmd.SysProcAttr.CmdLine to the windows specific files, unixes do not have it

Author: inqrphl

pkg/snclient/snclient.go

@@ -1368,14 +1368,8 @@ func (snc *Agent) MakeCmd(ctx context.Context, command string) (*exec.Cmd, error
 		return nil, err
 	case cmd.Args != nil:
 		log.Tracef("command object:\n path: %s\n args: %v\n dir: %s\n workingDirectory: %s\n SysProcAttr: %#v\n", cmd.Path, cmd.Args, cmd.Dir, workingDirectory, cmd.SysProcAttr)
-		if cmd.SysProcAttr != nil {
-			log.Tracef("cmd.SysProcAttr.CmdLine: %s", cmd.SysProcAttr.CmdLine)
-		}
 	default:
 		log.Tracef("command object:\n path: %s\n args: (none)\n dir: %s\n workingDirectory: %s\n SysProcAttr: %#v\n", cmd.Path, cmd.Dir, workingDirectory, cmd.SysProcAttr)
-		if cmd.SysProcAttr != nil {
-			log.Tracef("cmd.SysProcAttr.CmdLine: %s", cmd.SysProcAttr.CmdLine)
-		}
 	}
 
 	return cmd, err

pkg/snclient/snclient_windows.go

@@ -262,6 +262,8 @@ func (snc *Agent) makeCmd(ctx context.Context, command string) (*exec.Cmd, error
 		cmd := execCommandContext(ctx, "powershell", env)
 		cmd.SysProcAttr.CmdLine = fmt.Sprintf(`%s -command %s; exit($LASTEXITCODE)`, POWERSHELL, command)
 
+		log.Tracef("cmd.SysProcAttr.CmdLine: %s", cmd.SysProcAttr.CmdLine)
+
 		return cmd, nil
 
 	// command does not exist
@@ -283,6 +285,8 @@ func (snc *Agent) makeCmd(ctx context.Context, command string) (*exec.Cmd, error
 			strings.Join(cmdArgs, " "),
 		)
 
+		log.Tracef("cmd.SysProcAttr.CmdLine: %s", cmd.SysProcAttr.CmdLine)
+
 		return cmd, nil
 
 	// powershell files
@@ -308,6 +312,8 @@ func (snc *Agent) makeCmd(ctx context.Context, command string) (*exec.Cmd, error
 		cmd := execCommandContext(ctx, "powershell", env)
 		cmd.SysProcAttr.CmdLine = fmt.Sprintf(`%s -Command ". '%s' %s ; exit($LASTEXITCODE)"`, POWERSHELL, cmdName, strings.Join(cmdArgsModified, " "))
 
+		log.Tracef("cmd.SysProcAttr.CmdLine: %s", cmd.SysProcAttr.CmdLine)
+
 		return cmd, nil
 
 	// other command but no shell special characters
@@ -325,6 +331,8 @@ func (snc *Agent) makeCmd(ctx context.Context, command string) (*exec.Cmd, error
 			shell,
 			strings.Replace(command, cmdName, syscall.EscapeArg(cmdName), 1))
 
+		log.Tracef("cmd.SysProcAttr.CmdLine: %s", cmd.SysProcAttr.CmdLine)
+
 		return cmd, nil
 	}
 }